public inbox for linux-staging@lists.linux.dev
 help / color / mirror / Atom feed
From: Jonathan Bergh <bergh.jonathan@gmail.com>
To: Greg KH <gregkh@linuxfoundation.org>
Cc: linux-staging@lists.linux.dev, linux-kernel@vger.kernel.org
Subject: Re: [PATCH] staging: octeon: Fix warnings due to introduction of new typedefs
Date: Sat, 21 Oct 2023 10:59:21 +0200	[thread overview]
Message-ID: <ZTOS6eaygOA6nRKD@HP-ENVY-Notebook> (raw)
In-Reply-To: <2023102111-sneak-abreast-8061@gregkh>

On Sat, Oct 21, 2023 at 10:32:29AM +0200, Greg KH wrote:

Hi

>  This looks like a new version of a previously submitted patch, but you
>  did not list below the --- line any changes from the previous version.

This patch is a *new* patch which replaced a previous *series* of patches
so it was considered a *new* standalone patch, rather than a new version 
of the original series. 
  
> - Your patch did many different things all at once, making it difficult
>   to review.  All Linux kernel patches need to only do one thing at a
>   time.  If you need to do multiple things (such as clean up all coding
>   style issues in a file/driver), do it in a sequence of patches, each
>   one doing only one thing.

This patch only addresses removal of typedefs from the declarations 
and fixes up the implmentations that relied on those typedefs. The previous
advice was to not make breaking changes across patches, so this patch 
represents code changes which are as atomic as possible in a single patch
without breaking the build. It does not mix formatting / other changes
with the code change. 

  reply	other threads:[~2023-10-21  8:59 UTC|newest]

Thread overview: 6+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2023-10-21  8:14 [PATCH] staging: octeon: Fix warnings due to introduction of new typedefs Jonathan Bergh
2023-10-21  8:21 ` Greg KH
2023-10-21  8:32 ` Greg KH
2023-10-21  8:59   ` Jonathan Bergh [this message]
2023-10-21  9:05     ` Greg KH
2023-10-21  9:08       ` Jonathan Bergh

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=ZTOS6eaygOA6nRKD@HP-ENVY-Notebook \
    --to=bergh.jonathan@gmail.com \
    --cc=gregkh@linuxfoundation.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-staging@lists.linux.dev \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox