From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-oi1-f172.google.com (mail-oi1-f172.google.com [209.85.167.172]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 63D8519BA8 for ; Mon, 30 Oct 2023 18:42:42 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=gmail.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="BQ95ScqS" Received: by mail-oi1-f172.google.com with SMTP id 5614622812f47-3b2ea7cc821so3369537b6e.1 for ; Mon, 30 Oct 2023 11:42:42 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1698691361; x=1699296161; darn=lists.linux.dev; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:from:to:cc:subject:date:message-id:reply-to; bh=IqH2MDi7AS7ELU7awEeKmSV+na9z+gufigYPz4kD/JA=; b=BQ95ScqSpnH1vhryHWo/EafRfOBQJPNXZpNDL3/i/NowYh39scwA3kruz4tk5kp9xq ydysP0SwNnX+wk/zzgs03wpnp06iZr32yEhMryjMzLPbJlk9BK3kMCSdhaS/L1SVdGxS LzoZp9Fe3juUtk7nH9OARsL2ik4JfnlPm3rpq9NnIH1Tb/o5f8xy0GmDjrK2+M4AslFT 398w1B5+wfaTvXtEfDqM5ejJa1irXAyd4Bd0tAJY6LRFHyYQeMVZA+VVrV97krh7ndOK JhxAeDeK7eb++bQ39GXdq04RCr7ao5xeJxMitjwjE4OzTTgP49MEK/ag66nijNy9+MDh Z9EQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1698691361; x=1699296161; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to; bh=IqH2MDi7AS7ELU7awEeKmSV+na9z+gufigYPz4kD/JA=; b=Iee9XF0mPWVODOx9dVxd/RJpcEDDKL3uGomw0alLrqpwBviFo4NLWdBsPrBtBaw1fm 4cPOyVY6mXD8JohzUIk/uP/QaFWwGpm/YnN3dS2WhhpUMaFdxY6SSHSmUXdPk74mu7S3 eXHD8vC591r0CBHHe9dBkBYDYonsFDYcSJd8DIihZXe1c0kt9/V3upq+LEEB6GBG/g4b 7T7IrhNCHqnyXmBPlErBY4k99dCVaLQQT2t1es23cmxzc6Pd7pmOhEmGyH9dU29sBlk5 j4vgtu2ZK4Ax8XMzZaO5QlyyFLqXS6PE9FiV+6D/l7UiI03arCSOjcJgyak3r9cWbMkQ vb1g== X-Gm-Message-State: AOJu0YznVlGM5ipSCljekd5XitNN6Dh/aCfo59UDcHlddxGFLZ54+hHQ Mgux1JMsYauexbl4YJr0V8Q= X-Google-Smtp-Source: AGHT+IHIWUOtyavBIkY9CuNaKTneVZ9xeme/ndVJ216kK7foJS/nyOc35SqVApiTEFpV1cN5621OWg== X-Received: by 2002:a05:6871:7505:b0:1e9:fd9b:735 with SMTP id ny5-20020a056871750500b001e9fd9b0735mr12630857oac.56.1698691361396; Mon, 30 Oct 2023 11:42:41 -0700 (PDT) Received: from localhost (modemcable065.128-200-24.mc.videotron.ca. [24.200.128.65]) by smtp.gmail.com with ESMTPSA id r21-20020ac85215000000b00417fa0cd77esm3638949qtn.80.2023.10.30.11.42.40 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 30 Oct 2023 11:42:41 -0700 (PDT) Date: Mon, 30 Oct 2023 14:42:40 -0400 From: Benjamin Poirier To: Greg Kroah-Hartman , Jakub Kicinski Cc: Kira , "David S. Miller" , Eric Dumazet , Paolo Abeni , Jonathan Corbet , Manish Chopra , GR-Linux-NIC-Dev@marvell.com, Coiby Xu , "James E.J. Bottomley" , Helge Deller , Sven Joachim , Ian Kent , netdev@vger.kernel.org, linux-doc@vger.kernel.org, linux-kernel@vger.kernel.org, linux-parisc@vger.kernel.org, linux-staging@lists.linux.dev Subject: Re: [PATCH] staging: Revert "staging: qlge: Retire the driver" Message-ID: References: <20231030150400.74178-1-benjamin.poirier@gmail.com> <2023103001-drew-parmesan-c61a@gregkh> Precedence: bulk X-Mailing-List: linux-staging@lists.linux.dev List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: On 2023-10-30 12:33 -0400, Benjamin Poirier wrote: > On 2023-10-30 16:25 +0100, Greg Kroah-Hartman wrote: > > On Tue, Oct 31, 2023 at 02:04:00AM +1100, Benjamin Poirier wrote: > > > This reverts commit 875be090928d19ff4ae7cbaadb54707abb3befdf. > > > > > > On All Hallows' Eve, fear and cower for it is the return of the undead > > > driver. > > > > > > There was a report [1] from a user of a QLE8142 device. They would like for > > > the driver to remain in the kernel. Therefore, revert the removal of the > > > qlge driver. > > > > > > [1] https://lore.kernel.org/netdev/566c0155-4f80-43ec-be2c-2d1ad631bf25@gmail.com/ > > > > Who's going to maintain this? > > I was planning to update the MAINTAINERS entry to > S: Orphan > when moving it back to drivers/net/. Would you prefer that I do that > change in a second patch right after the revert in staging? That would > certainly make things clearer. > > > > Reported by: Kira > > > Signed-off-by: Benjamin Poirier > > > --- > > > > > > Notes: > > > Once the removal and revert show up in the net-next tree, I plan to send a > > > followup patch to move the driver to drivers/net/ as discussed earlier: > > > https://lore.kernel.org/netdev/20231019074237.7ef255d7@kernel.org/ > > > > are you going to be willing to maintain this and keep it alive? > > No. > > > I'm all this, if you want to, but I would like it out of staging. So > > I'd like it out of staging as well. Since nobody wants to maintain it, I > think it should be deleted. However, my understanding is that Jakub is > willing to take it back into drivers/net/ as-is given that there is at > least one user. Jakub, did I understand that correctly? > > > how about applying this, and a follow-on one that moves it there once > > -rc1 is out? And it probably should be in the 'net' tree, as you don't > > want 6.7 to come out without the driver at all, right? > > Right about making sure 6.7 includes the driver. The 'net' tree is > usually for fixes hence why I would send to net-next. So the driver > would still be in staging for 6.7 (if you include the revert in your > 6.7-rc1 submission) and would be back in drivers/net/ for 6.8. Rereading, I think I misunderstood your suggestion. You're suggesting that I submit the revert through the net tree rather than the staging tree. That sounds good. I'll do that once the removal shows up there.