Re: [PATCH 1/4] staging: pi433: Remove a duplicated F_OSC define

Andy Shevchenko
2024-02-26T14:45:37Z

On Sun, Feb 25, 2024 at 07:33:38PM +0200, Shahar Avidar wrote:
> F_OSC is already defined & only used by rf69.c source file
> Also fix define comment

You missed periods at the end of the sentences.

...

> -#define F_OSC 32000000 /* in Hz */
> +#define F_OSC 32000000 /* Hz */

Instead of having a comment you can

#include <linux/units.h>
...
#define F_OSC (32 * HZ_PER_MHZ)

which will be more robust code (no need to count 0s).

--
With Best Regards,
Andy Shevchenko