Re: [PATCH 1/4] staging: pi433: Remove a duplicated F_OSC define

Shahar Avidar
2024-02-27T22:17:36Z

On 26/02/2024 16:45, Andy Shevchenko wrote:
> On Sun, Feb 25, 2024 at 07:33:38PM +0200, Shahar Avidar wrote:
>> F_OSC is already defined & only used by rf69.c source file
>> Also fix define comment
>
> You missed periods at the end of the sentences.

Thank you for noticing.

>> -#define F_OSC 32000000 /* in Hz */
>> +#define F_OSC 32000000 /* Hz */
>
> Instead of having a comment you can
>
> #include <linux/units.h>
> ...
> #define F_OSC (32 * HZ_PER_MHZ)
>
> which will be more robust code (no need to count 0s).
>

All comments are fixed in v2 which was just sent.
Please note I sent the updated patchset twice, I forgot to add v2 the
first time...

--
Regards,

Shahar