From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mgamail.intel.com (mgamail.intel.com [192.198.163.14]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 37EED58119; Mon, 11 Mar 2024 22:46:38 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=192.198.163.14 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1710197200; cv=none; b=ca0Y27K3mBT8IzUdeqYFO8XsIc8j9ZIyV2ntDScNTpcbrtZl+qOhNIqIIoVqOe5p/IVWSdB8h2AQIg8ac80RaWtph7nZNHRqIkRAHkRj7iOo+QnQdw5+KJe8t5T2qMALubp0/q1MYznBH93yHyyZDnyp9mf1tTCtR5woZA8Lo58= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1710197200; c=relaxed/simple; bh=ZJAAeL3fVss9iGjRrFB3dUfBTrjy5/IGazLgsApqp4Q=; h=Date:From:To:Cc:Subject:Message-ID:References:MIME-Version: Content-Type:Content-Disposition:In-Reply-To; b=lgQ3JTZdryU9wSg2hlPmMDxH8Yce9Mx5HjyD28sF4rzip1wFPN0RYhIkH7d4bzOKkaKidvHHNq9DpgLCqLLFt6VBxhbrep0EwqiG2t0Yt/aR5Ko6uoBlrhQSydVwiT3nC+Fvpha2giCuSylSC7b9zhhgx08yTMkHWAjUdvDrwck= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=intel.com; spf=pass smtp.mailfrom=intel.com; dkim=pass (2048-bit key) header.d=intel.com header.i=@intel.com header.b=FQbd+xEN; arc=none smtp.client-ip=192.198.163.14 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=intel.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=intel.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=intel.com header.i=@intel.com header.b="FQbd+xEN" DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=intel.com; i=@intel.com; q=dns/txt; s=Intel; t=1710197199; x=1741733199; h=date:from:to:cc:subject:message-id:references: mime-version:in-reply-to; bh=ZJAAeL3fVss9iGjRrFB3dUfBTrjy5/IGazLgsApqp4Q=; b=FQbd+xENy+oxZbeIYdwrnN/sUNl+x577ZUtEZnv+Ln5Xd1yHsIPdtKVx woOe+J4ZiomnEiyEIC8Z+rwEVq4/MMxtTdZqaMnvUJyAxobjXSlv/FVwx 5xibQEZKywY2hP0u29YfVO05LpmgBwcDSCW/msTgNHxEt0MzUoELaaLHv ngXJxdu9esdJcCniR8ubM8Q+18VyDBa1vXOAqeqsRgg6hVwCCSNH4OxlH +Mj1CEa7QDBdCVRCeqiOHLguyJsxqKk+wMdHHg7OEqx/6uEdAOa5fK/Fz JB5apdjfRcSEgRtoBWH9qf4cO09ZPbtfLt/RZcMYqtvfa76biLxaNrqq9 Q==; X-IronPort-AV: E=McAfee;i="6600,9927,11010"; a="5069991" X-IronPort-AV: E=Sophos;i="6.07,117,1708416000"; d="scan'208";a="5069991" Received: from fmviesa005.fm.intel.com ([10.60.135.145]) by fmvoesa108.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 11 Mar 2024 15:46:32 -0700 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="6.07,117,1708416000"; d="scan'208";a="15811648" Received: from aschofie-mobl2.amr.corp.intel.com (HELO aschofie-mobl2) ([10.212.137.71]) by fmviesa005-auth.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 11 Mar 2024 15:46:31 -0700 Date: Mon, 11 Mar 2024 15:46:29 -0700 From: Alison Schofield To: "Felix N. Kimbu" Cc: Greg Kroah-Hartman , linux-staging@lists.linux.dev, linux-kernel@vger.kernel.org, outreachy@lists.linux.dev Subject: Re: [PATCH] staging: p80211conv: Rename local foo to decrypt_check Message-ID: References: Precedence: bulk X-Mailing-List: linux-staging@lists.linux.dev List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: On Mon, Mar 11, 2024 at 07:07:55PM +0100, Felix N. Kimbu wrote: > This change renames the local variable foo to decrypt_check in functions > skb_ether_to_p80211(...) and skb_p80211_to_ether(...), giving intuitive > meaning to the identifier. 'rc' is typically used for cases like this. If the name of the function being called is reasonably intuitive, then 'rc' suffices for the return value. > > It also indents the parameters to match the the opening parentheses. 'Also' signals that this patch is trying to do more than one thing. One type of 'thing' per patch please. The commit message prefixes are off. Please see First Patch Tutorial Section: "Following the Driver commit style" Patch fails checkpatch. Please see First Patch Tutorial Sections: "Git post-commit hooks" and "Understand patch best practices" --snip