From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mgamail.intel.com (mgamail.intel.com [192.198.163.11]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 468917E1; Thu, 14 Mar 2024 02:32:22 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=192.198.163.11 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1710383546; cv=none; b=I+clkCtwweOy4D/BSO8LA65yFLbQn969S40TIwX/bguPZ4hWq4sNaD9/LI9LgVGVIC2vBIN6Ps6NBmBRNwilUQ8R0/4shl0gIN5VBGoiPg7IieKeO+0m0JqS0cYr7HU9REc4Zhacc6aaZMirRBDb+/QVJO3sq1HYKGQoPx7PDBk= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1710383546; c=relaxed/simple; bh=pe3erww6iGV5Z2CHt+wZW7sosEJYvm2NBU6QR6tsMb0=; h=Date:From:To:Cc:Subject:Message-ID:References:MIME-Version: Content-Type:Content-Disposition:In-Reply-To; b=XCpkf4mzPQzkR54rug9PAKj2IYJ2DKRE3W1adBEAx+5pWOMHlqeyAtJtmVlgBboKdaVT01DjqFQQ/VVONj0nk+MeOujAv95aEVfUit33CkEzz9mlU2cmeMObE37ew3IIKP4J0iB0VC8vttrvNLpiaHGGBEAsycAYfc2PE3afu6E= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=intel.com; spf=pass smtp.mailfrom=intel.com; dkim=pass (2048-bit key) header.d=intel.com header.i=@intel.com header.b=HbljAmu3; arc=none smtp.client-ip=192.198.163.11 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=intel.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=intel.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=intel.com header.i=@intel.com header.b="HbljAmu3" DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=intel.com; i=@intel.com; q=dns/txt; s=Intel; t=1710383543; x=1741919543; h=date:from:to:cc:subject:message-id:references: mime-version:in-reply-to; bh=pe3erww6iGV5Z2CHt+wZW7sosEJYvm2NBU6QR6tsMb0=; b=HbljAmu3wQ2HM+MI9ad453a6LkPoIKj42nMdOR2rhm/LsrY3vLHhUGhB 4WQFoD1HeuEXdUsF2o0kbHjn7K81aZucLqhBGVdTQTSugjXartrvhABxU efS9cyn0rYRIY+h1MUOu0VTK/DA750u0p6qF2+MK7QY8xTEZRKXsLpUBP PmJpIxTEwPBzD5VhSDFXGz4t+QQed/RpCK7CZgwfMP5G1HPX1QR+RudJj QWZE3Mq5egIIXkuKCqBwYwnaRTSbk5kf2QURPJKh2PMlZ7EPKT6EWtWLM f4Rs360FT5Q1FqwlEFqmzJxSutD+CKwFfjqMrzzz/4DSrYMYoirUHEjjw w==; X-IronPort-AV: E=McAfee;i="6600,9927,11012"; a="15826130" X-IronPort-AV: E=Sophos;i="6.07,124,1708416000"; d="scan'208";a="15826130" Received: from orviesa006.jf.intel.com ([10.64.159.146]) by fmvoesa105.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 13 Mar 2024 19:32:22 -0700 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="6.07,124,1708416000"; d="scan'208";a="12545220" Received: from aschofie-mobl2.amr.corp.intel.com (HELO aschofie-mobl2) ([10.209.86.131]) by orviesa006-auth.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 13 Mar 2024 19:32:22 -0700 Date: Wed, 13 Mar 2024 19:32:20 -0700 From: Alison Schofield To: Ayush Tiwari Cc: Larry.Finger@lwfinger.net, florian.c.schilhabel@googlemail.com, gregkh@linuxfoundation.org, linux-kernel@vger.kernel.org, linux-staging@lists.linux.dev, outreachy@lists.linux.dev Subject: Re: [PATCH] staging: greybus: add comment for mutex Message-ID: References: Precedence: bulk X-Mailing-List: linux-staging@lists.linux.dev List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: On Wed, Mar 13, 2024 at 11:51:22PM +0530, Ayush Tiwari wrote: > This patch adds descriptive comment to mutex within the struct > gbaudio_codec_info to clarify its intended use and to address > checkpatch checks. Hi Ayush- You may be right, but you need to convince your patch reviewers why your comment accurately describes this mutex. That's always the ask with this kind of patch. BTW - Don't start your commit log with 'This patch...'. Alison > > Signed-off-by: Ayush Tiwari > --- > drivers/staging/greybus/audio_codec.h | 1 + > 1 file changed, 1 insertion(+) > > diff --git a/drivers/staging/greybus/audio_codec.h b/drivers/staging/greybus/audio_codec.h > index f3f7a7ec6be4..1f97d4fb16cd 100644 > --- a/drivers/staging/greybus/audio_codec.h > +++ b/drivers/staging/greybus/audio_codec.h > @@ -71,6 +71,7 @@ struct gbaudio_codec_info { > /* to maintain runtime stream params for each DAI */ > struct list_head dai_list; > struct mutex lock; > + /* Lock to protect register access */ > struct mutex register_mutex; > }; > > -- > 2.40.1 > >