Re: [PATCH 0/3] staging: pi433: Fix includes & macros.

Greg KH
2024-03-26T06:01:20Z

On Mon, Mar 25, 2024 at 09:12:16PM +0200, Andy Shevchenko wrote:
> On Mon, Mar 25, 2024 at 07:51:16PM +0100, Greg KH wrote:
> > On Mon, Mar 25, 2024 at 08:41:50PM +0200, Andy Shevchenko wrote:
> > > On Mon, Mar 25, 2024 at 07:05:46PM +0100, Greg KH wrote:
> > > > On Mon, Mar 25, 2024 at 11:18:42AM +0200, Andy Shevchenko wrote:
> > > > > On Sun, Mar 24, 2024 at 11:31:58AM +0200, Shahar Avidar wrote:
> > > > > > 1. Untangle include hierarchy.
> > > > > > 2. Update #minors the driver can accept.
> > > > > > 3. Make use of general macro instead of magic number.
> > > > >
> > > > > > Shahar Avidar (3):
> > > > > > staging: pi433: Use headers in appropriate files.
> > > > > > staging: pi433: Reduce N_PI433_MINORS to conform with N_SPI_MINORS.
> > > > > > staging: pi433: Make use of spi mode macro instead of magic number.
> > > > >
> > > > > For patches 1 and 3
> > > > > Reviewed-by: Andy Shevchenko <andriy.shevchenko@linux.intel.com>
> > > >
> > > > That's impossible for b4 to parse, it would have applied this to all of
> > > > the commits if I had taken them :(
> > >
> > > You can apply only patches 1 and 3 as long as they are independent to patch 2.
> > >
> > > b4 am -st -P 1,3 ...
> >
> > I don't do that, it would not scale at all :)
>
> Yeah, this requires too much maintainer's involvement.
>
> Alternative option, in case you are fine with patch 2, is to drop my tags and
> apply.

I wasn't fine with them, I'll wait for a new version of this series to
be posted before looking at them again.

thanks,

greg k-h