From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mgamail.intel.com (mgamail.intel.com [198.175.65.17]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id E6A0971B4F for ; Mon, 15 Apr 2024 14:53:32 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=198.175.65.17 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1713192814; cv=none; b=Li7AR+yNKJTlhgNAqVbFyhqKv9Q2GFFqOnhJ/c9JEAjYGjvyDwaCKn8wwSXQBd8pv5arAZUjoLmTUM2UMmMFPE5hubE7c+naJjzgfURa5WLUwylMA9CCuGBr8Rmvx6UhVbI63KM2YdfWzr9RtRGTsisF8IO7/WyFbUfaYKBEEWk= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1713192814; c=relaxed/simple; bh=cnpBn7mo+Uj/dwSeexcbPN0wiCaVtBWcgLH0M7WB2b8=; h=Date:From:To:Cc:Subject:Message-ID:References:MIME-Version: Content-Type:Content-Disposition:In-Reply-To; b=TmaqU+ffpXKlu0EvZn988sHD5kLdlweg7yhwM9EA0VK8LF7FoAoNi+5cca8ma+XAZzsEwjx5FE6SU5uInohUloh9QJBs/Tn18NmC1aZ444eYHHeEGG+TYTWPWS8DXFIZwFBM4sxkY7bELmwU2E+bpMn5JTl92i0MvMZI4kP7wXI= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=fail (p=none dis=none) header.from=kernel.org; spf=fail smtp.mailfrom=kernel.org; arc=none smtp.client-ip=198.175.65.17 Authentication-Results: smtp.subspace.kernel.org; dmarc=fail (p=none dis=none) header.from=kernel.org Authentication-Results: smtp.subspace.kernel.org; spf=fail smtp.mailfrom=kernel.org X-CSE-ConnectionGUID: /3VVvcIRSJ+5eslh4dQizg== X-CSE-MsgGUID: 2mMYOtgQTy+NYmnlFBFWwA== X-IronPort-AV: E=McAfee;i="6600,9927,11045"; a="8694690" X-IronPort-AV: E=Sophos;i="6.07,203,1708416000"; d="scan'208";a="8694690" Received: from orviesa008.jf.intel.com ([10.64.159.148]) by orvoesa109.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 15 Apr 2024 07:53:32 -0700 X-CSE-ConnectionGUID: 4CI1hVX5TtaFpkZm1fdI3Q== X-CSE-MsgGUID: 8oG5k8lEQLKsMsgtSnJCCw== X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="6.07,203,1708416000"; d="scan'208";a="22522064" Received: from smile.fi.intel.com ([10.237.72.54]) by orviesa008.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 15 Apr 2024 07:53:30 -0700 Received: from andy by smile.fi.intel.com with local (Exim 4.97) (envelope-from ) id 1rwNi2-00000004RDX-1Pmy; Mon, 15 Apr 2024 17:53:26 +0300 Date: Mon, 15 Apr 2024 17:53:26 +0300 From: Andy Shevchenko To: Hans de Goede Cc: Sakari Ailus , Mauro Carvalho Chehab , Kate Hsuan , Tsuchiya Yuto , Fabio Aiuto , linux-media@vger.kernel.org, linux-staging@lists.linux.dev Subject: Re: [PATCH 14/23] media: atomisp: Drop custom flash support Message-ID: References: <20240415120220.219480-1-hdegoede@redhat.com> <20240415120220.219480-15-hdegoede@redhat.com> Precedence: bulk X-Mailing-List: linux-staging@lists.linux.dev List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: <20240415120220.219480-15-hdegoede@redhat.com> Organization: Intel Finland Oy - BIC 0357606-4 - Westendinkatu 7, 02160 Espoo On Mon, Apr 15, 2024 at 02:02:11PM +0200, Hans de Goede wrote: > Remove the custom flash handling from the atomisp driver. There are only > very few Bay Trail / Cherry Trail devices with flash and if those will "only very few" sounds to me as an oxymoron. "only few" or "very few" — I believe you meant the former. > ever get supported then this should be done through the new standard > include/linux/led-class-flash.h APIs instead of with atomisp specific > custom APIs. -- With Best Regards, Andy Shevchenko