From: philipp hortmann <philipp.g.hortmann@gmail.com>
To: Tree Davies <tdavies@darkphysics.net>
Cc: gregkh@linuxfoundation.org, anjan@momi.ca,
linux-staging@lists.linux.dev, linux-kernel@vger.kernel.org
Subject: Re: [PATCH 01/18] Staging: rtl8192e: Rename variable nDataRate
Date: Tue, 17 Sep 2024 21:32:10 +0200 [thread overview]
Message-ID: <ZunZOjL0E3bU7Oht@kernel-710> (raw)
In-Reply-To: <20240917053152.575553-2-tdavies@darkphysics.net>
On Mon, Sep 16, 2024 at 10:31:35PM -0700, Tree Davies wrote:
> Rename variable nDataRate to data_rate
> to fix checkpatch warning Avoid CamelCase.
>
> Signed-off-by: Tree Davies <tdavies@darkphysics.net>
> ---
> drivers/staging/rtl8192e/rtllib.h | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/staging/rtl8192e/rtllib.h b/drivers/staging/rtl8192e/rtllib.h
> index d6615f787d53..21d8ea153368 100644
> --- a/drivers/staging/rtl8192e/rtllib.h
> +++ b/drivers/staging/rtl8192e/rtllib.h
> @@ -1743,7 +1743,7 @@ extern u16 MCS_DATA_RATE[2][2][77];
> u8 ht_c_check(struct rtllib_device *ieee, u8 *frame);
> void ht_reset_iot_setting(struct rt_hi_throughput *ht_info);
> bool is_ht_half_nmode_aps(struct rtllib_device *ieee);
> -u16 tx_count_to_data_rate(struct rtllib_device *ieee, u8 nDataRate);
> +u16 tx_count_to_data_rate(struct rtllib_device *ieee, u8 data_rate);
> int rtllib_rx_add_ba_req(struct rtllib_device *ieee, struct sk_buff *skb);
> int rtllib_rx_add_ba_rsp(struct rtllib_device *ieee, struct sk_buff *skb);
> int rtllib_rx_DELBA(struct rtllib_device *ieee, struct sk_buff *skb);
> --
> 2.30.2
>
Hi Tree,
we also need to change the following line:
u16 tx_count_to_data_rate(struct rtllib_device *ieee, u8 nDataRate);
Thanks for your support.
Bye Philipp
next prev parent reply other threads:[~2024-09-17 19:32 UTC|newest]
Thread overview: 25+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-09-17 5:31 [PATCH 00/18] Staging: rtl8192e: 18 more Style guide variable renames Tree Davies
2024-09-17 5:31 ` [PATCH 01/18] Staging: rtl8192e: Rename variable nDataRate Tree Davies
2024-09-17 19:32 ` philipp hortmann [this message]
2024-09-17 20:00 ` philipp hortmann
2024-09-18 10:35 ` Dan Carpenter
2024-09-17 5:31 ` [PATCH 02/18] Staging: rtl8192e: Rename variable bIsCCK Tree Davies
2024-09-17 5:31 ` [PATCH 03/18] Staging: rtl8192e: Rename variable bCRC Tree Davies
2024-09-17 5:31 ` [PATCH 04/18] Staging: rtl8192e: Rename variable pMCSRateSet Tree Davies
2024-09-17 5:31 ` [PATCH 05/18] Staging: rtl8192e: Rename variable PreCommonCmd Tree Davies
2024-09-17 5:31 ` [PATCH 06/18] Staging: rtl8192e: Rename variable PostCommonCmd Tree Davies
2024-09-17 5:31 ` [PATCH 07/18] Staging: rtl8192e: Rename variable RxDataNum Tree Davies
2024-09-17 5:31 ` [PATCH 08/18] Staging: rtl8192e: Rename variable FwRWRF Tree Davies
2024-09-17 5:31 ` [PATCH 09/18] Staging: rtl8192e: Rename variable bFirstMPDU Tree Davies
2024-09-17 5:31 ` [PATCH 10/18] Staging: rtl8192e: Rename variable bPacketBeacon Tree Davies
2024-09-17 5:31 ` [PATCH 11/18] Staging: rtl8192e: Rename variable Rx_TS_Pending_List Tree Davies
2024-09-17 5:31 ` [PATCH 12/18] Staging: rtl8192e: Rename variable bPacketMatchBSSID Tree Davies
2024-09-17 5:31 ` [PATCH 13/18] Staging: rtl8192e: Rename variable bToSelfBA Tree Davies
2024-09-17 5:31 ` [PATCH 14/18] Staging: rtl8192e: Rename variable Tx_TS_Admit_List Tree Davies
2024-09-17 5:31 ` [PATCH 15/18] Staging: rtl8192e: Rename variable Tx_TS_Pending_List Tree Davies
2024-09-17 5:31 ` [PATCH 16/18] Staging: rtl8192e: Rename variable Tx_TS_Unused_List Tree Davies
2024-09-17 5:31 ` [PATCH 17/18] Staging: rtl8192e: Rename variable Sbox Tree Davies
2024-09-17 5:31 ` [PATCH 18/18] Staging: rtl8192e: Rename variable pMCSFilter Tree Davies
2024-09-17 20:05 ` [PATCH 00/18] Staging: rtl8192e: 18 more Style guide variable renames philipp hortmann
2024-10-09 9:53 ` Greg KH
[not found] ` <e0cdfdd3-eebb-40c5-a845-fbc5e52364d5@darkphysics.net>
2024-10-11 3:21 ` Greg KH
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=ZunZOjL0E3bU7Oht@kernel-710 \
--to=philipp.g.hortmann@gmail.com \
--cc=anjan@momi.ca \
--cc=gregkh@linuxfoundation.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-staging@lists.linux.dev \
--cc=tdavies@darkphysics.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox