* [PATCH 01/18] Staging: rtl8192e: Rename variable nDataRate
2024-09-17 5:31 [PATCH 00/18] Staging: rtl8192e: 18 more Style guide variable renames Tree Davies
@ 2024-09-17 5:31 ` Tree Davies
2024-09-17 19:32 ` philipp hortmann
2024-09-17 20:00 ` philipp hortmann
2024-09-17 5:31 ` [PATCH 02/18] Staging: rtl8192e: Rename variable bIsCCK Tree Davies
` (18 subsequent siblings)
19 siblings, 2 replies; 25+ messages in thread
From: Tree Davies @ 2024-09-17 5:31 UTC (permalink / raw)
To: gregkh, philipp.g.hortmann, anjan
Cc: linux-staging, linux-kernel, Tree Davies
Rename variable nDataRate to data_rate
to fix checkpatch warning Avoid CamelCase.
Signed-off-by: Tree Davies <tdavies@darkphysics.net>
---
drivers/staging/rtl8192e/rtllib.h | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/staging/rtl8192e/rtllib.h b/drivers/staging/rtl8192e/rtllib.h
index d6615f787d53..21d8ea153368 100644
--- a/drivers/staging/rtl8192e/rtllib.h
+++ b/drivers/staging/rtl8192e/rtllib.h
@@ -1743,7 +1743,7 @@ extern u16 MCS_DATA_RATE[2][2][77];
u8 ht_c_check(struct rtllib_device *ieee, u8 *frame);
void ht_reset_iot_setting(struct rt_hi_throughput *ht_info);
bool is_ht_half_nmode_aps(struct rtllib_device *ieee);
-u16 tx_count_to_data_rate(struct rtllib_device *ieee, u8 nDataRate);
+u16 tx_count_to_data_rate(struct rtllib_device *ieee, u8 data_rate);
int rtllib_rx_add_ba_req(struct rtllib_device *ieee, struct sk_buff *skb);
int rtllib_rx_add_ba_rsp(struct rtllib_device *ieee, struct sk_buff *skb);
int rtllib_rx_DELBA(struct rtllib_device *ieee, struct sk_buff *skb);
--
2.30.2
^ permalink raw reply related [flat|nested] 25+ messages in thread* Re: [PATCH 01/18] Staging: rtl8192e: Rename variable nDataRate
2024-09-17 5:31 ` [PATCH 01/18] Staging: rtl8192e: Rename variable nDataRate Tree Davies
@ 2024-09-17 19:32 ` philipp hortmann
2024-09-17 20:00 ` philipp hortmann
1 sibling, 0 replies; 25+ messages in thread
From: philipp hortmann @ 2024-09-17 19:32 UTC (permalink / raw)
To: Tree Davies; +Cc: gregkh, anjan, linux-staging, linux-kernel
On Mon, Sep 16, 2024 at 10:31:35PM -0700, Tree Davies wrote:
> Rename variable nDataRate to data_rate
> to fix checkpatch warning Avoid CamelCase.
>
> Signed-off-by: Tree Davies <tdavies@darkphysics.net>
> ---
> drivers/staging/rtl8192e/rtllib.h | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/staging/rtl8192e/rtllib.h b/drivers/staging/rtl8192e/rtllib.h
> index d6615f787d53..21d8ea153368 100644
> --- a/drivers/staging/rtl8192e/rtllib.h
> +++ b/drivers/staging/rtl8192e/rtllib.h
> @@ -1743,7 +1743,7 @@ extern u16 MCS_DATA_RATE[2][2][77];
> u8 ht_c_check(struct rtllib_device *ieee, u8 *frame);
> void ht_reset_iot_setting(struct rt_hi_throughput *ht_info);
> bool is_ht_half_nmode_aps(struct rtllib_device *ieee);
> -u16 tx_count_to_data_rate(struct rtllib_device *ieee, u8 nDataRate);
> +u16 tx_count_to_data_rate(struct rtllib_device *ieee, u8 data_rate);
> int rtllib_rx_add_ba_req(struct rtllib_device *ieee, struct sk_buff *skb);
> int rtllib_rx_add_ba_rsp(struct rtllib_device *ieee, struct sk_buff *skb);
> int rtllib_rx_DELBA(struct rtllib_device *ieee, struct sk_buff *skb);
> --
> 2.30.2
>
Hi Tree,
we also need to change the following line:
u16 tx_count_to_data_rate(struct rtllib_device *ieee, u8 nDataRate);
Thanks for your support.
Bye Philipp
^ permalink raw reply [flat|nested] 25+ messages in thread
* Re: [PATCH 01/18] Staging: rtl8192e: Rename variable nDataRate
2024-09-17 5:31 ` [PATCH 01/18] Staging: rtl8192e: Rename variable nDataRate Tree Davies
2024-09-17 19:32 ` philipp hortmann
@ 2024-09-17 20:00 ` philipp hortmann
2024-09-18 10:35 ` Dan Carpenter
1 sibling, 1 reply; 25+ messages in thread
From: philipp hortmann @ 2024-09-17 20:00 UTC (permalink / raw)
To: Tree Davies; +Cc: gregkh, anjan, linux-staging, linux-kernel
On Mon, Sep 16, 2024 at 10:31:35PM -0700, Tree Davies wrote:
> Rename variable nDataRate to data_rate
> to fix checkpatch warning Avoid CamelCase.
>
> Signed-off-by: Tree Davies <tdavies@darkphysics.net>
> ---
> drivers/staging/rtl8192e/rtllib.h | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/staging/rtl8192e/rtllib.h b/drivers/staging/rtl8192e/rtllib.h
> index d6615f787d53..21d8ea153368 100644
> --- a/drivers/staging/rtl8192e/rtllib.h
> +++ b/drivers/staging/rtl8192e/rtllib.h
> @@ -1743,7 +1743,7 @@ extern u16 MCS_DATA_RATE[2][2][77];
> u8 ht_c_check(struct rtllib_device *ieee, u8 *frame);
> void ht_reset_iot_setting(struct rt_hi_throughput *ht_info);
> bool is_ht_half_nmode_aps(struct rtllib_device *ieee);
> -u16 tx_count_to_data_rate(struct rtllib_device *ieee, u8 nDataRate);
> +u16 tx_count_to_data_rate(struct rtllib_device *ieee, u8 data_rate);
> int rtllib_rx_add_ba_req(struct rtllib_device *ieee, struct sk_buff *skb);
> int rtllib_rx_add_ba_rsp(struct rtllib_device *ieee, struct sk_buff *skb);
> int rtllib_rx_DELBA(struct rtllib_device *ieee, struct sk_buff *skb);
> --
> 2.30.2
>
Hi Tree,
forget the former email.
so in this commit:
commit ad96610acc0eb81f0342fa688e6d42fd530c328b
Author: Gary Rookard <garyrookard@fastmail.org>
Date: Tue Nov 28 13:17:27 2023 -0500
the variable was changed. But he missed to change the declaration of the function tx_count_to_data_rate().
So you change the variable accordingly in the declaration of the functiont tx_count_to_data_rate()
I assume that Greg would want you to use a fixes tag.
Thanks.
Bye Philipp
^ permalink raw reply [flat|nested] 25+ messages in thread
* Re: [PATCH 01/18] Staging: rtl8192e: Rename variable nDataRate
2024-09-17 20:00 ` philipp hortmann
@ 2024-09-18 10:35 ` Dan Carpenter
0 siblings, 0 replies; 25+ messages in thread
From: Dan Carpenter @ 2024-09-18 10:35 UTC (permalink / raw)
To: philipp hortmann; +Cc: Tree Davies, gregkh, anjan, linux-staging, linux-kernel
On Tue, Sep 17, 2024 at 10:00:01PM +0200, philipp hortmann wrote:
> On Mon, Sep 16, 2024 at 10:31:35PM -0700, Tree Davies wrote:
> > Rename variable nDataRate to data_rate
> > to fix checkpatch warning Avoid CamelCase.
> >
> > Signed-off-by: Tree Davies <tdavies@darkphysics.net>
> > ---
> > drivers/staging/rtl8192e/rtllib.h | 2 +-
> > 1 file changed, 1 insertion(+), 1 deletion(-)
> >
> > diff --git a/drivers/staging/rtl8192e/rtllib.h b/drivers/staging/rtl8192e/rtllib.h
> > index d6615f787d53..21d8ea153368 100644
> > --- a/drivers/staging/rtl8192e/rtllib.h
> > +++ b/drivers/staging/rtl8192e/rtllib.h
> > @@ -1743,7 +1743,7 @@ extern u16 MCS_DATA_RATE[2][2][77];
> > u8 ht_c_check(struct rtllib_device *ieee, u8 *frame);
> > void ht_reset_iot_setting(struct rt_hi_throughput *ht_info);
> > bool is_ht_half_nmode_aps(struct rtllib_device *ieee);
> > -u16 tx_count_to_data_rate(struct rtllib_device *ieee, u8 nDataRate);
> > +u16 tx_count_to_data_rate(struct rtllib_device *ieee, u8 data_rate);
> > int rtllib_rx_add_ba_req(struct rtllib_device *ieee, struct sk_buff *skb);
> > int rtllib_rx_add_ba_rsp(struct rtllib_device *ieee, struct sk_buff *skb);
> > int rtllib_rx_DELBA(struct rtllib_device *ieee, struct sk_buff *skb);
> > --
> > 2.30.2
> >
> Hi Tree,
>
> forget the former email.
>
> so in this commit:
> commit ad96610acc0eb81f0342fa688e6d42fd530c328b
> Author: Gary Rookard <garyrookard@fastmail.org>
> Date: Tue Nov 28 13:17:27 2023 -0500
> the variable was changed. But he missed to change the declaration of the function tx_count_to_data_rate().
>
> So you change the variable accordingly in the declaration of the functiont tx_count_to_data_rate()
>
> I assume that Greg would want you to use a fixes tag.
>
No, no need to a Fixes tag for this sort of thing.
regards,
dan carpenter
^ permalink raw reply [flat|nested] 25+ messages in thread
* [PATCH 02/18] Staging: rtl8192e: Rename variable bIsCCK
2024-09-17 5:31 [PATCH 00/18] Staging: rtl8192e: 18 more Style guide variable renames Tree Davies
2024-09-17 5:31 ` [PATCH 01/18] Staging: rtl8192e: Rename variable nDataRate Tree Davies
@ 2024-09-17 5:31 ` Tree Davies
2024-09-17 5:31 ` [PATCH 03/18] Staging: rtl8192e: Rename variable bCRC Tree Davies
` (17 subsequent siblings)
19 siblings, 0 replies; 25+ messages in thread
From: Tree Davies @ 2024-09-17 5:31 UTC (permalink / raw)
To: gregkh, philipp.g.hortmann, anjan
Cc: linux-staging, linux-kernel, Tree Davies
Rename variable bIsCCK to is_cck
to fix checkpatch warning Avoid CamelCase.
Signed-off-by: Tree Davies <tdavies@darkphysics.net>
---
drivers/staging/rtl8192e/rtl8192e/r8192E_dev.c | 4 ++--
drivers/staging/rtl8192e/rtllib.h | 2 +-
2 files changed, 3 insertions(+), 3 deletions(-)
diff --git a/drivers/staging/rtl8192e/rtl8192e/r8192E_dev.c b/drivers/staging/rtl8192e/rtl8192e/r8192E_dev.c
index 2672b1ddf88e..2000289720b3 100644
--- a/drivers/staging/rtl8192e/rtl8192e/r8192E_dev.c
+++ b/drivers/staging/rtl8192e/rtl8192e/r8192E_dev.c
@@ -1173,7 +1173,7 @@ static void _rtl92e_query_rxphystatus(struct r8192_priv *priv,
pstats->bPacketMatchBSSID = precord_stats->bPacketMatchBSSID =
bpacket_match_bssid;
pstats->packet_to_self = precord_stats->packet_to_self = bpacket_toself;
- pstats->bIsCCK = precord_stats->bIsCCK = is_cck_rate;
+ pstats->is_cck = precord_stats->is_cck = is_cck_rate;
pstats->bPacketBeacon = precord_stats->bPacketBeacon = bPacketBeacon;
pstats->bToSelfBA = precord_stats->bToSelfBA = bToSelfBA;
if (check_reg824 == 0) {
@@ -1370,7 +1370,7 @@ static void _rtl92e_process_phyinfo(struct r8192_priv *priv, u8 *buffer,
if (!bcheck)
return;
- if (!prev_st->bIsCCK && prev_st->packet_to_self) {
+ if (!prev_st->is_cck && prev_st->packet_to_self) {
for (rfpath = RF90_PATH_A; rfpath < priv->num_total_rf_path; rfpath++) {
if (priv->stats.rx_rssi_percentage[rfpath] == 0) {
priv->stats.rx_rssi_percentage[rfpath] =
diff --git a/drivers/staging/rtl8192e/rtllib.h b/drivers/staging/rtl8192e/rtllib.h
index 21d8ea153368..08eaa98c0a1a 100644
--- a/drivers/staging/rtl8192e/rtllib.h
+++ b/drivers/staging/rtl8192e/rtllib.h
@@ -483,7 +483,7 @@ struct rtllib_rx_stats {
u8 RxMIMOSignalStrength[2];
s8 RxMIMOSignalQuality[2];
bool bPacketMatchBSSID;
- bool bIsCCK;
+ bool is_cck;
bool packet_to_self;
bool bPacketBeacon;
bool bToSelfBA;
--
2.30.2
^ permalink raw reply related [flat|nested] 25+ messages in thread* [PATCH 03/18] Staging: rtl8192e: Rename variable bCRC
2024-09-17 5:31 [PATCH 00/18] Staging: rtl8192e: 18 more Style guide variable renames Tree Davies
2024-09-17 5:31 ` [PATCH 01/18] Staging: rtl8192e: Rename variable nDataRate Tree Davies
2024-09-17 5:31 ` [PATCH 02/18] Staging: rtl8192e: Rename variable bIsCCK Tree Davies
@ 2024-09-17 5:31 ` Tree Davies
2024-09-17 5:31 ` [PATCH 04/18] Staging: rtl8192e: Rename variable pMCSRateSet Tree Davies
` (16 subsequent siblings)
19 siblings, 0 replies; 25+ messages in thread
From: Tree Davies @ 2024-09-17 5:31 UTC (permalink / raw)
To: gregkh, philipp.g.hortmann, anjan
Cc: linux-staging, linux-kernel, Tree Davies
Rename variable bCRC to crc
to fix checkpatch warning Avoid CamelCase.
Signed-off-by: Tree Davies <tdavies@darkphysics.net>
---
drivers/staging/rtl8192e/rtl8192e/r8192E_dev.c | 6 +++---
drivers/staging/rtl8192e/rtllib.h | 2 +-
2 files changed, 4 insertions(+), 4 deletions(-)
diff --git a/drivers/staging/rtl8192e/rtl8192e/r8192E_dev.c b/drivers/staging/rtl8192e/rtl8192e/r8192E_dev.c
index 2000289720b3..8d645d3296d2 100644
--- a/drivers/staging/rtl8192e/rtl8192e/r8192E_dev.c
+++ b/drivers/staging/rtl8192e/rtl8192e/r8192E_dev.c
@@ -1506,7 +1506,7 @@ static void _rtl92e_translate_rx_signal_stats(struct net_device *dev,
(fc & IEEE80211_FCTL_TODS) ? hdr->addr1 :
(fc & IEEE80211_FCTL_FROMDS) ? hdr->addr2 :
hdr->addr3) &&
- (!pstats->hw_error) && (!pstats->bCRC) && (!pstats->bICV));
+ (!pstats->hw_error) && (!pstats->crc) && (!pstats->bICV));
bpacket_toself = bpacket_match_bssid && /* check this */
ether_addr_equal(praddr, priv->rtllib->dev->dev_addr);
if (ieee80211_is_beacon(hdr->frame_control))
@@ -1525,7 +1525,7 @@ static void _rtl92e_update_received_rate_histogram_stats(struct net_device *dev,
u32 rcvType = 1;
u32 rate_index;
- if (pstats->bCRC)
+ if (pstats->crc)
rcvType = 2;
else if (pstats->bICV)
rcvType = 3;
@@ -1629,7 +1629,7 @@ bool rtl92e_get_rx_stats(struct net_device *dev, struct rtllib_rx_stats *stats,
struct rx_fwinfo *pDrvInfo = NULL;
stats->bICV = pdesc->ICV;
- stats->bCRC = pdesc->CRC32;
+ stats->crc = pdesc->CRC32;
stats->hw_error = pdesc->CRC32 | pdesc->ICV;
stats->Length = pdesc->Length;
diff --git a/drivers/staging/rtl8192e/rtllib.h b/drivers/staging/rtl8192e/rtllib.h
index 08eaa98c0a1a..5bb928d9cd12 100644
--- a/drivers/staging/rtl8192e/rtllib.h
+++ b/drivers/staging/rtl8192e/rtllib.h
@@ -468,7 +468,7 @@ struct rtllib_rx_stats {
s32 RecvSignalPower;
u8 signal_strength;
u16 hw_error:1;
- u16 bCRC:1;
+ u16 crc:1;
u16 bICV:1;
u16 decrypted:1;
u32 time_stamp_low;
--
2.30.2
^ permalink raw reply related [flat|nested] 25+ messages in thread* [PATCH 04/18] Staging: rtl8192e: Rename variable pMCSRateSet
2024-09-17 5:31 [PATCH 00/18] Staging: rtl8192e: 18 more Style guide variable renames Tree Davies
` (2 preceding siblings ...)
2024-09-17 5:31 ` [PATCH 03/18] Staging: rtl8192e: Rename variable bCRC Tree Davies
@ 2024-09-17 5:31 ` Tree Davies
2024-09-17 5:31 ` [PATCH 05/18] Staging: rtl8192e: Rename variable PreCommonCmd Tree Davies
` (15 subsequent siblings)
19 siblings, 0 replies; 25+ messages in thread
From: Tree Davies @ 2024-09-17 5:31 UTC (permalink / raw)
To: gregkh, philipp.g.hortmann, anjan
Cc: linux-staging, linux-kernel, Tree Davies
Rename variable pMCSRateSet to mcs_rate_set
to fix checkpatch warning Avoid CamelCase.
Signed-off-by: Tree Davies <tdavies@darkphysics.net>
---
drivers/staging/rtl8192e/rtl819x_HTProc.c | 8 ++++----
drivers/staging/rtl8192e/rtllib.h | 2 +-
2 files changed, 5 insertions(+), 5 deletions(-)
diff --git a/drivers/staging/rtl8192e/rtl819x_HTProc.c b/drivers/staging/rtl8192e/rtl819x_HTProc.c
index 9c9c0bc0cfde..2eba916d7f50 100644
--- a/drivers/staging/rtl8192e/rtl819x_HTProc.c
+++ b/drivers/staging/rtl8192e/rtl819x_HTProc.c
@@ -357,7 +357,7 @@ static u8 ht_pick_mcs_rate(struct rtllib_device *ieee, u8 *pOperateMCS)
return true;
}
-u8 ht_get_highest_mcs_rate(struct rtllib_device *ieee, u8 *pMCSRateSet,
+u8 ht_get_highest_mcs_rate(struct rtllib_device *ieee, u8 *mcs_rate_set,
u8 *pMCSFilter)
{
u8 i, j;
@@ -365,14 +365,14 @@ u8 ht_get_highest_mcs_rate(struct rtllib_device *ieee, u8 *pMCSRateSet,
u8 mcsRate = 0;
u8 availableMcsRate[16];
- if (!pMCSRateSet || !pMCSFilter) {
+ if (!mcs_rate_set || !pMCSFilter) {
netdev_warn(ieee->dev,
- "%s(): pMCSRateSet and pMCSFilter are null\n",
+ "%s(): mcs_rate_set and pMCSFilter are null\n",
__func__);
return false;
}
for (i = 0; i < 16; i++)
- availableMcsRate[i] = pMCSRateSet[i] & pMCSFilter[i];
+ availableMcsRate[i] = mcs_rate_set[i] & pMCSFilter[i];
for (i = 0; i < 16; i++) {
if (availableMcsRate[i] != 0)
diff --git a/drivers/staging/rtl8192e/rtllib.h b/drivers/staging/rtl8192e/rtllib.h
index 5bb928d9cd12..7c575535d074 100644
--- a/drivers/staging/rtl8192e/rtllib.h
+++ b/drivers/staging/rtl8192e/rtllib.h
@@ -1736,7 +1736,7 @@ void ht_reset_self_and_save_peer_setting(struct rtllib_device *ieee,
struct rtllib_network *network);
void HT_update_self_and_peer_setting(struct rtllib_device *ieee,
struct rtllib_network *network);
-u8 ht_get_highest_mcs_rate(struct rtllib_device *ieee, u8 *pMCSRateSet,
+u8 ht_get_highest_mcs_rate(struct rtllib_device *ieee, u8 *mcs_rate_set,
u8 *pMCSFilter);
extern u8 MCS_FILTER_ALL[];
extern u16 MCS_DATA_RATE[2][2][77];
--
2.30.2
^ permalink raw reply related [flat|nested] 25+ messages in thread* [PATCH 05/18] Staging: rtl8192e: Rename variable PreCommonCmd
2024-09-17 5:31 [PATCH 00/18] Staging: rtl8192e: 18 more Style guide variable renames Tree Davies
` (3 preceding siblings ...)
2024-09-17 5:31 ` [PATCH 04/18] Staging: rtl8192e: Rename variable pMCSRateSet Tree Davies
@ 2024-09-17 5:31 ` Tree Davies
2024-09-17 5:31 ` [PATCH 06/18] Staging: rtl8192e: Rename variable PostCommonCmd Tree Davies
` (14 subsequent siblings)
19 siblings, 0 replies; 25+ messages in thread
From: Tree Davies @ 2024-09-17 5:31 UTC (permalink / raw)
To: gregkh, philipp.g.hortmann, anjan
Cc: linux-staging, linux-kernel, Tree Davies
Rename variable PreCommonCmd to precommon_cmd
to fix checkpatch warning Avoid CamelCase.
Signed-off-by: Tree Davies <tdavies@darkphysics.net>
---
drivers/staging/rtl8192e/rtl8192e/r8192E_phy.c | 6 +++---
drivers/staging/rtl8192e/rtllib.h | 2 +-
2 files changed, 4 insertions(+), 4 deletions(-)
diff --git a/drivers/staging/rtl8192e/rtl8192e/r8192E_phy.c b/drivers/staging/rtl8192e/rtl8192e/r8192E_phy.c
index fbe624e235df..ac9aea228276 100644
--- a/drivers/staging/rtl8192e/rtl8192e/r8192E_phy.c
+++ b/drivers/staging/rtl8192e/rtl8192e/r8192E_phy.c
@@ -550,12 +550,12 @@ static u8 _rtl92e_phy_switch_channel_step(struct net_device *dev, u8 channel,
{
PreCommonCmdCnt = 0;
- _rtl92e_phy_set_sw_chnl_cmd_array(dev, ieee->PreCommonCmd,
+ _rtl92e_phy_set_sw_chnl_cmd_array(dev, ieee->precommon_cmd,
PreCommonCmdCnt++,
MAX_PRECMD_CNT,
cmd_id_set_tx_power_level,
0, 0, 0);
- _rtl92e_phy_set_sw_chnl_cmd_array(dev, ieee->PreCommonCmd,
+ _rtl92e_phy_set_sw_chnl_cmd_array(dev, ieee->precommon_cmd,
PreCommonCmdCnt++,
MAX_PRECMD_CNT, cmd_id_end,
0, 0, 0);
@@ -591,7 +591,7 @@ static u8 _rtl92e_phy_switch_channel_step(struct net_device *dev, u8 channel,
do {
switch (*stage) {
case 0:
- CurrentCmd = &ieee->PreCommonCmd[*step];
+ CurrentCmd = &ieee->precommon_cmd[*step];
break;
case 1:
CurrentCmd = &ieee->RfDependCmd[*step];
diff --git a/drivers/staging/rtl8192e/rtllib.h b/drivers/staging/rtl8192e/rtllib.h
index 7c575535d074..ce36f0979294 100644
--- a/drivers/staging/rtl8192e/rtllib.h
+++ b/drivers/staging/rtl8192e/rtllib.h
@@ -1400,7 +1400,7 @@ struct rtllib_device {
struct rtllib_rxb *stats_IndicateArray[REORDER_WIN_SIZE];
struct rtllib_rxb *prxb_indicate_array[REORDER_WIN_SIZE];
struct {
- struct sw_chnl_cmd PreCommonCmd[MAX_PRECMD_CNT];
+ struct sw_chnl_cmd precommon_cmd[MAX_PRECMD_CNT];
struct sw_chnl_cmd PostCommonCmd[MAX_POSTCMD_CNT];
struct sw_chnl_cmd RfDependCmd[MAX_RFDEPENDCMD_CNT];
};
--
2.30.2
^ permalink raw reply related [flat|nested] 25+ messages in thread* [PATCH 06/18] Staging: rtl8192e: Rename variable PostCommonCmd
2024-09-17 5:31 [PATCH 00/18] Staging: rtl8192e: 18 more Style guide variable renames Tree Davies
` (4 preceding siblings ...)
2024-09-17 5:31 ` [PATCH 05/18] Staging: rtl8192e: Rename variable PreCommonCmd Tree Davies
@ 2024-09-17 5:31 ` Tree Davies
2024-09-17 5:31 ` [PATCH 07/18] Staging: rtl8192e: Rename variable RxDataNum Tree Davies
` (13 subsequent siblings)
19 siblings, 0 replies; 25+ messages in thread
From: Tree Davies @ 2024-09-17 5:31 UTC (permalink / raw)
To: gregkh, philipp.g.hortmann, anjan
Cc: linux-staging, linux-kernel, Tree Davies
Rename variable PostCommonCmd to postcommon_cmd
to fix checkpatch warning Avoid CamelCase.
Signed-off-by: Tree Davies <tdavies@darkphysics.net>
---
drivers/staging/rtl8192e/rtl8192e/r8192E_phy.c | 4 ++--
drivers/staging/rtl8192e/rtllib.h | 2 +-
2 files changed, 3 insertions(+), 3 deletions(-)
diff --git a/drivers/staging/rtl8192e/rtl8192e/r8192E_phy.c b/drivers/staging/rtl8192e/rtl8192e/r8192E_phy.c
index ac9aea228276..b583ed0d7e92 100644
--- a/drivers/staging/rtl8192e/rtl8192e/r8192E_phy.c
+++ b/drivers/staging/rtl8192e/rtl8192e/r8192E_phy.c
@@ -562,7 +562,7 @@ static u8 _rtl92e_phy_switch_channel_step(struct net_device *dev, u8 channel,
PostCommonCmdCnt = 0;
- _rtl92e_phy_set_sw_chnl_cmd_array(dev, ieee->PostCommonCmd,
+ _rtl92e_phy_set_sw_chnl_cmd_array(dev, ieee->postcommon_cmd,
PostCommonCmdCnt++,
MAX_POSTCMD_CNT, cmd_id_end,
0, 0, 0);
@@ -597,7 +597,7 @@ static u8 _rtl92e_phy_switch_channel_step(struct net_device *dev, u8 channel,
CurrentCmd = &ieee->RfDependCmd[*step];
break;
case 2:
- CurrentCmd = &ieee->PostCommonCmd[*step];
+ CurrentCmd = &ieee->postcommon_cmd[*step];
break;
}
diff --git a/drivers/staging/rtl8192e/rtllib.h b/drivers/staging/rtl8192e/rtllib.h
index ce36f0979294..352b79c2df2f 100644
--- a/drivers/staging/rtl8192e/rtllib.h
+++ b/drivers/staging/rtl8192e/rtllib.h
@@ -1401,7 +1401,7 @@ struct rtllib_device {
struct rtllib_rxb *prxb_indicate_array[REORDER_WIN_SIZE];
struct {
struct sw_chnl_cmd precommon_cmd[MAX_PRECMD_CNT];
- struct sw_chnl_cmd PostCommonCmd[MAX_POSTCMD_CNT];
+ struct sw_chnl_cmd postcommon_cmd[MAX_POSTCMD_CNT];
struct sw_chnl_cmd RfDependCmd[MAX_RFDEPENDCMD_CNT];
};
};
--
2.30.2
^ permalink raw reply related [flat|nested] 25+ messages in thread* [PATCH 07/18] Staging: rtl8192e: Rename variable RxDataNum
2024-09-17 5:31 [PATCH 00/18] Staging: rtl8192e: 18 more Style guide variable renames Tree Davies
` (5 preceding siblings ...)
2024-09-17 5:31 ` [PATCH 06/18] Staging: rtl8192e: Rename variable PostCommonCmd Tree Davies
@ 2024-09-17 5:31 ` Tree Davies
2024-09-17 5:31 ` [PATCH 08/18] Staging: rtl8192e: Rename variable FwRWRF Tree Davies
` (12 subsequent siblings)
19 siblings, 0 replies; 25+ messages in thread
From: Tree Davies @ 2024-09-17 5:31 UTC (permalink / raw)
To: gregkh, philipp.g.hortmann, anjan
Cc: linux-staging, linux-kernel, Tree Davies
Rename variable RxDataNum to rx_data_num
to fix checkpatch warning Avoid CamelCase.
Signed-off-by: Tree Davies <tdavies@darkphysics.net>
---
drivers/staging/rtl8192e/rtl8192e/rtl_core.c | 4 ++--
drivers/staging/rtl8192e/rtllib.h | 2 +-
2 files changed, 3 insertions(+), 3 deletions(-)
diff --git a/drivers/staging/rtl8192e/rtl8192e/rtl_core.c b/drivers/staging/rtl8192e/rtl8192e/rtl_core.c
index dc1301f1a0c1..32dcccd58b9a 100644
--- a/drivers/staging/rtl8192e/rtl8192e/rtl_core.c
+++ b/drivers/staging/rtl8192e/rtl8192e/rtl_core.c
@@ -924,11 +924,11 @@ static void _rtl92e_update_rxcounts(struct r8192_priv *priv, u32 *TotalRxBcnNum,
(priv->rtllib->link_detect_info.slot_num);
priv->rtllib->link_detect_info.RxBcnNum[slot_index] =
priv->rtllib->link_detect_info.num_recv_bcn_in_period;
- priv->rtllib->link_detect_info.RxDataNum[slot_index] =
+ priv->rtllib->link_detect_info.rx_data_num[slot_index] =
priv->rtllib->link_detect_info.num_recv_data_in_period;
for (i = 0; i < priv->rtllib->link_detect_info.slot_num; i++) {
*TotalRxBcnNum += priv->rtllib->link_detect_info.RxBcnNum[i];
- *TotalRxDataNum += priv->rtllib->link_detect_info.RxDataNum[i];
+ *TotalRxDataNum += priv->rtllib->link_detect_info.rx_data_num[i];
}
}
diff --git a/drivers/staging/rtl8192e/rtllib.h b/drivers/staging/rtl8192e/rtllib.h
index 352b79c2df2f..c6a9cc0b2760 100644
--- a/drivers/staging/rtl8192e/rtllib.h
+++ b/drivers/staging/rtl8192e/rtllib.h
@@ -1086,7 +1086,7 @@ struct rt_link_detect {
u32 num_recv_data_in_period;
u32 RxBcnNum[RT_MAX_LD_SLOT_NUM];
- u32 RxDataNum[RT_MAX_LD_SLOT_NUM];
+ u32 rx_data_num[RT_MAX_LD_SLOT_NUM];
u16 slot_num;
u16 slot_index;
--
2.30.2
^ permalink raw reply related [flat|nested] 25+ messages in thread* [PATCH 08/18] Staging: rtl8192e: Rename variable FwRWRF
2024-09-17 5:31 [PATCH 00/18] Staging: rtl8192e: 18 more Style guide variable renames Tree Davies
` (6 preceding siblings ...)
2024-09-17 5:31 ` [PATCH 07/18] Staging: rtl8192e: Rename variable RxDataNum Tree Davies
@ 2024-09-17 5:31 ` Tree Davies
2024-09-17 5:31 ` [PATCH 09/18] Staging: rtl8192e: Rename variable bFirstMPDU Tree Davies
` (11 subsequent siblings)
19 siblings, 0 replies; 25+ messages in thread
From: Tree Davies @ 2024-09-17 5:31 UTC (permalink / raw)
To: gregkh, philipp.g.hortmann, anjan
Cc: linux-staging, linux-kernel, Tree Davies
Rename variable FwRWRF to fw_rw_rf
to fix checkpatch warning Avoid CamelCase.
Signed-off-by: Tree Davies <tdavies@darkphysics.net>
---
drivers/staging/rtl8192e/rtl8192e/r8192E_dev.c | 2 +-
drivers/staging/rtl8192e/rtl8192e/rtl_dm.c | 2 +-
drivers/staging/rtl8192e/rtllib.h | 2 +-
3 files changed, 3 insertions(+), 3 deletions(-)
diff --git a/drivers/staging/rtl8192e/rtl8192e/r8192E_dev.c b/drivers/staging/rtl8192e/rtl8192e/r8192E_dev.c
index 8d645d3296d2..003343e75f0c 100644
--- a/drivers/staging/rtl8192e/rtl8192e/r8192E_dev.c
+++ b/drivers/staging/rtl8192e/rtl8192e/r8192E_dev.c
@@ -613,7 +613,7 @@ bool rtl92e_start_adapter(struct net_device *dev)
priv->rtllib->rf_off_reason = 0;
}
- if (priv->rtllib->FwRWRF)
+ if (priv->rtllib->fw_rw_rf)
priv->rf_mode = RF_OP_By_FW;
else
priv->rf_mode = RF_OP_By_SW_3wire;
diff --git a/drivers/staging/rtl8192e/rtl8192e/rtl_dm.c b/drivers/staging/rtl8192e/rtl8192e/rtl_dm.c
index e9ca5a8768ad..c19522885d41 100644
--- a/drivers/staging/rtl8192e/rtl8192e/rtl_dm.c
+++ b/drivers/staging/rtl8192e/rtl8192e/rtl_dm.c
@@ -747,7 +747,7 @@ static void _rtl92e_dm_init_tx_power_tracking_thermal(struct net_device *dev)
{
struct r8192_priv *priv = rtllib_priv(dev);
- if (priv->rtllib->FwRWRF)
+ if (priv->rtllib->fw_rw_rf)
priv->btxpower_tracking = true;
else
priv->btxpower_tracking = false;
diff --git a/drivers/staging/rtl8192e/rtllib.h b/drivers/staging/rtl8192e/rtllib.h
index c6a9cc0b2760..5db03fe9269d 100644
--- a/drivers/staging/rtl8192e/rtllib.h
+++ b/drivers/staging/rtl8192e/rtllib.h
@@ -1371,7 +1371,7 @@ struct rtllib_device {
enum fsync_state fsync_state;
bool bis_any_nonbepkts;
struct bandwidth_autoswitch bandwidth_auto_switch;
- bool FwRWRF;
+ bool fw_rw_rf;
struct rt_link_detect link_detect_info;
bool is_aggregate_frame;
--
2.30.2
^ permalink raw reply related [flat|nested] 25+ messages in thread* [PATCH 09/18] Staging: rtl8192e: Rename variable bFirstMPDU
2024-09-17 5:31 [PATCH 00/18] Staging: rtl8192e: 18 more Style guide variable renames Tree Davies
` (7 preceding siblings ...)
2024-09-17 5:31 ` [PATCH 08/18] Staging: rtl8192e: Rename variable FwRWRF Tree Davies
@ 2024-09-17 5:31 ` Tree Davies
2024-09-17 5:31 ` [PATCH 10/18] Staging: rtl8192e: Rename variable bPacketBeacon Tree Davies
` (10 subsequent siblings)
19 siblings, 0 replies; 25+ messages in thread
From: Tree Davies @ 2024-09-17 5:31 UTC (permalink / raw)
To: gregkh, philipp.g.hortmann, anjan
Cc: linux-staging, linux-kernel, Tree Davies
Rename variable bFirstMPDU to first_mpdu
to fix checkpatch warning Avoid CamelCase.
Signed-off-by: Tree Davies <tdavies@darkphysics.net>
---
drivers/staging/rtl8192e/rtl8192e/r8192E_dev.c | 2 +-
drivers/staging/rtl8192e/rtl8192e/rtl_core.c | 2 +-
drivers/staging/rtl8192e/rtllib.h | 2 +-
3 files changed, 3 insertions(+), 3 deletions(-)
diff --git a/drivers/staging/rtl8192e/rtl8192e/r8192E_dev.c b/drivers/staging/rtl8192e/rtl8192e/r8192E_dev.c
index 003343e75f0c..87a370a4b2db 100644
--- a/drivers/staging/rtl8192e/rtl8192e/r8192E_dev.c
+++ b/drivers/staging/rtl8192e/rtl8192e/r8192E_dev.c
@@ -1651,7 +1651,7 @@ bool rtl92e_get_rx_stats(struct net_device *dev, struct rtllib_rx_stats *stats,
_rtl92e_update_received_rate_histogram_stats(dev, stats);
stats->bIsAMPDU = (pDrvInfo->PartAggr == 1);
- stats->bFirstMPDU = (pDrvInfo->PartAggr == 1) &&
+ stats->first_mpdu = (pDrvInfo->PartAggr == 1) &&
(pDrvInfo->FirstAGGR == 1);
stats->time_stamp_low = pDrvInfo->TSFL;
diff --git a/drivers/staging/rtl8192e/rtl8192e/rtl_core.c b/drivers/staging/rtl8192e/rtl8192e/rtl_core.c
index 32dcccd58b9a..64be0415fe0e 100644
--- a/drivers/staging/rtl8192e/rtl8192e/rtl_core.c
+++ b/drivers/staging/rtl8192e/rtl8192e/rtl_core.c
@@ -1483,7 +1483,7 @@ void rtl92e_copy_mpdu_stats(struct rtllib_rx_stats *psrc_stats,
struct rtllib_rx_stats *ptarget_stats)
{
ptarget_stats->bIsAMPDU = psrc_stats->bIsAMPDU;
- ptarget_stats->bFirstMPDU = psrc_stats->bFirstMPDU;
+ ptarget_stats->first_mpdu = psrc_stats->first_mpdu;
}
static void _rtl92e_rx_normal(struct net_device *dev)
diff --git a/drivers/staging/rtl8192e/rtllib.h b/drivers/staging/rtl8192e/rtllib.h
index 5db03fe9269d..ca8f39f8e9ea 100644
--- a/drivers/staging/rtl8192e/rtllib.h
+++ b/drivers/staging/rtl8192e/rtllib.h
@@ -477,7 +477,7 @@ struct rtllib_rx_stats {
u8 rx_drv_info_size;
u8 rx_buf_shift;
bool bIsAMPDU;
- bool bFirstMPDU;
+ bool first_mpdu;
bool contain_htc;
u32 RxPWDBAll;
u8 RxMIMOSignalStrength[2];
--
2.30.2
^ permalink raw reply related [flat|nested] 25+ messages in thread* [PATCH 10/18] Staging: rtl8192e: Rename variable bPacketBeacon
2024-09-17 5:31 [PATCH 00/18] Staging: rtl8192e: 18 more Style guide variable renames Tree Davies
` (8 preceding siblings ...)
2024-09-17 5:31 ` [PATCH 09/18] Staging: rtl8192e: Rename variable bFirstMPDU Tree Davies
@ 2024-09-17 5:31 ` Tree Davies
2024-09-17 5:31 ` [PATCH 11/18] Staging: rtl8192e: Rename variable Rx_TS_Pending_List Tree Davies
` (9 subsequent siblings)
19 siblings, 0 replies; 25+ messages in thread
From: Tree Davies @ 2024-09-17 5:31 UTC (permalink / raw)
To: gregkh, philipp.g.hortmann, anjan
Cc: linux-staging, linux-kernel, Tree Davies
Rename variable bPacketBeacon to packet_beacon
to fix checkpatch warning Avoid CamelCase.
Signed-off-by: Tree Davies <tdavies@darkphysics.net>
---
drivers/staging/rtl8192e/rtl8192e/r8192E_dev.c | 18 +++++++++---------
drivers/staging/rtl8192e/rtllib.h | 2 +-
2 files changed, 10 insertions(+), 10 deletions(-)
diff --git a/drivers/staging/rtl8192e/rtl8192e/r8192E_dev.c b/drivers/staging/rtl8192e/rtl8192e/r8192E_dev.c
index 87a370a4b2db..75ca921c8aff 100644
--- a/drivers/staging/rtl8192e/rtl8192e/r8192E_dev.c
+++ b/drivers/staging/rtl8192e/rtl8192e/r8192E_dev.c
@@ -1152,7 +1152,7 @@ static void _rtl92e_query_rxphystatus(struct r8192_priv *priv,
struct rtllib_rx_stats *precord_stats,
bool bpacket_match_bssid,
bool bpacket_toself,
- bool bPacketBeacon,
+ bool packet_beacon,
bool bToSelfBA)
{
struct phy_sts_ofdm_819xpci *pofdm_buf;
@@ -1174,7 +1174,7 @@ static void _rtl92e_query_rxphystatus(struct r8192_priv *priv,
bpacket_match_bssid;
pstats->packet_to_self = precord_stats->packet_to_self = bpacket_toself;
pstats->is_cck = precord_stats->is_cck = is_cck_rate;
- pstats->bPacketBeacon = precord_stats->bPacketBeacon = bPacketBeacon;
+ pstats->packet_beacon = precord_stats->packet_beacon = packet_beacon;
pstats->bToSelfBA = precord_stats->bToSelfBA = bToSelfBA;
if (check_reg824 == 0) {
reg824_bit9 = rtl92e_get_bb_reg(priv->rtllib->dev,
@@ -1396,7 +1396,7 @@ static void _rtl92e_process_phyinfo(struct r8192_priv *priv, u8 *buffer,
}
}
- if (prev_st->bPacketBeacon) {
+ if (prev_st->packet_beacon) {
if (slide_beacon_adc_pwdb_statistics++ >=
PHY_Beacon_RSSI_SLID_WIN_MAX) {
slide_beacon_adc_pwdb_statistics =
@@ -1416,7 +1416,7 @@ static void _rtl92e_process_phyinfo(struct r8192_priv *priv, u8 *buffer,
if (prev_st->RxPWDBAll >= 3)
prev_st->RxPWDBAll -= 3;
}
- if (prev_st->packet_to_self || prev_st->bPacketBeacon ||
+ if (prev_st->packet_to_self || prev_st->packet_beacon ||
prev_st->bToSelfBA) {
if (priv->undecorated_smoothed_pwdb < 0)
priv->undecorated_smoothed_pwdb = prev_st->RxPWDBAll;
@@ -1437,7 +1437,7 @@ static void _rtl92e_process_phyinfo(struct r8192_priv *priv, u8 *buffer,
}
if (prev_st->signal_quality != 0) {
- if (prev_st->packet_to_self || prev_st->bPacketBeacon ||
+ if (prev_st->packet_to_self || prev_st->packet_beacon ||
prev_st->bToSelfBA) {
if (slide_evm_statistics++ >= PHY_RSSI_SLID_WIN_MAX) {
slide_evm_statistics = PHY_RSSI_SLID_WIN_MAX;
@@ -1459,7 +1459,7 @@ static void _rtl92e_process_phyinfo(struct r8192_priv *priv, u8 *buffer,
}
if (prev_st->packet_to_self ||
- prev_st->bPacketBeacon ||
+ prev_st->packet_beacon ||
prev_st->bToSelfBA) {
for (ij = 0; ij < 2; ij++) {
if (prev_st->RxMIMOSignalQuality[ij] != -1) {
@@ -1485,7 +1485,7 @@ static void _rtl92e_translate_rx_signal_stats(struct net_device *dev,
{
struct r8192_priv *priv = (struct r8192_priv *)rtllib_priv(dev);
bool bpacket_match_bssid, bpacket_toself;
- bool bPacketBeacon = false;
+ bool packet_beacon = false;
struct ieee80211_hdr_3addr *hdr;
bool bToSelfBA = false;
static struct rtllib_rx_stats previous_stats;
@@ -1510,11 +1510,11 @@ static void _rtl92e_translate_rx_signal_stats(struct net_device *dev,
bpacket_toself = bpacket_match_bssid && /* check this */
ether_addr_equal(praddr, priv->rtllib->dev->dev_addr);
if (ieee80211_is_beacon(hdr->frame_control))
- bPacketBeacon = true;
+ packet_beacon = true;
_rtl92e_process_phyinfo(priv, tmp_buf, &previous_stats, pstats);
_rtl92e_query_rxphystatus(priv, pstats, pdesc, pdrvinfo,
&previous_stats, bpacket_match_bssid,
- bpacket_toself, bPacketBeacon, bToSelfBA);
+ bpacket_toself, packet_beacon, bToSelfBA);
rtl92e_copy_mpdu_stats(pstats, &previous_stats);
}
diff --git a/drivers/staging/rtl8192e/rtllib.h b/drivers/staging/rtl8192e/rtllib.h
index ca8f39f8e9ea..b0f01d940efa 100644
--- a/drivers/staging/rtl8192e/rtllib.h
+++ b/drivers/staging/rtl8192e/rtllib.h
@@ -485,7 +485,7 @@ struct rtllib_rx_stats {
bool bPacketMatchBSSID;
bool is_cck;
bool packet_to_self;
- bool bPacketBeacon;
+ bool packet_beacon;
bool bToSelfBA;
};
--
2.30.2
^ permalink raw reply related [flat|nested] 25+ messages in thread* [PATCH 11/18] Staging: rtl8192e: Rename variable Rx_TS_Pending_List
2024-09-17 5:31 [PATCH 00/18] Staging: rtl8192e: 18 more Style guide variable renames Tree Davies
` (9 preceding siblings ...)
2024-09-17 5:31 ` [PATCH 10/18] Staging: rtl8192e: Rename variable bPacketBeacon Tree Davies
@ 2024-09-17 5:31 ` Tree Davies
2024-09-17 5:31 ` [PATCH 12/18] Staging: rtl8192e: Rename variable bPacketMatchBSSID Tree Davies
` (8 subsequent siblings)
19 siblings, 0 replies; 25+ messages in thread
From: Tree Davies @ 2024-09-17 5:31 UTC (permalink / raw)
To: gregkh, philipp.g.hortmann, anjan
Cc: linux-staging, linux-kernel, Tree Davies
Rename variable Rx_TS_Pending_List to rx_ts_pending_list
to fix checkpatch warning Avoid CamelCase.
Signed-off-by: Tree Davies <tdavies@darkphysics.net>
---
drivers/staging/rtl8192e/rtl819x_TSProc.c | 6 +++---
drivers/staging/rtl8192e/rtllib.h | 2 +-
2 files changed, 4 insertions(+), 4 deletions(-)
diff --git a/drivers/staging/rtl8192e/rtl819x_TSProc.c b/drivers/staging/rtl8192e/rtl819x_TSProc.c
index 89092cd434de..efadb2b778b1 100644
--- a/drivers/staging/rtl8192e/rtl819x_TSProc.c
+++ b/drivers/staging/rtl8192e/rtl819x_TSProc.c
@@ -144,7 +144,7 @@ void rtllib_ts_init(struct rtllib_device *ieee)
}
INIT_LIST_HEAD(&ieee->Rx_TS_Admit_List);
- INIT_LIST_HEAD(&ieee->Rx_TS_Pending_List);
+ INIT_LIST_HEAD(&ieee->rx_ts_pending_list);
INIT_LIST_HEAD(&ieee->Rx_TS_Unused_List);
for (count = 0; count < TOTAL_TS_NUM; count++) {
rxts->num = count;
@@ -384,7 +384,7 @@ void remove_peer_ts(struct rtllib_device *ieee, u8 *addr)
}
}
- list_for_each_entry_safe(ts, pTmpTS, &ieee->Rx_TS_Pending_List, list) {
+ list_for_each_entry_safe(ts, pTmpTS, &ieee->rx_ts_pending_list, list) {
if (memcmp(ts->addr, addr, 6) == 0) {
RemoveTsEntry(ieee, ts, RX_DIR);
list_del_init(&ts->list);
@@ -418,7 +418,7 @@ void remove_all_ts(struct rtllib_device *ieee)
list_add_tail(&ts->list, &ieee->Tx_TS_Unused_List);
}
- list_for_each_entry_safe(ts, pTmpTS, &ieee->Rx_TS_Pending_List, list) {
+ list_for_each_entry_safe(ts, pTmpTS, &ieee->rx_ts_pending_list, list) {
RemoveTsEntry(ieee, ts, RX_DIR);
list_del_init(&ts->list);
list_add_tail(&ts->list, &ieee->Rx_TS_Unused_List);
diff --git a/drivers/staging/rtl8192e/rtllib.h b/drivers/staging/rtl8192e/rtllib.h
index b0f01d940efa..c43d5b8298f1 100644
--- a/drivers/staging/rtl8192e/rtllib.h
+++ b/drivers/staging/rtl8192e/rtllib.h
@@ -1199,7 +1199,7 @@ struct rtllib_device {
struct list_head Tx_TS_Unused_List;
struct tx_ts_record tx_ts_records[TOTAL_TS_NUM];
struct list_head Rx_TS_Admit_List;
- struct list_head Rx_TS_Pending_List;
+ struct list_head rx_ts_pending_list;
struct list_head Rx_TS_Unused_List;
struct rx_ts_record rx_ts_records[TOTAL_TS_NUM];
struct rx_reorder_entry RxReorderEntry[128];
--
2.30.2
^ permalink raw reply related [flat|nested] 25+ messages in thread* [PATCH 12/18] Staging: rtl8192e: Rename variable bPacketMatchBSSID
2024-09-17 5:31 [PATCH 00/18] Staging: rtl8192e: 18 more Style guide variable renames Tree Davies
` (10 preceding siblings ...)
2024-09-17 5:31 ` [PATCH 11/18] Staging: rtl8192e: Rename variable Rx_TS_Pending_List Tree Davies
@ 2024-09-17 5:31 ` Tree Davies
2024-09-17 5:31 ` [PATCH 13/18] Staging: rtl8192e: Rename variable bToSelfBA Tree Davies
` (7 subsequent siblings)
19 siblings, 0 replies; 25+ messages in thread
From: Tree Davies @ 2024-09-17 5:31 UTC (permalink / raw)
To: gregkh, philipp.g.hortmann, anjan
Cc: linux-staging, linux-kernel, Tree Davies
Rename variable bPacketMatchBSSID to packet_match_bssid
to fix checkpatch warning Avoid CamelCase.
Signed-off-by: Tree Davies <tdavies@darkphysics.net>
---
drivers/staging/rtl8192e/rtl8192e/r8192E_dev.c | 4 ++--
drivers/staging/rtl8192e/rtllib.h | 2 +-
2 files changed, 3 insertions(+), 3 deletions(-)
diff --git a/drivers/staging/rtl8192e/rtl8192e/r8192E_dev.c b/drivers/staging/rtl8192e/rtl8192e/r8192E_dev.c
index 75ca921c8aff..873c749250ae 100644
--- a/drivers/staging/rtl8192e/rtl8192e/r8192E_dev.c
+++ b/drivers/staging/rtl8192e/rtl8192e/r8192E_dev.c
@@ -1170,7 +1170,7 @@ static void _rtl92e_query_rxphystatus(struct r8192_priv *priv,
is_cck_rate = rx_hal_is_cck_rate(pdrvinfo);
memset(precord_stats, 0, sizeof(struct rtllib_rx_stats));
- pstats->bPacketMatchBSSID = precord_stats->bPacketMatchBSSID =
+ pstats->packet_match_bssid = precord_stats->packet_match_bssid =
bpacket_match_bssid;
pstats->packet_to_self = precord_stats->packet_to_self = bpacket_toself;
pstats->is_cck = precord_stats->is_cck = is_cck_rate;
@@ -1362,7 +1362,7 @@ static void _rtl92e_process_phyinfo(struct r8192_priv *priv, u8 *buffer,
tmp_val = priv->stats.slide_rssi_total / slide_rssi_statistics;
priv->stats.signal_strength = rtl92e_translate_to_dbm(priv, tmp_val);
curr_st->rssi = priv->stats.signal_strength;
- if (!prev_st->bPacketMatchBSSID) {
+ if (!prev_st->packet_match_bssid) {
if (!prev_st->bToSelfBA)
return;
}
diff --git a/drivers/staging/rtl8192e/rtllib.h b/drivers/staging/rtl8192e/rtllib.h
index c43d5b8298f1..4055c3044fe9 100644
--- a/drivers/staging/rtl8192e/rtllib.h
+++ b/drivers/staging/rtl8192e/rtllib.h
@@ -482,7 +482,7 @@ struct rtllib_rx_stats {
u32 RxPWDBAll;
u8 RxMIMOSignalStrength[2];
s8 RxMIMOSignalQuality[2];
- bool bPacketMatchBSSID;
+ bool packet_match_bssid;
bool is_cck;
bool packet_to_self;
bool packet_beacon;
--
2.30.2
^ permalink raw reply related [flat|nested] 25+ messages in thread* [PATCH 13/18] Staging: rtl8192e: Rename variable bToSelfBA
2024-09-17 5:31 [PATCH 00/18] Staging: rtl8192e: 18 more Style guide variable renames Tree Davies
` (11 preceding siblings ...)
2024-09-17 5:31 ` [PATCH 12/18] Staging: rtl8192e: Rename variable bPacketMatchBSSID Tree Davies
@ 2024-09-17 5:31 ` Tree Davies
2024-09-17 5:31 ` [PATCH 14/18] Staging: rtl8192e: Rename variable Tx_TS_Admit_List Tree Davies
` (6 subsequent siblings)
19 siblings, 0 replies; 25+ messages in thread
From: Tree Davies @ 2024-09-17 5:31 UTC (permalink / raw)
To: gregkh, philipp.g.hortmann, anjan
Cc: linux-staging, linux-kernel, Tree Davies
Rename variable bToSelfBA to to_self_ba
to fix checkpatch warning Avoid CamelCase.
Signed-off-by: Tree Davies <tdavies@darkphysics.net>
---
drivers/staging/rtl8192e/rtl8192e/r8192E_dev.c | 16 ++++++++--------
drivers/staging/rtl8192e/rtllib.h | 2 +-
2 files changed, 9 insertions(+), 9 deletions(-)
diff --git a/drivers/staging/rtl8192e/rtl8192e/r8192E_dev.c b/drivers/staging/rtl8192e/rtl8192e/r8192E_dev.c
index 873c749250ae..2e3e8c57d6f0 100644
--- a/drivers/staging/rtl8192e/rtl8192e/r8192E_dev.c
+++ b/drivers/staging/rtl8192e/rtl8192e/r8192E_dev.c
@@ -1153,7 +1153,7 @@ static void _rtl92e_query_rxphystatus(struct r8192_priv *priv,
bool bpacket_match_bssid,
bool bpacket_toself,
bool packet_beacon,
- bool bToSelfBA)
+ bool to_self_ba)
{
struct phy_sts_ofdm_819xpci *pofdm_buf;
struct phy_sts_cck_819xpci *pcck_buf;
@@ -1175,7 +1175,7 @@ static void _rtl92e_query_rxphystatus(struct r8192_priv *priv,
pstats->packet_to_self = precord_stats->packet_to_self = bpacket_toself;
pstats->is_cck = precord_stats->is_cck = is_cck_rate;
pstats->packet_beacon = precord_stats->packet_beacon = packet_beacon;
- pstats->bToSelfBA = precord_stats->bToSelfBA = bToSelfBA;
+ pstats->to_self_ba = precord_stats->to_self_ba = to_self_ba;
if (check_reg824 == 0) {
reg824_bit9 = rtl92e_get_bb_reg(priv->rtllib->dev,
rFPGA0_XA_HSSIParameter2,
@@ -1363,7 +1363,7 @@ static void _rtl92e_process_phyinfo(struct r8192_priv *priv, u8 *buffer,
priv->stats.signal_strength = rtl92e_translate_to_dbm(priv, tmp_val);
curr_st->rssi = priv->stats.signal_strength;
if (!prev_st->packet_match_bssid) {
- if (!prev_st->bToSelfBA)
+ if (!prev_st->to_self_ba)
return;
}
@@ -1417,7 +1417,7 @@ static void _rtl92e_process_phyinfo(struct r8192_priv *priv, u8 *buffer,
prev_st->RxPWDBAll -= 3;
}
if (prev_st->packet_to_self || prev_st->packet_beacon ||
- prev_st->bToSelfBA) {
+ prev_st->to_self_ba) {
if (priv->undecorated_smoothed_pwdb < 0)
priv->undecorated_smoothed_pwdb = prev_st->RxPWDBAll;
if (prev_st->RxPWDBAll > (u32)priv->undecorated_smoothed_pwdb) {
@@ -1438,7 +1438,7 @@ static void _rtl92e_process_phyinfo(struct r8192_priv *priv, u8 *buffer,
if (prev_st->signal_quality != 0) {
if (prev_st->packet_to_self || prev_st->packet_beacon ||
- prev_st->bToSelfBA) {
+ prev_st->to_self_ba) {
if (slide_evm_statistics++ >= PHY_RSSI_SLID_WIN_MAX) {
slide_evm_statistics = PHY_RSSI_SLID_WIN_MAX;
last_evm =
@@ -1460,7 +1460,7 @@ static void _rtl92e_process_phyinfo(struct r8192_priv *priv, u8 *buffer,
if (prev_st->packet_to_self ||
prev_st->packet_beacon ||
- prev_st->bToSelfBA) {
+ prev_st->to_self_ba) {
for (ij = 0; ij < 2; ij++) {
if (prev_st->RxMIMOSignalQuality[ij] != -1) {
if (priv->stats.rx_evm_percentage[ij] == 0)
@@ -1487,7 +1487,7 @@ static void _rtl92e_translate_rx_signal_stats(struct net_device *dev,
bool bpacket_match_bssid, bpacket_toself;
bool packet_beacon = false;
struct ieee80211_hdr_3addr *hdr;
- bool bToSelfBA = false;
+ bool to_self_ba = false;
static struct rtllib_rx_stats previous_stats;
u16 fc, type;
u8 *tmp_buf;
@@ -1514,7 +1514,7 @@ static void _rtl92e_translate_rx_signal_stats(struct net_device *dev,
_rtl92e_process_phyinfo(priv, tmp_buf, &previous_stats, pstats);
_rtl92e_query_rxphystatus(priv, pstats, pdesc, pdrvinfo,
&previous_stats, bpacket_match_bssid,
- bpacket_toself, packet_beacon, bToSelfBA);
+ bpacket_toself, packet_beacon, to_self_ba);
rtl92e_copy_mpdu_stats(pstats, &previous_stats);
}
diff --git a/drivers/staging/rtl8192e/rtllib.h b/drivers/staging/rtl8192e/rtllib.h
index 4055c3044fe9..315a75739e44 100644
--- a/drivers/staging/rtl8192e/rtllib.h
+++ b/drivers/staging/rtl8192e/rtllib.h
@@ -486,7 +486,7 @@ struct rtllib_rx_stats {
bool is_cck;
bool packet_to_self;
bool packet_beacon;
- bool bToSelfBA;
+ bool to_self_ba;
};
/* IEEE 802.11 requires that STA supports concurrent reception of at least
--
2.30.2
^ permalink raw reply related [flat|nested] 25+ messages in thread* [PATCH 14/18] Staging: rtl8192e: Rename variable Tx_TS_Admit_List
2024-09-17 5:31 [PATCH 00/18] Staging: rtl8192e: 18 more Style guide variable renames Tree Davies
` (12 preceding siblings ...)
2024-09-17 5:31 ` [PATCH 13/18] Staging: rtl8192e: Rename variable bToSelfBA Tree Davies
@ 2024-09-17 5:31 ` Tree Davies
2024-09-17 5:31 ` [PATCH 15/18] Staging: rtl8192e: Rename variable Tx_TS_Pending_List Tree Davies
` (5 subsequent siblings)
19 siblings, 0 replies; 25+ messages in thread
From: Tree Davies @ 2024-09-17 5:31 UTC (permalink / raw)
To: gregkh, philipp.g.hortmann, anjan
Cc: linux-staging, linux-kernel, Tree Davies
Rename variable Tx_TS_Admit_List to tx_ts_admit_list
to fix checkpatch warning Avoid CamelCase.
Signed-off-by: Tree Davies <tdavies@darkphysics.net>
---
drivers/staging/rtl8192e/rtl819x_TSProc.c | 10 +++++-----
drivers/staging/rtl8192e/rtllib.h | 2 +-
2 files changed, 6 insertions(+), 6 deletions(-)
diff --git a/drivers/staging/rtl8192e/rtl819x_TSProc.c b/drivers/staging/rtl8192e/rtl819x_TSProc.c
index efadb2b778b1..e87d2926f47c 100644
--- a/drivers/staging/rtl8192e/rtl819x_TSProc.c
+++ b/drivers/staging/rtl8192e/rtl819x_TSProc.c
@@ -124,7 +124,7 @@ void rtllib_ts_init(struct rtllib_device *ieee)
struct rx_reorder_entry *pRxReorderEntry = ieee->RxReorderEntry;
u8 count = 0;
- INIT_LIST_HEAD(&ieee->Tx_TS_Admit_List);
+ INIT_LIST_HEAD(&ieee->tx_ts_admit_list);
INIT_LIST_HEAD(&ieee->Tx_TS_Pending_List);
INIT_LIST_HEAD(&ieee->Tx_TS_Unused_List);
@@ -189,7 +189,7 @@ static struct ts_common_info *SearchAdmitTRStream(struct rtllib_device *ieee,
}
if (tx_rx_select == TX_DIR)
- psearch_list = &ieee->Tx_TS_Admit_List;
+ psearch_list = &ieee->tx_ts_admit_list;
else
psearch_list = &ieee->Rx_TS_Admit_List;
@@ -279,7 +279,7 @@ bool rtllib_get_ts(struct rtllib_device *ieee, struct ts_common_info **ppTS,
(&ieee->Rx_TS_Unused_List);
pAddmitList = (tx_rx_select == TX_DIR) ?
- (&ieee->Tx_TS_Admit_List) :
+ (&ieee->tx_ts_admit_list) :
(&ieee->Rx_TS_Admit_List);
Dir = ((tx_rx_select == TX_DIR) ? DIR_UP : DIR_DOWN);
@@ -374,7 +374,7 @@ void remove_peer_ts(struct rtllib_device *ieee, u8 *addr)
}
}
- list_for_each_entry_safe(ts, pTmpTS, &ieee->Tx_TS_Admit_List, list) {
+ list_for_each_entry_safe(ts, pTmpTS, &ieee->tx_ts_admit_list, list) {
if (memcmp(ts->addr, addr, 6) == 0) {
netdev_info(ieee->dev,
"====>remove Tx_TS_admin_list\n");
@@ -412,7 +412,7 @@ void remove_all_ts(struct rtllib_device *ieee)
list_add_tail(&ts->list, &ieee->Tx_TS_Unused_List);
}
- list_for_each_entry_safe(ts, pTmpTS, &ieee->Tx_TS_Admit_List, list) {
+ list_for_each_entry_safe(ts, pTmpTS, &ieee->tx_ts_admit_list, list) {
RemoveTsEntry(ieee, ts, TX_DIR);
list_del_init(&ts->list);
list_add_tail(&ts->list, &ieee->Tx_TS_Unused_List);
diff --git a/drivers/staging/rtl8192e/rtllib.h b/drivers/staging/rtl8192e/rtllib.h
index 315a75739e44..3544054b78fc 100644
--- a/drivers/staging/rtl8192e/rtllib.h
+++ b/drivers/staging/rtl8192e/rtllib.h
@@ -1194,7 +1194,7 @@ struct rtllib_device {
u8 tx_enable_fw_calc_dur;
atomic_t atm_swbw;
- struct list_head Tx_TS_Admit_List;
+ struct list_head tx_ts_admit_list;
struct list_head Tx_TS_Pending_List;
struct list_head Tx_TS_Unused_List;
struct tx_ts_record tx_ts_records[TOTAL_TS_NUM];
--
2.30.2
^ permalink raw reply related [flat|nested] 25+ messages in thread* [PATCH 15/18] Staging: rtl8192e: Rename variable Tx_TS_Pending_List
2024-09-17 5:31 [PATCH 00/18] Staging: rtl8192e: 18 more Style guide variable renames Tree Davies
` (13 preceding siblings ...)
2024-09-17 5:31 ` [PATCH 14/18] Staging: rtl8192e: Rename variable Tx_TS_Admit_List Tree Davies
@ 2024-09-17 5:31 ` Tree Davies
2024-09-17 5:31 ` [PATCH 16/18] Staging: rtl8192e: Rename variable Tx_TS_Unused_List Tree Davies
` (4 subsequent siblings)
19 siblings, 0 replies; 25+ messages in thread
From: Tree Davies @ 2024-09-17 5:31 UTC (permalink / raw)
To: gregkh, philipp.g.hortmann, anjan
Cc: linux-staging, linux-kernel, Tree Davies
Rename variable Tx_TS_Pending_List to tx_ts_pending_list
to fix checkpatch warning Avoid CamelCase.
Signed-off-by: Tree Davies <tdavies@darkphysics.net>
---
drivers/staging/rtl8192e/rtl819x_TSProc.c | 6 +++---
drivers/staging/rtl8192e/rtllib.h | 2 +-
2 files changed, 4 insertions(+), 4 deletions(-)
diff --git a/drivers/staging/rtl8192e/rtl819x_TSProc.c b/drivers/staging/rtl8192e/rtl819x_TSProc.c
index e87d2926f47c..0b906d618a90 100644
--- a/drivers/staging/rtl8192e/rtl819x_TSProc.c
+++ b/drivers/staging/rtl8192e/rtl819x_TSProc.c
@@ -125,7 +125,7 @@ void rtllib_ts_init(struct rtllib_device *ieee)
u8 count = 0;
INIT_LIST_HEAD(&ieee->tx_ts_admit_list);
- INIT_LIST_HEAD(&ieee->Tx_TS_Pending_List);
+ INIT_LIST_HEAD(&ieee->tx_ts_pending_list);
INIT_LIST_HEAD(&ieee->Tx_TS_Unused_List);
for (count = 0; count < TOTAL_TS_NUM; count++) {
@@ -366,7 +366,7 @@ void remove_peer_ts(struct rtllib_device *ieee, u8 *addr)
netdev_info(ieee->dev, "===========>%s, %pM\n", __func__, addr);
- list_for_each_entry_safe(ts, pTmpTS, &ieee->Tx_TS_Pending_List, list) {
+ list_for_each_entry_safe(ts, pTmpTS, &ieee->tx_ts_pending_list, list) {
if (memcmp(ts->addr, addr, 6) == 0) {
RemoveTsEntry(ieee, ts, TX_DIR);
list_del_init(&ts->list);
@@ -406,7 +406,7 @@ void remove_all_ts(struct rtllib_device *ieee)
{
struct ts_common_info *ts, *pTmpTS;
- list_for_each_entry_safe(ts, pTmpTS, &ieee->Tx_TS_Pending_List, list) {
+ list_for_each_entry_safe(ts, pTmpTS, &ieee->tx_ts_pending_list, list) {
RemoveTsEntry(ieee, ts, TX_DIR);
list_del_init(&ts->list);
list_add_tail(&ts->list, &ieee->Tx_TS_Unused_List);
diff --git a/drivers/staging/rtl8192e/rtllib.h b/drivers/staging/rtl8192e/rtllib.h
index 3544054b78fc..ff6b59874fed 100644
--- a/drivers/staging/rtl8192e/rtllib.h
+++ b/drivers/staging/rtl8192e/rtllib.h
@@ -1195,7 +1195,7 @@ struct rtllib_device {
atomic_t atm_swbw;
struct list_head tx_ts_admit_list;
- struct list_head Tx_TS_Pending_List;
+ struct list_head tx_ts_pending_list;
struct list_head Tx_TS_Unused_List;
struct tx_ts_record tx_ts_records[TOTAL_TS_NUM];
struct list_head Rx_TS_Admit_List;
--
2.30.2
^ permalink raw reply related [flat|nested] 25+ messages in thread* [PATCH 16/18] Staging: rtl8192e: Rename variable Tx_TS_Unused_List
2024-09-17 5:31 [PATCH 00/18] Staging: rtl8192e: 18 more Style guide variable renames Tree Davies
` (14 preceding siblings ...)
2024-09-17 5:31 ` [PATCH 15/18] Staging: rtl8192e: Rename variable Tx_TS_Pending_List Tree Davies
@ 2024-09-17 5:31 ` Tree Davies
2024-09-17 5:31 ` [PATCH 17/18] Staging: rtl8192e: Rename variable Sbox Tree Davies
` (3 subsequent siblings)
19 siblings, 0 replies; 25+ messages in thread
From: Tree Davies @ 2024-09-17 5:31 UTC (permalink / raw)
To: gregkh, philipp.g.hortmann, anjan
Cc: linux-staging, linux-kernel, Tree Davies
Rename variable Tx_TS_Unused_List to tx_ts_unused_list
to fix checkpatch warning Avoid CamelCase.
Signed-off-by: Tree Davies <tdavies@darkphysics.net>
---
drivers/staging/rtl8192e/rtl819x_TSProc.c | 14 +++++++-------
drivers/staging/rtl8192e/rtllib.h | 2 +-
2 files changed, 8 insertions(+), 8 deletions(-)
diff --git a/drivers/staging/rtl8192e/rtl819x_TSProc.c b/drivers/staging/rtl8192e/rtl819x_TSProc.c
index 0b906d618a90..ecbe3bd67a0c 100644
--- a/drivers/staging/rtl8192e/rtl819x_TSProc.c
+++ b/drivers/staging/rtl8192e/rtl819x_TSProc.c
@@ -126,7 +126,7 @@ void rtllib_ts_init(struct rtllib_device *ieee)
INIT_LIST_HEAD(&ieee->tx_ts_admit_list);
INIT_LIST_HEAD(&ieee->tx_ts_pending_list);
- INIT_LIST_HEAD(&ieee->Tx_TS_Unused_List);
+ INIT_LIST_HEAD(&ieee->tx_ts_unused_list);
for (count = 0; count < TOTAL_TS_NUM; count++) {
pTxTS->num = count;
@@ -139,7 +139,7 @@ void rtllib_ts_init(struct rtllib_device *ieee)
ResetTxTsEntry(pTxTS);
list_add_tail(&pTxTS->ts_common_info.list,
- &ieee->Tx_TS_Unused_List);
+ &ieee->tx_ts_unused_list);
pTxTS++;
}
@@ -275,7 +275,7 @@ bool rtllib_get_ts(struct rtllib_device *ieee, struct ts_common_info **ppTS,
}
pUnusedList = (tx_rx_select == TX_DIR) ?
- (&ieee->Tx_TS_Unused_List) :
+ (&ieee->tx_ts_unused_list) :
(&ieee->Rx_TS_Unused_List);
pAddmitList = (tx_rx_select == TX_DIR) ?
@@ -370,7 +370,7 @@ void remove_peer_ts(struct rtllib_device *ieee, u8 *addr)
if (memcmp(ts->addr, addr, 6) == 0) {
RemoveTsEntry(ieee, ts, TX_DIR);
list_del_init(&ts->list);
- list_add_tail(&ts->list, &ieee->Tx_TS_Unused_List);
+ list_add_tail(&ts->list, &ieee->tx_ts_unused_list);
}
}
@@ -380,7 +380,7 @@ void remove_peer_ts(struct rtllib_device *ieee, u8 *addr)
"====>remove Tx_TS_admin_list\n");
RemoveTsEntry(ieee, ts, TX_DIR);
list_del_init(&ts->list);
- list_add_tail(&ts->list, &ieee->Tx_TS_Unused_List);
+ list_add_tail(&ts->list, &ieee->tx_ts_unused_list);
}
}
@@ -409,13 +409,13 @@ void remove_all_ts(struct rtllib_device *ieee)
list_for_each_entry_safe(ts, pTmpTS, &ieee->tx_ts_pending_list, list) {
RemoveTsEntry(ieee, ts, TX_DIR);
list_del_init(&ts->list);
- list_add_tail(&ts->list, &ieee->Tx_TS_Unused_List);
+ list_add_tail(&ts->list, &ieee->tx_ts_unused_list);
}
list_for_each_entry_safe(ts, pTmpTS, &ieee->tx_ts_admit_list, list) {
RemoveTsEntry(ieee, ts, TX_DIR);
list_del_init(&ts->list);
- list_add_tail(&ts->list, &ieee->Tx_TS_Unused_List);
+ list_add_tail(&ts->list, &ieee->tx_ts_unused_list);
}
list_for_each_entry_safe(ts, pTmpTS, &ieee->rx_ts_pending_list, list) {
diff --git a/drivers/staging/rtl8192e/rtllib.h b/drivers/staging/rtl8192e/rtllib.h
index ff6b59874fed..074cd837c708 100644
--- a/drivers/staging/rtl8192e/rtllib.h
+++ b/drivers/staging/rtl8192e/rtllib.h
@@ -1196,7 +1196,7 @@ struct rtllib_device {
struct list_head tx_ts_admit_list;
struct list_head tx_ts_pending_list;
- struct list_head Tx_TS_Unused_List;
+ struct list_head tx_ts_unused_list;
struct tx_ts_record tx_ts_records[TOTAL_TS_NUM];
struct list_head Rx_TS_Admit_List;
struct list_head rx_ts_pending_list;
--
2.30.2
^ permalink raw reply related [flat|nested] 25+ messages in thread* [PATCH 17/18] Staging: rtl8192e: Rename variable Sbox
2024-09-17 5:31 [PATCH 00/18] Staging: rtl8192e: 18 more Style guide variable renames Tree Davies
` (15 preceding siblings ...)
2024-09-17 5:31 ` [PATCH 16/18] Staging: rtl8192e: Rename variable Tx_TS_Unused_List Tree Davies
@ 2024-09-17 5:31 ` Tree Davies
2024-09-17 5:31 ` [PATCH 18/18] Staging: rtl8192e: Rename variable pMCSFilter Tree Davies
` (2 subsequent siblings)
19 siblings, 0 replies; 25+ messages in thread
From: Tree Davies @ 2024-09-17 5:31 UTC (permalink / raw)
To: gregkh, philipp.g.hortmann, anjan
Cc: linux-staging, linux-kernel, Tree Davies
Rename variable Sbox to box
to fix checkpatch warning Avoid CamelCase.
Signed-off-by: Tree Davies <tdavies@darkphysics.net>
---
drivers/staging/rtl8192e/rtllib_crypt_tkip.c | 6 +++---
1 file changed, 3 insertions(+), 3 deletions(-)
diff --git a/drivers/staging/rtl8192e/rtllib_crypt_tkip.c b/drivers/staging/rtl8192e/rtllib_crypt_tkip.c
index fb80ae6c3f2f..2b9e882d0bef 100644
--- a/drivers/staging/rtl8192e/rtllib_crypt_tkip.c
+++ b/drivers/staging/rtl8192e/rtllib_crypt_tkip.c
@@ -137,7 +137,7 @@ static inline u16 Mk16_le(u16 *v)
return *v;
}
-static const u16 Sbox[256] = {
+static const u16 box[256] = {
0xC6A5, 0xF884, 0xEE99, 0xF68D, 0xFF0D, 0xD6BD, 0xDEB1, 0x9154,
0x6050, 0x0203, 0xCEA9, 0x567D, 0xE719, 0xB562, 0x4DE6, 0xEC9A,
0x8F45, 0x1F9D, 0x8940, 0xFA87, 0xEF15, 0xB2EB, 0x8EC9, 0xFB0B,
@@ -174,8 +174,8 @@ static const u16 Sbox[256] = {
static inline u16 _S_(u16 v)
{
- u16 t = Sbox[Hi8(v)];
- return Sbox[Lo8(v)] ^ ((t << 8) | (t >> 8));
+ u16 t = box[Hi8(v)];
+ return box[Lo8(v)] ^ ((t << 8) | (t >> 8));
}
#define PHASE1_LOOP_COUNT 8
--
2.30.2
^ permalink raw reply related [flat|nested] 25+ messages in thread* [PATCH 18/18] Staging: rtl8192e: Rename variable pMCSFilter
2024-09-17 5:31 [PATCH 00/18] Staging: rtl8192e: 18 more Style guide variable renames Tree Davies
` (16 preceding siblings ...)
2024-09-17 5:31 ` [PATCH 17/18] Staging: rtl8192e: Rename variable Sbox Tree Davies
@ 2024-09-17 5:31 ` Tree Davies
2024-09-17 20:05 ` [PATCH 00/18] Staging: rtl8192e: 18 more Style guide variable renames philipp hortmann
2024-10-09 9:53 ` Greg KH
19 siblings, 0 replies; 25+ messages in thread
From: Tree Davies @ 2024-09-17 5:31 UTC (permalink / raw)
To: gregkh, philipp.g.hortmann, anjan
Cc: linux-staging, linux-kernel, Tree Davies
Rename variable pMCSFilter to mcs_filter
to fix checkpatch warning Avoid CamelCase.
Signed-off-by: Tree Davies <tdavies@darkphysics.net>
---
drivers/staging/rtl8192e/rtl819x_HTProc.c | 8 ++++----
drivers/staging/rtl8192e/rtllib.h | 2 +-
2 files changed, 5 insertions(+), 5 deletions(-)
diff --git a/drivers/staging/rtl8192e/rtl819x_HTProc.c b/drivers/staging/rtl8192e/rtl819x_HTProc.c
index 2eba916d7f50..ee6bc3202727 100644
--- a/drivers/staging/rtl8192e/rtl819x_HTProc.c
+++ b/drivers/staging/rtl8192e/rtl819x_HTProc.c
@@ -358,21 +358,21 @@ static u8 ht_pick_mcs_rate(struct rtllib_device *ieee, u8 *pOperateMCS)
}
u8 ht_get_highest_mcs_rate(struct rtllib_device *ieee, u8 *mcs_rate_set,
- u8 *pMCSFilter)
+ u8 *mcs_filter)
{
u8 i, j;
u8 bitMap;
u8 mcsRate = 0;
u8 availableMcsRate[16];
- if (!mcs_rate_set || !pMCSFilter) {
+ if (!mcs_rate_set || !mcs_filter) {
netdev_warn(ieee->dev,
- "%s(): mcs_rate_set and pMCSFilter are null\n",
+ "%s(): mcs_rate_set and mcs_filter are null\n",
__func__);
return false;
}
for (i = 0; i < 16; i++)
- availableMcsRate[i] = mcs_rate_set[i] & pMCSFilter[i];
+ availableMcsRate[i] = mcs_rate_set[i] & mcs_filter[i];
for (i = 0; i < 16; i++) {
if (availableMcsRate[i] != 0)
diff --git a/drivers/staging/rtl8192e/rtllib.h b/drivers/staging/rtl8192e/rtllib.h
index 074cd837c708..ff616c82b942 100644
--- a/drivers/staging/rtl8192e/rtllib.h
+++ b/drivers/staging/rtl8192e/rtllib.h
@@ -1737,7 +1737,7 @@ void ht_reset_self_and_save_peer_setting(struct rtllib_device *ieee,
void HT_update_self_and_peer_setting(struct rtllib_device *ieee,
struct rtllib_network *network);
u8 ht_get_highest_mcs_rate(struct rtllib_device *ieee, u8 *mcs_rate_set,
- u8 *pMCSFilter);
+ u8 *mcs_filter);
extern u8 MCS_FILTER_ALL[];
extern u16 MCS_DATA_RATE[2][2][77];
u8 ht_c_check(struct rtllib_device *ieee, u8 *frame);
--
2.30.2
^ permalink raw reply related [flat|nested] 25+ messages in thread* Re: [PATCH 00/18] Staging: rtl8192e: 18 more Style guide variable renames
2024-09-17 5:31 [PATCH 00/18] Staging: rtl8192e: 18 more Style guide variable renames Tree Davies
` (17 preceding siblings ...)
2024-09-17 5:31 ` [PATCH 18/18] Staging: rtl8192e: Rename variable pMCSFilter Tree Davies
@ 2024-09-17 20:05 ` philipp hortmann
2024-10-09 9:53 ` Greg KH
19 siblings, 0 replies; 25+ messages in thread
From: philipp hortmann @ 2024-09-17 20:05 UTC (permalink / raw)
To: Tree Davies; +Cc: gregkh, anjan, linux-staging, linux-kernel
On Mon, Sep 16, 2024 at 10:31:34PM -0700, Tree Davies wrote:
> This series fixes camelCase variable names
> Thank you to all reviewers.
> ~Tree
>
> Tree Davies (18):
> Staging: rtl8192e: Rename variable nDataRate
> Staging: rtl8192e: Rename variable bIsCCK
> Staging: rtl8192e: Rename variable bCRC
> Staging: rtl8192e: Rename variable pMCSRateSet
> Staging: rtl8192e: Rename variable PreCommonCmd
> Staging: rtl8192e: Rename variable PostCommonCmd
> Staging: rtl8192e: Rename variable RxDataNum
> Staging: rtl8192e: Rename variable FwRWRF
> Staging: rtl8192e: Rename variable bFirstMPDU
> Staging: rtl8192e: Rename variable bPacketBeacon
> Staging: rtl8192e: Rename variable Rx_TS_Pending_List
> Staging: rtl8192e: Rename variable bPacketMatchBSSID
> Staging: rtl8192e: Rename variable bToSelfBA
> Staging: rtl8192e: Rename variable Tx_TS_Admit_List
> Staging: rtl8192e: Rename variable Tx_TS_Pending_List
> Staging: rtl8192e: Rename variable Tx_TS_Unused_List
> Staging: rtl8192e: Rename variable Sbox
> Staging: rtl8192e: Rename variable pMCSFilter
>
> .../staging/rtl8192e/rtl8192e/r8192E_dev.c | 50 +++++++++----------
> .../staging/rtl8192e/rtl8192e/r8192E_phy.c | 10 ++--
> drivers/staging/rtl8192e/rtl8192e/rtl_core.c | 6 +--
> drivers/staging/rtl8192e/rtl8192e/rtl_dm.c | 2 +-
> drivers/staging/rtl8192e/rtl819x_HTProc.c | 10 ++--
> drivers/staging/rtl8192e/rtl819x_TSProc.c | 36 ++++++-------
> drivers/staging/rtl8192e/rtllib.h | 34 ++++++-------
> drivers/staging/rtl8192e/rtllib_crypt_tkip.c | 6 +--
> 8 files changed, 77 insertions(+), 77 deletions(-)
>
> --
> 2.30.2
>
Tested-by: Philipp Hortmann <philipp.g.hortmann@gmail.com>
^ permalink raw reply [flat|nested] 25+ messages in thread* Re: [PATCH 00/18] Staging: rtl8192e: 18 more Style guide variable renames
2024-09-17 5:31 [PATCH 00/18] Staging: rtl8192e: 18 more Style guide variable renames Tree Davies
` (18 preceding siblings ...)
2024-09-17 20:05 ` [PATCH 00/18] Staging: rtl8192e: 18 more Style guide variable renames philipp hortmann
@ 2024-10-09 9:53 ` Greg KH
[not found] ` <e0cdfdd3-eebb-40c5-a845-fbc5e52364d5@darkphysics.net>
19 siblings, 1 reply; 25+ messages in thread
From: Greg KH @ 2024-10-09 9:53 UTC (permalink / raw)
To: Tree Davies; +Cc: philipp.g.hortmann, anjan, linux-staging, linux-kernel
On Mon, Sep 16, 2024 at 10:31:34PM -0700, Tree Davies wrote:
> This series fixes camelCase variable names
> Thank you to all reviewers.
> ~Tree
Sorry, but this driver is now deleted from the tree.
greg k-h
^ permalink raw reply [flat|nested] 25+ messages in thread