From: Andy Shevchenko <andy@kernel.org>
To: Li Huafei <lihuafei1@huawei.com>
Cc: mchehab@kernel.org, hdegoede@redhat.com,
sakari.ailus@linux.intel.com, gregkh@linuxfoundation.org,
linux-media@vger.kernel.org, linux-staging@lists.linux.dev,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH] media: atomisp: Add check for rgby_data memory allocation failure
Date: Fri, 1 Nov 2024 10:30:07 +0200 [thread overview]
Message-ID: <ZySRjyrxI9jrcY1q@smile.fi.intel.com> (raw)
In-Reply-To: <20241101154823.3067891-1-lihuafei1@huawei.com>
On Fri, Nov 01, 2024 at 11:48:23PM +0800, Li Huafei wrote:
> In ia_css_3a_statistics_allocate(), there is no check on the allocation
> result of the rgby_data memory. If rgby_data is not successfully
> allocated, it may trigger the assert(host_stats->rgby_data) assertion in
> ia_css_s3a_hmem_decode(). Adding a check to fix this potential issue.
Not sure if this code even run on currently supported hardware / firmware,
but fix looks okay.
> Fixes: ad85094b293e ("Revert "media: staging: atomisp: Remove driver"")
No, this is an intermediate commit, you should find the original, which is
earlier in the history.
--
With Best Regards,
Andy Shevchenko
next prev parent reply other threads:[~2024-11-01 8:30 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-11-01 15:48 [PATCH] media: atomisp: Add check for rgby_data memory allocation failure Li Huafei
2024-11-01 8:30 ` Andy Shevchenko [this message]
2024-11-01 9:57 ` Li Huafei
2024-11-01 10:16 ` Andy Shevchenko
2024-11-01 10:55 ` Andy Shevchenko
2024-11-04 7:30 ` Li Huafei
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=ZySRjyrxI9jrcY1q@smile.fi.intel.com \
--to=andy@kernel.org \
--cc=gregkh@linuxfoundation.org \
--cc=hdegoede@redhat.com \
--cc=lihuafei1@huawei.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-media@vger.kernel.org \
--cc=linux-staging@lists.linux.dev \
--cc=mchehab@kernel.org \
--cc=sakari.ailus@linux.intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox