From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-lj1-f181.google.com (mail-lj1-f181.google.com [209.85.208.181]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 2F2392C82 for ; Tue, 16 Nov 2021 15:01:49 +0000 (UTC) Received: by mail-lj1-f181.google.com with SMTP id e11so43866601ljo.13 for ; Tue, 16 Nov 2021 07:01:48 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; h=message-id:date:mime-version:user-agent:subject:content-language:to :cc:references:from:in-reply-to:content-transfer-encoding; bh=UuIR/LC5SZev9/eHpT6QZZqfs4WuN126EuywzDwkq7g=; b=nqTPwTBVRq32cNn1Jujn9/JLlQohZJJjJf5gVKmHbROJAU3xq4TV+9GJexVSAtzdti YgtX1tWHKce4IliAELS3DhH9r2+6gwhu4aYoDVI8yqTx7ccPo5YuBpDJ7IsKWoB0bsSP eupb1zU9syyjZkrVs56pwf7iLj9aSneLB0BFFQ2lbBX3WOnr2rZCLR+ppEBhXQ/+laI+ fAfrcRfLxKbCm2327cFBNQIUjTj9jIXeW1Um+i9Cv1xEKah9Uj/jEIRTJbQy3To8JKj7 085KSwX84gUjPRWWEU87II8WrD0OOTayfIyNU5RXBRPakgMQE7EU5QVQoaNQpDxY48lb OT+Q== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:message-id:date:mime-version:user-agent:subject :content-language:to:cc:references:from:in-reply-to :content-transfer-encoding; bh=UuIR/LC5SZev9/eHpT6QZZqfs4WuN126EuywzDwkq7g=; b=giqMnefkabYgn0bV8U2KGlKq4M0SD20rKaTaNQUBC0w7+l0zaxbK8d6d70OLYspDWf Iy4cGqT+ff3p3Q6FOR7pshHCXPj6sWoWFvOVVlbeWg5/w7HtAjSU5rGtNfsTd9IBrGMd xu3LnR5aR25SLP6yHpbLr8DgZs8lf6c0mj+qMbQJw3zb1FwbU2BxPpusGQg+Q1D485xA F9gorXm0tNUC/D6FIp7m/ML+OYfMry9atrFB1zZ4e3Se53J7cjRPbHmBUo9k9bhltWeU 7rEUs2/H5iN1zGiFFSkR5UIAa+sderKTEOJNFsJX0OnH/AI8GgSyN5fbOgeVEqLJqDjT qsXQ== X-Gm-Message-State: AOAM532wCaM78LEQKtRXd6ayZ49HFw556U0sBXEDKCvp6R6734/bcTyG P8TpoEAgsK+zc7wy+TNV2oaq04Dw0A8= X-Google-Smtp-Source: ABdhPJwKXYaVHZATt0RLChSCOq+HG2P+t+x0FPazQIoy7EwZg6loUPIlGN9o5As0jSAZqoVpQIX4Jg== X-Received: by 2002:a2e:a6a0:: with SMTP id q32mr7873917lje.148.1637074906230; Tue, 16 Nov 2021 07:01:46 -0800 (PST) Received: from [192.168.1.11] ([94.103.224.112]) by smtp.gmail.com with ESMTPSA id f10sm1783979lfu.122.2021.11.16.07.01.45 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Tue, 16 Nov 2021 07:01:45 -0800 (PST) Message-ID: Date: Tue, 16 Nov 2021 18:01:42 +0300 Precedence: bulk X-Mailing-List: linux-staging@lists.linux.dev List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:91.0) Gecko/20100101 Thunderbird/91.3.0 Subject: Re: [PATCH] staging: r8188eu: remove unused defines in wifi.h Content-Language: en-US To: Dan Carpenter Cc: Zameer Manji , gregkh@linuxfoundation.org, Larry Finger , Phillip Potter , Michael Straube , "Fabio M. De Francesco" , linux-staging@lists.linux.dev, linux-kernel@vger.kernel.org References: <20211116011451.896714-1-zmanji@gmail.com> <6d2d9c4a-3f05-1d51-42dc-b1ebbb4aefe1@gmail.com> <22a48290-814e-bcae-81e5-c23e6310f8f6@gmail.com> <20211116141838.GI26989@kadam> From: Pavel Skripkin In-Reply-To: <20211116141838.GI26989@kadam> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit On 11/16/21 17:18, Dan Carpenter wrote: >> I cannot ack, since I am not the maintainer (or even reviewer) of this >> driver :) I just saw this BIT() definition and decided to say, that it can >> be also removed > > Just give a Reviewed-by tag... No one is appointed as a maintainer, you > just have to start handing our reviewed-by tags until people start to > respect your judgement and then you're a maintainer. > Ok, I will send the R-b tag, since patch looks correct to me as is :) I think, I misunderstood what "ack" means. I thought Zameer means Acked-by tag, which can sent only by maintainers (Larry and Phillip in case of r8188eu), but I was wrong, I guess... With regards, Pavel Skripkin