public inbox for linux-staging@lists.linux.dev
 help / color / mirror / Atom feed
From: Philipp Hortmann <philipp.g.hortmann@gmail.com>
To: Dan Carpenter <error27@gmail.com>
Cc: Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
	linux-staging@lists.linux.dev, linux-kernel@vger.kernel.org
Subject: Re: [PATCH 1/2] staging: rtl8192e: Remove empty Array Rtl8192PciEPHY_REGArray
Date: Mon, 6 Mar 2023 21:49:40 +0100	[thread overview]
Message-ID: <a8416a2b-fa76-ed07-1364-9cea32bf14f3@gmail.com> (raw)
In-Reply-To: <7d3eaf69-8ddb-4b63-ae8c-89b6a34e9493@kili.mountain>

On 3/6/23 10:25, Dan Carpenter wrote:
> On Sat, Mar 04, 2023 at 08:13:22PM +0100, Philipp Hortmann wrote:
>> Remove empty array Rtl8192PciEPHY_REGArray and the code where it is used
>> because it is dead code.
>>
>> Signed-off-by: Philipp Hortmann <philipp.g.hortmann@gmail.com>
>> ---
>>   drivers/staging/rtl8192e/rtl8192e/r8192E_phy.c | 5 +----
>>   drivers/staging/rtl8192e/rtl8192e/r8192E_phy.h | 2 --
>>   drivers/staging/rtl8192e/rtl8192e/table.c      | 2 --
>>   drivers/staging/rtl8192e/rtl8192e/table.h      | 2 --
> 
> What are these table.[ch] files?  I don't seem to have them.
> 
> regards,
> dan carpenter
> 


Hi Dan,

thanks for the review. Here some answers to your questions:

With patch: "[PATCH] staging: rtl8192e: Change filename r8192E_hwimg.x 
to table.x" I changed the filename of r8192E_hwimg.c to table.c and 
r8192E_hwimg.h to table.h to adapt filenames from 
drivers/net/wireless/realtek/rtlwifi rtl8192ee and rtl8192se. Task is 
from TODO file.

Thanks for your support.

Bye Philipp

  reply	other threads:[~2023-03-06 20:49 UTC|newest]

Thread overview: 5+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2023-03-04 19:12 [PATCH 0/2] staging: rtl8192e: Removing rf_type RF_2T4R from driver Philipp Hortmann
2023-03-04 19:13 ` [PATCH 1/2] staging: rtl8192e: Remove empty Array Rtl8192PciEPHY_REGArray Philipp Hortmann
2023-03-06  9:25   ` Dan Carpenter
2023-03-06 20:49     ` Philipp Hortmann [this message]
2023-03-04 19:13 ` [PATCH 2/2] staging: rtl8192e: Remove conditions for RF_2T4R Philipp Hortmann

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=a8416a2b-fa76-ed07-1364-9cea32bf14f3@gmail.com \
    --to=philipp.g.hortmann@gmail.com \
    --cc=error27@gmail.com \
    --cc=gregkh@linuxfoundation.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-staging@lists.linux.dev \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox