From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mgamail.intel.com (mgamail.intel.com [198.175.65.11]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id D3FD218A93F for ; Thu, 8 May 2025 13:48:38 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=198.175.65.11 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1746712120; cv=none; b=ClFOzzKEdrnNpnvEHley1SMy5sUp5xzP6vyxrkacjiaCZweNzN7FPIMs6gjytd2atEolyDNyUqd75pLuHGBXW3F6uExdlmeC3oWnUYzpNHztAP/yf8zxzRWBjMisoPyPEw9pkcelrxPbdJT4rYyBsnMcMIVWJmf8i4JgUf63xaQ= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1746712120; c=relaxed/simple; bh=gw2zPlLac5sBf5f8EpTbuMbjUdDqEwgXD5tWTAbTEu8=; h=From:Date:To:cc:Subject:In-Reply-To:Message-ID:References: MIME-Version:Content-Type; b=r5GhxK945jDgeWkuXDWWJDDt8zd9qrc+mTw8+Aml/4hCF7GkTyto31l3ehlOa/+aylSPld9cilb9fllP6aaYyzl/KQIB4Dy19+45Mj53W3eMdIYTtfdL0GXQdcgAcQld8t9y0gMvS4IGd/krTq0jDek8iyQN54haS0UmA9lpetk= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=linux.intel.com; spf=none smtp.mailfrom=linux.intel.com; dkim=pass (2048-bit key) header.d=intel.com header.i=@intel.com header.b=Ol+9KkbW; arc=none smtp.client-ip=198.175.65.11 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=linux.intel.com Authentication-Results: smtp.subspace.kernel.org; spf=none smtp.mailfrom=linux.intel.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=intel.com header.i=@intel.com header.b="Ol+9KkbW" DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=intel.com; i=@intel.com; q=dns/txt; s=Intel; t=1746712119; x=1778248119; h=from:date:to:cc:subject:in-reply-to:message-id: references:mime-version:content-id; bh=gw2zPlLac5sBf5f8EpTbuMbjUdDqEwgXD5tWTAbTEu8=; b=Ol+9KkbWRnAxp8alqZq/me2iFyXRHyMovvlO+0vaF6ixOBz7S+oLq543 Mc8xm/4kL0pYFCubbjOpgRrlJDeoUC+/d2bDKiHvWHKaZ1OiKNftcOJt3 XuGdH4u8jimAgYM9EYLOBl9v4kVSWLB1fJE5dM316SpIlKs1oY5J5PB/+ u8ISa4zzjF4hVR2vUkVUBUkHsI1jitVNOXJoWM64BA5F4wJCeqFOySJwW COoDpU+9xC9sld3fb3MrafBXZczG9DRIuGnsLenebpvSLtGogM22O5aYE GUT2I3EEWfe0sYlAfwhw1FMBjYShfUDWIltcG5tUaRlpPNm93jk0soFNn g==; X-CSE-ConnectionGUID: paVA6nvbQxqMAoMpp6FAxQ== X-CSE-MsgGUID: /shoCVEURriO5hqULFxeEg== X-IronPort-AV: E=McAfee;i="6700,10204,11426"; a="58702506" X-IronPort-AV: E=Sophos;i="6.15,272,1739865600"; d="scan'208";a="58702506" Received: from orviesa008.jf.intel.com ([10.64.159.148]) by orvoesa103.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 08 May 2025 06:48:38 -0700 X-CSE-ConnectionGUID: rwJWjqnOSMaEENfSLQPxLQ== X-CSE-MsgGUID: SOMKx/hYTyyAGbgXFiQg3w== X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="6.15,272,1739865600"; d="scan'208";a="137229373" Received: from ijarvine-mobl1.ger.corp.intel.com (HELO localhost) ([10.245.245.196]) by orviesa008-auth.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 08 May 2025 06:48:35 -0700 From: =?UTF-8?q?Ilpo=20J=C3=A4rvinen?= Date: Thu, 8 May 2025 16:48:31 +0300 (EEST) To: Hans de Goede cc: Andy Shevchenko , Andy Shevchenko , Sakari Ailus , platform-driver-x86@vger.kernel.org, Mauro Carvalho Chehab , linux-media@vger.kernel.org, linux-staging@lists.linux.dev Subject: Re: [PATCH 6/6] media: atomisp: Switch to int3472 driver sensor GPIO mapping code In-Reply-To: <6d5a5cc2-a7b1-4032-82cd-0250f345dca9@redhat.com> Message-ID: References: <20250507184737.154747-1-hdegoede@redhat.com> <20250507184737.154747-7-hdegoede@redhat.com> <6d5a5cc2-a7b1-4032-82cd-0250f345dca9@redhat.com> Precedence: bulk X-Mailing-List: linux-staging@lists.linux.dev List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: multipart/mixed; BOUNDARY="8323328-330200422-1746712030=:922" Content-ID: This message is in MIME format. The first part should be readable text, while the remaining parts are likely unreadable without MIME-aware tools. --8323328-330200422-1746712030=:922 Content-Type: text/plain; CHARSET=UTF-8 Content-Transfer-Encoding: QUOTED-PRINTABLE Content-ID: On Thu, 8 May 2025, Hans de Goede wrote: > On 8-May-25 10:34 AM, Andy Shevchenko wrote: > > On Wed, May 7, 2025 at 9:48=E2=80=AFPM Hans de Goede wrote: > >> > >> Replace the duplicate code for calling the special Intel camera sensor= GPIO > >> type _DSM (79234640-9e10-4fea-a5c1-b5aa8b19756f) and mapping GPIOs to > >> the sensor with a call to int3472_discrete_parse_crs() from the int347= 2 > >> driver. > >> > >> Besides avoiding code duplication the int3472 version of the code also > >> supports more features, like mapping the powerdown GPIO to a regulator= on > >> the mt9m114 which is necessary to make the camera on the Asus T100TA w= ork. > >=20 > > ... > >=20 > > Don't you need the Kconfig(s) update to have proper dependencies all > > over these cases? >=20 > Yes I do, I thought about doing this already but forgot to actually > do it, thank you for catching this. >=20 > When I've some time for it I'll prepare a v2 of just this patch > addressing this and your s/then/than/ remark. >=20 > Since you and Sakari are happy with them patches 1-5 can be picked up > and merged by Ilpo as is, so I do not plan to send a v2 of those. Thanks for the quick reviews. I took patch 1-5 into the review-ilpo-next branch with one typo in=20 change log fixed (reser -> reset). > > Otherwise I am fully in favour of this change and the series as a whole= , thanks! > >=20 > > ... > >=20 > >> + /* > >> + * On atomisp the _DSM to get the GPIO type must be made on th= e sensor > >> + * adev, rather then on a separate INT3472 adev. > >=20 > > rather than > >=20 > > (FWIW, it's your typical mistake, it's something like the 10th time I > > noticed it :-) >=20 > Yeah, I'll try to remember to double check for this spelling mistake > myself, but I'm afraid I'll probably never learn. We have something > somewhat similar to than vs then in Dutch and I even do it wrong there :) I know the feeling, muscle memory is extremely hard to override. :-) --=20 i. --8323328-330200422-1746712030=:922--