From: Dan Carpenter <dan.carpenter@linaro.org>
To: Donny Turizo <donnyturizo13@gmail.com>
Cc: gregkh@linuxfoundation.org, linux-staging@lists.linux.dev,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH v6] staging: rtl8723bs: rename _Read_EEPROM and other functions to snake_case
Date: Mon, 26 May 2025 11:03:15 +0300 [thread overview]
Message-ID: <aDQgQw9XZV_7BIf-@stanley.mountain> (raw)
In-Reply-To: <20250524173745.4907-1-donnyturizo13@gmail.com>
On Sat, May 24, 2025 at 05:37:45PM +0000, Donny Turizo wrote:
> Renamed _Read_EEPROM and several other functions in rtw_cmd.c to follow
> the kernel coding style (snake_case). This fixes checkpatch warnings
> related to naming conventions.
>
> Signed-off-by: Donny Turizo <donnyturizo13@gmail.com>
>
> ---
> v2: Initial patch rejected by the robot due to naming issues.
>
> v3: Rebased the patch onto GregKH's staging branch for better integration.
>
> v4: Changed the commit author to my name and renamed all remaining functions
> to snake_case following kernel coding style.
>
> v5: Renamed command _set_h2c_Lbk to _set_h2c_lbk to fix CamelCase issue.
>
> v6: Actually fixed the misspelled name that was incorrectly stated as
> fixed in v5.
Surely, this breaks the build? You're not working against staging-next
so it's difficult for me to apply this and actually check.
regards,
dan carpenter
prev parent reply other threads:[~2025-05-26 8:03 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-05-24 17:37 [PATCH v6] staging: rtl8723bs: rename _Read_EEPROM and other functions to snake_case Donny Turizo
2025-05-26 8:03 ` Dan Carpenter [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=aDQgQw9XZV_7BIf-@stanley.mountain \
--to=dan.carpenter@linaro.org \
--cc=donnyturizo13@gmail.com \
--cc=gregkh@linuxfoundation.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-staging@lists.linux.dev \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox