From: Dan Carpenter <dan.carpenter@linaro.org>
To: Shawn Hua <shawnhuasz@gmail.com>
Cc: linux-staging@lists.linux.dev, linux-kernel@vger.kernel.org,
gregkh@linuxfoundation.org, philipp.g.hortmann@gmail.com,
pkshih@realtek.com, akpm@linux-foundation.org,
yixuanhuashawn@berkeley.edu
Subject: Re: [PATCH] staging: rtl8723bs: fix checkpatch issues in rtw_pwrctrl.c
Date: Wed, 28 May 2025 13:08:40 +0300 [thread overview]
Message-ID: <aDbgqBKV-bIJXDjN@stanley.mountain> (raw)
In-Reply-To: <20250528091914.2963-1-yixuanhuashawn@berkeley.edu>
On Wed, May 28, 2025 at 05:19:14PM +0800, Shawn Hua wrote:
> This patch addresses several style issues in rtw_pwrctrl.c, as reported by checkpat
> ch.pl. I’ve fixed most warnings and errors, but left CamelCase and one type of CHECK unresolved.
>
> I’m new to kernel development and submitting this for learning purposes. Please let me know if this type of patch is still helpful, or if it should be reworked or dropped.
Emails and patches should line wrap at 74 characters.
>
> Best regards,
> Shawn Hua
> -----
Don't start your patch with an email, we don't want that in the git log.
> This patch fixes ~80 checkpatch.pl style issues, including spacing, indentation, and alignment.
>
> Remaining issues:
> - CamelCase warnings were left unchanged to avoid breaking interface consistency across related files.
> - One CHECK regarding alignment with open parenthesis could not be resolved despite several attempts.
Don't list the things you haven't done.
>
> No functional changes were made.
>
This does too many things at once. Also start with the latest code.
Some of these are already fixed.
regards,
dan carpenter
prev parent reply other threads:[~2025-05-28 10:08 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-05-28 9:19 [PATCH] staging: rtl8723bs: fix checkpatch issues in rtw_pwrctrl.c Shawn Hua
2025-05-28 10:08 ` Dan Carpenter [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=aDbgqBKV-bIJXDjN@stanley.mountain \
--to=dan.carpenter@linaro.org \
--cc=akpm@linux-foundation.org \
--cc=gregkh@linuxfoundation.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-staging@lists.linux.dev \
--cc=philipp.g.hortmann@gmail.com \
--cc=pkshih@realtek.com \
--cc=shawnhuasz@gmail.com \
--cc=yixuanhuashawn@berkeley.edu \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox