From: "Ignacio Peña" <ignacio.pena87@gmail.com>
To: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Cc: linux-staging@lists.linux.dev, linux-kernel@vger.kernel.org,
Dan Carpenter <dan.carpenter@linaro.org>
Subject: [PATCH v4] staging: sm750fb: make fixId array static const char * const
Date: Fri, 18 Jul 2025 17:08:46 -0400 [thread overview]
Message-ID: <aHq33vXh0F481FB-@MacBook-Pro-de-Ignacio.local> (raw)
Fix checkpatch warning for the fixId array only:
"WARNING: static const char * array should probably be
static const char * const"
The g_fbmode array cannot be made const as it is modified at runtime
in lynxfb_setup() and lynx_alloc().
Signed-off-by: Ignacio Peña <ignacio.pena87@gmail.com>
---
v4: Sorry for the confusion. Previous versions had wrong line numbers
or included changes to g_fbmode. This version ONLY changes fixId
at the correct line number (734) against current mainline.
v3: Apologies for the confusion. v2 accidentally included changes to
g_fbmode which breaks the build. This version ONLY changes fixId
which is never modified.
drivers/staging/sm750fb/sm750.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/staging/sm750fb/sm750.c b/drivers/staging/sm750fb/sm750.c
index 1d929aca3..82e01f114 100644
--- a/drivers/staging/sm750fb/sm750.c
+++ b/drivers/staging/sm750fb/sm750.c
@@ -734,7 +734,7 @@ static int lynxfb_set_fbinfo(struct fb_info *info, int index)
"kernel HELPERS prepared vesa_modes",
};
- static const char *fixId[2] = {
+ static const char * const fixId[2] = {
"sm750_fb1", "sm750_fb2",
};
--
2.39.5
next reply other threads:[~2025-07-18 21:08 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-07-18 21:08 Ignacio Peña [this message]
2025-07-18 21:17 ` [PATCH v4] staging: sm750fb: make fixId array static const char * const Dan Carpenter
2025-07-19 6:40 ` Greg Kroah-Hartman
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=aHq33vXh0F481FB-@MacBook-Pro-de-Ignacio.local \
--to=ignacio.pena87@gmail.com \
--cc=dan.carpenter@linaro.org \
--cc=gregkh@linuxfoundation.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-staging@lists.linux.dev \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).