Re: [PATCH 3/3] media: staging: imx: Drop custom .unsubscribe_event() handler

[Frank Li <Frank.li@nxp.com>]

On Sat, Aug 02, 2025 at 12:19:33AM +0300, Laurent Pinchart wrote:
> The csi_unsubscribe_event() function simply calls
> v4l2_event_unsubscribe(), forwarding its arguments. Replace it with the
> v4l2_event_subdev_unsubscribe() helper that performs exactly the same
> operation.
>
> Signed-off-by: Laurent Pinchart <laurent.pinchart@ideasonboard.com>
> ---

Reviewed-by: Frank Li <Frank.Li@nxp.com>

>  drivers/staging/media/imx/imx-media-csi.c | 8 +-------
>  1 file changed, 1 insertion(+), 7 deletions(-)
>
> diff --git a/drivers/staging/media/imx/imx-media-csi.c b/drivers/staging/media/imx/imx-media-csi.c
> index a7cd3ef95fc3..fd7e37d803e7 100644
> --- a/drivers/staging/media/imx/imx-media-csi.c
> +++ b/drivers/staging/media/imx/imx-media-csi.c
> @@ -1751,12 +1751,6 @@ static int csi_subscribe_event(struct v4l2_subdev *sd, struct v4l2_fh *fh,
>  	return v4l2_event_subscribe(fh, sub, 0, NULL);
>  }
>
> -static int csi_unsubscribe_event(struct v4l2_subdev *sd, struct v4l2_fh *fh,
> -				 struct v4l2_event_subscription *sub)
> -{
> -	return v4l2_event_unsubscribe(fh, sub);
> -}
> -
>  static int csi_registered(struct v4l2_subdev *sd)
>  {
>  	struct csi_priv *priv = v4l2_get_subdevdata(sd);
> @@ -1872,7 +1866,7 @@ static const struct media_entity_operations csi_entity_ops = {
>
>  static const struct v4l2_subdev_core_ops csi_core_ops = {
>  	.subscribe_event = csi_subscribe_event,
> -	.unsubscribe_event = csi_unsubscribe_event,
> +	.unsubscribe_event = v4l2_event_subdev_unsubscribe,
>  };
>
>  static const struct v4l2_subdev_video_ops csi_video_ops = {
> --
> Regards,
>
> Laurent Pinchart
>