From: Dan Carpenter <dan.carpenter@linaro.org>
To: Akiyoshi Kurita <weibu@redadmin.org>
Cc: Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
Philipp Hortmann <philipp.g.hortmann@gmail.com>,
linux-staging@lists.linux.dev, linux-kernel@vger.kernel.org
Subject: Re: [PATCH] staging: rtl8723bs: fix coding style in hal_com_phycfg.c
Date: Mon, 8 Sep 2025 18:24:08 +0300 [thread overview]
Message-ID: <aL71GP45JuzS2XMl@stanley.mountain> (raw)
In-Reply-To: <20250908144641.39518-1-weibu@redadmin.org>
On Mon, Sep 08, 2025 at 11:46:41PM +0900, Akiyoshi Kurita wrote:
> The function definition for phy_StoreTxPowerByRateBase() did not
> follow the kernel coding style.
>
> Move the closing parenthesis to the same line as the argument to fix
> the style issue reported by checkpatch.pl.
>
> Signed-off-by: Akiyoshi Kurita <weibu@redadmin.org>
> ---
There are so many other functions which are declared in exactly this
same format. Fix the others like this in the file as well in one patch.
regards,
dan carpenter
next prev parent reply other threads:[~2025-09-08 15:24 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-09-08 14:46 [PATCH] staging: rtl8723bs: fix coding style in hal_com_phycfg.c Akiyoshi Kurita
2025-09-08 15:24 ` Dan Carpenter [this message]
2025-09-12 13:45 ` Greg Kroah-Hartman
2025-09-12 16:26 ` [PATCH v2] staging: rtl8723bs: hal: put return type and function name on one line Akiyoshi Kurita
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=aL71GP45JuzS2XMl@stanley.mountain \
--to=dan.carpenter@linaro.org \
--cc=gregkh@linuxfoundation.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-staging@lists.linux.dev \
--cc=philipp.g.hortmann@gmail.com \
--cc=weibu@redadmin.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).