From: Dan Carpenter <dan.carpenter@linaro.org>
To: Soumya Ranjan Patnaik <soumyaranjan1812@gmail.com>
Cc: dpenkler@gmail.com, gregkh@linuxfoundation.org,
linux-staging@lists.linux.dev, linux-kernel@vger.kernel.org
Subject: Re: [PATCH] staging: gpib: enclose macro values in parentheses
Date: Fri, 19 Sep 2025 11:01:25 +0300 [thread overview]
Message-ID: <aM0N1aZYErdXsOAc@stanley.mountain> (raw)
In-Reply-To: <20250919070351.586981-1-soumyaranjan1812@gmail.com>
On Fri, Sep 19, 2025 at 12:33:48PM +0530, Soumya Ranjan Patnaik wrote:
> Macros with complex values should be enclosed in parentheses to avoid
> unexpected behavior due to operator precedence or macro expansion issues.
> This change wraps the LINVAL macro values in parentheses to comply with
> kernel coding style and improve code safety.
>
> Signed-off-by: Soumya Ranjan Patnaik <soumyaranjan1812@gmail.com>
That's going to break the build.
https://lore.kernel.org/all/?q=LINVAL
regards,
dan carpenter
prev parent reply other threads:[~2025-09-19 8:01 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-09-19 7:03 [PATCH] staging: gpib: enclose macro values in parentheses Soumya Ranjan Patnaik
2025-09-19 8:01 ` Dan Carpenter [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=aM0N1aZYErdXsOAc@stanley.mountain \
--to=dan.carpenter@linaro.org \
--cc=dpenkler@gmail.com \
--cc=gregkh@linuxfoundation.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-staging@lists.linux.dev \
--cc=soumyaranjan1812@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).