From: Dan Carpenter <dan.carpenter@linaro.org>
To: Rohan Tripathi <trohan2000@gmail.com>
Cc: gregkh@linuxfoundation.org, linux-staging@lists.linux.dev,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH 3/4] staging: rtl8723bs: remove unnecessary blank lines in rtw_ap.c
Date: Mon, 6 Oct 2025 10:30:38 +0300 [thread overview]
Message-ID: <aONwHi09P9VDTd3G@stanley.mountain> (raw)
In-Reply-To: <20251005155920.381334-4-trohan2000@gmail.com>
On Sun, Oct 05, 2025 at 11:59:19AM -0400, Rohan Tripathi wrote:
> This patch removes superfluous blank lines and adds missing ones where
> appropriate to improve readability and match kernel coding style.
>
> This is a coding style cleanup only. No functional changes.
>
> Signed-off-by: Rohan Tripathi <trohan2000@gmail.com>
> ---
> drivers/staging/rtl8723bs/core/rtw_ap.c | 3 +--
> 1 file changed, 1 insertion(+), 2 deletions(-)
>
> diff --git a/drivers/staging/rtl8723bs/core/rtw_ap.c b/drivers/staging/rtl8723bs/core/rtw_ap.c
> index 2c906c1137bf..dddb02c0f683 100644
> --- a/drivers/staging/rtl8723bs/core/rtw_ap.c
> +++ b/drivers/staging/rtl8723bs/core/rtw_ap.c
> @@ -438,7 +438,6 @@ void update_bmc_sta(struct adapter *padapter)
> spin_lock_bh(&psta->lock);
> psta->state = _FW_LINKED;
> spin_unlock_bh(&psta->lock);
> -
> }
> }
>
> @@ -1240,7 +1239,6 @@ void rtw_acl_remove_sta(struct adapter *padapter, u8 *addr)
> }
>
> spin_unlock_bh(&pacl_node_q->lock);
> -
> }
>
> u8 rtw_ap_set_pairwise_key(struct adapter *padapter, struct sta_info *psta)
> @@ -1974,6 +1972,7 @@ void ap_sta_info_defer_update(struct adapter *padapter, struct sta_info *psta)
> add_RATid(padapter, psta, 0);/* DM_RATR_STA_INIT */
> }
> }
> +
This is adding a blank line, not removing.
regards,
dan carpenter
> /* restore hw setting from sw data structures */
> void rtw_ap_restore_network(struct adapter *padapter)
> {
> --
> 2.50.1
>
next prev parent reply other threads:[~2025-10-06 7:30 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-10-05 15:59 [PATCH 1/4] staging: rtl8723bs: clean up lines ending with '(' in rtw_ap.c Rohan Tripathi
2025-10-05 15:59 ` [PATCH] staging: rtl8723bs: clean up style " Rohan Tripathi
2025-10-06 7:29 ` Dan Carpenter
2025-10-05 15:59 ` [PATCH 2/4] staging: rtl8723bs: split long comments " Rohan Tripathi
2025-10-06 7:30 ` Dan Carpenter
2025-10-05 15:59 ` [PATCH 3/4] staging: rtl8723bs: remove unnecessary blank lines " Rohan Tripathi
2025-10-06 7:30 ` Dan Carpenter [this message]
2025-10-05 15:59 ` [PATCH 4/4] staging: rtl8723bs: fix operator spacing " Rohan Tripathi
2025-10-06 7:26 ` [PATCH 1/4] staging: rtl8723bs: clean up lines ending with '(' " Dan Carpenter
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=aONwHi09P9VDTd3G@stanley.mountain \
--to=dan.carpenter@linaro.org \
--cc=gregkh@linuxfoundation.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-staging@lists.linux.dev \
--cc=trohan2000@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).