From: Dan Carpenter <dan.carpenter@linaro.org>
To: Dharanitharan R <dharanitharan725@gmail.com>
Cc: gregkh@linuxfoundation.org, linux-staging@lists.linux.dev,
dharanitharan27 <dharanitharanr05@gmail.com>
Subject: Re: [PATCH v3] [PATCH v2] staging: rtl8723bs: use ether_addr_copy() and simplify NULL checks
Date: Wed, 22 Oct 2025 10:12:52 +0300 [thread overview]
Message-ID: <aPiD9BF9RxhcJiPM@stanley.mountain> (raw)
In-Reply-To: <20251022062304.4061-1-dharanitharan725@gmail.com>
Subject is has "[PATCH v3] [PATCH v2]"
On Wed, Oct 22, 2025 at 06:23:04AM +0000, Dharanitharan R wrote:
> From: dharanitharan27 <dharanitharanr05@gmail.com>
^^^^^^^^^^^^^^^
Wrong email address.
>
> This patch addresses multiple checkpatch warnings and coding-style issues
> in rtl8723bs:
>
> - Lines 120, 212, 215, 249, 255, 256, 261, 262, 263: Replaced
> memcpy() with ether_addr_copy() for MAC/Ether address copies,
> following kernel best practices.
We don't really care about the line numbers... Remove that from
the commit message.
>
> These changes improve code clarity, align with Linux kernel style
> guidelines, and fix checkpatch.pl warnings.
>
> ---
^^^
Anything below this line will be removed from the final commit message
so the Signed-off-by needs to be above it.
> Tested by compiling the module successfully with:
> make M=drivers/staging/rtl8723bs
>
> Signed-off-by: Dharanitharan R <dharanitharan725@gmail.com>
> ---
We need a list of changes here under the --- cut off.
v4: fix subject, and from email address tweak the commit message
v3: something
v2: whatever
regards,
dan carpenter
prev parent reply other threads:[~2025-10-22 7:12 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-10-22 6:23 [PATCH v3] [PATCH v2] staging: rtl8723bs: use ether_addr_copy() and simplify NULL checks Dharanitharan R
2025-10-22 7:12 ` Dan Carpenter [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=aPiD9BF9RxhcJiPM@stanley.mountain \
--to=dan.carpenter@linaro.org \
--cc=dharanitharan725@gmail.com \
--cc=dharanitharanr05@gmail.com \
--cc=gregkh@linuxfoundation.org \
--cc=linux-staging@lists.linux.dev \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).