Re: [PATCH v2 0/5] staging: rtl8723bs: FIELD_OFFSET macro cleanup

Dan Carpenter
2025-11-25T12:10:25Z

On Tue, Nov 25, 2025 at 11:20:54AM +0000, Navaneeth K wrote:
> This series cleans up the rtl8723bs driver by removing the custom
> FIELD_OFFSET macro and replacing its usages with the standard offsetof()
> from <linux/stddef.h>.
>
> Changes in v2:
> - Split the series for proper bisectability: the FIELD_OFFSET macro
> definition is now removed in Patch 5 (after all usages are converted),
> rather than in Patch 1.
> - Patch 1: Now only removes unused RGTRY_OFT, RGTRY_SZ, BSSID_OFT, and
> BSSID_SZ macros (dead code not used anywhere in the driver).
> - Patch 2: Split long line to fit within 100 columns. Also added
> <linux/stddef.h> include to basic_types.h to support offsetof usage.
> - Patch 3: Fixed brace formatting issue caused by removing commented
> code. Removed unnecessary outer parentheses, moved the inline
> comment to its own line, and added braces to the else branch for
> consistent style.
> - Patch 5 (NEW): Remove FIELD_OFFSET definition now that it's unused.
>

Thanks!

Reviewed-by: Dan Carpenter <dan.carpenter@linaro.org>

regards,
dan carpenter