[PATCH v2 0/5] staging: rtl8723bs: FIELD_OFFSET macro cleanup

Navaneeth K
2025-11-25T11:21:10Z

This series cleans up the rtl8723bs driver by removing the custom
FIELD_OFFSET macro and replacing its usages with the standard offsetof()
from <linux/stddef.h>.

Changes in v2:
- Split the series for proper bisectability: the FIELD_OFFSET macro
definition is now removed in Patch 5 (after all usages are converted),
rather than in Patch 1.
- Patch 1: Now only removes unused RGTRY_OFT, RGTRY_SZ, BSSID_OFT, and
BSSID_SZ macros (dead code not used anywhere in the driver).
- Patch 2: Split long line to fit within 100 columns. Also added
<linux/stddef.h> include to basic_types.h to support offsetof usage.
- Patch 3: Fixed brace formatting issue caused by removing commented
code. Removed unnecessary outer parentheses, moved the inline
comment to its own line, and added braces to the else branch for
consistent style.
- Patch 5 (NEW): Remove FIELD_OFFSET definition now that it's unused.

Navaneeth K (5):
staging: rtl8723bs: remove unused registry and BSSID offset macros
staging: rtl8723bs: use standard offsetof in cfg80211 operations
staging: rtl8723bs: remove dead commented code from odm.c
staging: rtl8723bs: replace FIELD_OFFSET usage with offsetof in
rtw_mlme_ext.c
staging: rtl8723bs: remove custom FIELD_OFFSET macro

drivers/staging/rtl8723bs/core/rtw_mlme_ext.c | 4 ++--
drivers/staging/rtl8723bs/hal/odm.c | 13 +++++--------
drivers/staging/rtl8723bs/include/basic_types.h | 3 +--
drivers/staging/rtl8723bs/include/drv_types.h | 7 -------
drivers/staging/rtl8723bs/os_dep/ioctl_cfg80211.c | 3 ++-
5 files changed, 10 insertions(+), 20 deletions(-)

--
2.43.0