public inbox for linux-staging@lists.linux.dev
 help / color / mirror / Atom feed
From: Dan Carpenter <dan.carpenter@linaro.org>
To: Randy Dunlap <rdunlap@infradead.org>
Cc: linux-kernel@vger.kernel.org,
	Vaibhav Hiremath <hvaibhav.linux@gmail.com>,
	Johan Hovold <johan@kernel.org>, Alex Elder <elder@kernel.org>,
	Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
	greybus-dev@lists.linaro.org, linux-staging@lists.linux.dev
Subject: Re: [PATCH] staging: greybus: arche: drop dangling Kconfig symbol
Date: Mon, 5 Jan 2026 13:16:41 +0300	[thread overview]
Message-ID: <aVuPidYUPZxCOdRp@stanley.mountain> (raw)
In-Reply-To: <aVuNzWb3TEj74t2M@stanley.mountain>

On Mon, Jan 05, 2026 at 01:09:17PM +0300, Dan Carpenter wrote:
> On Tue, Dec 30, 2025 at 10:23:40AM -0800, Randy Dunlap wrote:
> > 
> > 
> > On 12/29/25 10:27 PM, Randy Dunlap wrote:
> > > --- linux-next-20251219.orig/drivers/staging/greybus/Kconfig
> > > +++ linux-next-20251219/drivers/staging/greybus/Kconfig
> > > @@ -206,7 +206,6 @@ endif	# GREYBUS_BRIDGED_PHY
> > >  
> > >  config GREYBUS_ARCHE
> > >  	tristate "Greybus Arche Platform driver"
> > > -	depends on USB_HSIC_USB3613 || COMPILE_TEST
> > >  	help
> > >  	  Select this option if you have an Arche device.
> > 
> > Perhaps I should have left COMPILE_TEST here, like:
> > 
> > 	depends on COMPILE_TEST
> > 
> > ?
> 
> If we're going to do that, we should just delete it.  It's been
> impossible to build for eight years.
> 

I did a `git grep 'depends on COMPILE_TEST'` for other drivers which
are never used and only found this one which was disabled in 2018.

regards,
dan carpenter

commit da2827a298f8a2159f31466759cbba2dd4f1b65f
Author: Arnd Bergmann <arnd@arndb.de>
Date:   Fri Mar 9 22:45:26 2018 +0100

    usb: isp1362: remove blackfin arch glue

    The blackfin architecture is getting removed, and this is the last
    remaining architecture specific setting, so the various hacks
    can be removed now.

    From all I can tell, there are no remaining in-tree users of the
    driver, but it could be used by out-of-tree platform ports.
    I've marked the driver as 'depends on COMPILE_TEST', short of
    removing it outright.

    It was originally written for some ARM PXA machines using the same
    chip, but that platform never really worked and the code has been
    removed a long time ago.

    Acked-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
    Acked-by: Aaron Wu <aaron.wu@analog.com>
    Signed-off-by: Arnd Bergmann <arnd@arndb.de>

diff --git a/drivers/usb/host/Kconfig b/drivers/usb/host/Kconfig
index 4fcfb3084b36..b85822f0c874 100644
--- a/drivers/usb/host/Kconfig
+++ b/drivers/usb/host/Kconfig
@@ -360,6 +360,7 @@ config USB_ISP116X_HCD
 config USB_ISP1362_HCD
        tristate "ISP1362 HCD support"
        depends on HAS_IOMEM
+       depends on COMPILE_TEST # nothing uses this
        ---help---
          Supports the Philips ISP1362 chip as a host controller


  reply	other threads:[~2026-01-05 10:16 UTC|newest]

Thread overview: 10+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2025-12-30  6:27 [PATCH] staging: greybus: arche: drop dangling Kconfig symbol Randy Dunlap
2025-12-30 18:23 ` Randy Dunlap
2026-01-05 10:09   ` Dan Carpenter
2026-01-05 10:16     ` Dan Carpenter [this message]
2026-01-05 23:54       ` Randy Dunlap
2026-01-06  3:16     ` Randy Dunlap
2026-01-14  9:21 ` Johan Hovold
2026-01-15  0:28   ` Randy Dunlap
2026-01-16 10:48     ` Johan Hovold
2026-01-17  5:40       ` Randy Dunlap

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=aVuPidYUPZxCOdRp@stanley.mountain \
    --to=dan.carpenter@linaro.org \
    --cc=elder@kernel.org \
    --cc=gregkh@linuxfoundation.org \
    --cc=greybus-dev@lists.linaro.org \
    --cc=hvaibhav.linux@gmail.com \
    --cc=johan@kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-staging@lists.linux.dev \
    --cc=rdunlap@infradead.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox