From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mgamail.intel.com (mgamail.intel.com [192.198.163.14]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 331E433A037 for ; Mon, 5 Jan 2026 16:32:14 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=192.198.163.14 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1767630736; cv=none; b=aYdrCq+8sboh3m5LKGVOSx1zTHoqZZBgaJzp/BdVPEmQIIh8rO9uFNlSCdvWFNGdvyNS2VOIYyrDjv/yYsOe1NUmJOjOoWrIegcbrQmsi0J7oP44cFQeB+y+XxYwRjC3AE+Cn6y+fv+4Ku3WaMuQJ2wJodI3gqxFAO3c5HbnLgU= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1767630736; c=relaxed/simple; bh=5ZiNycg6DBG7o/Fpvg7Up0Z7xdzF9rwnLfDxSU9euUw=; h=Date:From:To:Cc:Subject:Message-ID:References:MIME-Version: Content-Type:Content-Disposition:In-Reply-To; b=RbqeOW2g7MgdkzU0Tj+pJe0WouwgWn/DzCKmPUjdKyZKrGoMn/EgcPVSSpzy51/ICv1CqkaaTb7mxc2LJ+Km7bNn4jz8M0Rat6kvJeEnysofK+hkeInsc4VmJdfy02cqJghkMa9dtBSyfz5P3t+FXEitbaFOuSIUx4IO9KC7QbQ= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=intel.com; spf=pass smtp.mailfrom=intel.com; dkim=pass (2048-bit key) header.d=intel.com header.i=@intel.com header.b=SOd5dH8P; arc=none smtp.client-ip=192.198.163.14 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=intel.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=intel.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=intel.com header.i=@intel.com header.b="SOd5dH8P" DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=intel.com; i=@intel.com; q=dns/txt; s=Intel; t=1767630735; x=1799166735; h=date:from:to:cc:subject:message-id:references: mime-version:in-reply-to; bh=5ZiNycg6DBG7o/Fpvg7Up0Z7xdzF9rwnLfDxSU9euUw=; b=SOd5dH8Pnz1rRgbllJOR5Umq/HKQoQe7sGmLfvX720gdog2Vmtzv2hd1 L4ypvo5YPZYbAQhoWyuLoaw2aMIVPGolkWrAJ1WdUqcHSjS81AFt11BYG pp0pAzk6h50jzsE8ts97zbO4Cvt5rd/zJ+RwrF1/nNOFozP1C5UOoy0l3 ZqGGcyVqf4eyl+/RIEII+gn6SeMPC8cuG4zw79Z7lg+7UUXfYgNevA7ru 2iK7NNBI28O07Dmm+T+m2CxMVMIvOAgoU9uKswFCJisYc4Vdo+daEsvec tWRnIeVfhmR5qjEyR7/a3Eyvm7WQQLEwpAO3uxenxJb12ktnjXvU1azgI A==; X-CSE-ConnectionGUID: 9Psl3K9NTWaNwbI4CZdvWw== X-CSE-MsgGUID: pNnA8QsRRbiHgdgt1oKWUA== X-IronPort-AV: E=McAfee;i="6800,10657,11662"; a="69039882" X-IronPort-AV: E=Sophos;i="6.21,203,1763452800"; d="scan'208";a="69039882" Received: from fmviesa004.fm.intel.com ([10.60.135.144]) by fmvoesa108.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 05 Jan 2026 08:32:14 -0800 X-CSE-ConnectionGUID: mKZ6hEztR5qT/3e+FUdNww== X-CSE-MsgGUID: tIsplbadRbih6N9+smZ/iw== X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="6.21,203,1763452800"; d="scan'208";a="207312383" Received: from klitkey1-mobl1.ger.corp.intel.com (HELO localhost) ([10.245.244.215]) by fmviesa004-auth.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 05 Jan 2026 08:32:12 -0800 Date: Mon, 5 Jan 2026 18:32:10 +0200 From: Andy Shevchenko To: Sun Jian Cc: Andy Shevchenko , Greg Kroah-Hartman , linux-staging@lists.linux.dev, linux-fbdev@vger.kernel.org, dri-devel@lists.freedesktop.org Subject: Re: [PATCH v1 0/4] staging: fbtft: reduce stack usage by avoiding large write_reg() varargs Message-ID: References: <20260104110638.532615-1-sun.jian.kdev@gmail.com> Precedence: bulk X-Mailing-List: linux-staging@lists.linux.dev List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20260104110638.532615-1-sun.jian.kdev@gmail.com> Organization: Intel Finland Oy - BIC 0357606-4 - c/o Alberga Business Park, 6 krs, Bertel Jungin Aukio 5, 02600 Espoo On Sun, Jan 04, 2026 at 07:06:34PM +0800, Sun Jian wrote: > This series fixes clang `-Wframe-larger-than=1024` warnings in the fbtft > staging drivers. > > The warnings are triggered by very large `write_reg()`/`write_register()` > varargs calls, which result in excessive stack usage. > > Switch the affected paths to send a u8 command byte followed by the u8 > payload using `fbtft_write_buf_dc()`. The register values and ordering are > kept unchanged; only the transfer method is updated. Looking at the patches I think this is wrong. W.o. detailed test pattern provided and the list of the devices, NAK. If you want to address a warning without HW being accessible, perhaps you just need a simple bump in the Makefile as an exception, however it's also doubtful as it will hide a potential issue with the stack in the future. -- With Best Regards, Andy Shevchenko