From: Johan Hovold <johan@kernel.org>
To: Archit Anant <architanant5@gmail.com>
Cc: vireshk@kernel.org, elder@kernel.org, gregkh@linuxfoundation.org,
greybus-dev@lists.linaro.org, linux-staging@lists.linux.dev,
linux-kernel@vger.kernel.org,
Julia Lawall <Julia.Lawall@inria.fr>
Subject: Re: [PATCH 1/1] staging: greybus: fw-core: use %pe for error printing
Date: Mon, 19 Jan 2026 11:25:11 +0100 [thread overview]
Message-ID: <aW4Ghy94jAGSPml3@hovoldconsulting.com> (raw)
In-Reply-To: <20260118060548.24548-2-architanant5@gmail.com>
[ +CC: Julia ]
On Sun, Jan 18, 2026 at 11:35:48AM +0530, Archit Anant wrote:
> Use the %pe printk format specifier to print error codes as symbolic
> names (e.g., -ENOMEM) instead of numeric values. This improves
> readability of error logs.
Greybus and this driver uses numerical errnos in its error messages so
this will introduce a needless inconsistency for no good reason.
> Issue identified by coccicheck using the ptr_err_to_pe.cocci script.
Also see:
https://lore.kernel.org/all/20251029132922.17329-1-johan@kernel.org/
Johan
prev parent reply other threads:[~2026-01-19 10:25 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-01-18 6:05 [PATCH 0/1] staging: greybus: fw-core: use %pe for error printing Archit Anant
2026-01-18 6:05 ` [PATCH 1/1] " Archit Anant
2026-01-19 10:25 ` Johan Hovold [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=aW4Ghy94jAGSPml3@hovoldconsulting.com \
--to=johan@kernel.org \
--cc=Julia.Lawall@inria.fr \
--cc=architanant5@gmail.com \
--cc=elder@kernel.org \
--cc=gregkh@linuxfoundation.org \
--cc=greybus-dev@lists.linaro.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-staging@lists.linux.dev \
--cc=vireshk@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox