From: Dan Carpenter <dan.carpenter@linaro.org>
To: Khushal Chitturi <khushalchitturi@gmail.com>
Cc: Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
Michael Straube <straube.linux@gmail.com>,
Hans de Goede <hansg@kernel.org>,
linux-staging@lists.linux.dev, linux-kernel@vger.kernel.org
Subject: Re: [PATCH 5/9] staging: rtl8723bs: split chained assignments
Date: Mon, 12 Jan 2026 11:01:15 +0300 [thread overview]
Message-ID: <aWSqS9fRMZXX8qsV@stanley.mountain> (raw)
In-Reply-To: <20260111183630.12816-6-khushalchitturi@gmail.com>
On Mon, Jan 12, 2026 at 12:06:26AM +0530, Khushal Chitturi wrote:
> @@ -1155,11 +1158,13 @@ s32 rtw_mgmt_xmitframe_coalesce(struct adapter *padapter, struct sk_buff *pkt, s
> u8 MME[_MME_IE_LENGTH_];
> u32 ori_len;
>
> - mem_start = pframe = (u8 *)(pxmitframe->buf_addr) + TXDESC_OFFSET;
> + mem_start = (u8 *)(pxmitframe->buf_addr) + TXDESC_OFFSET;
> + pframe = (u8 *)(pxmitframe->buf_addr) + TXDESC_OFFSET;
> pwlanhdr = (struct ieee80211_hdr *)pframe;
>
> ori_len = BIP_AAD_SIZE + pattrib->pktlen;
> - tmp_buf = BIP_AAD = rtw_zmalloc(ori_len);
> + tmp_buf = rtw_zmalloc(ori_len);
> + BIP_AAD = rtw_zmalloc(ori_len);
Nope. We don't want two allocations.
regards,
dan carpenter
next prev parent reply other threads:[~2026-01-12 8:01 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-01-11 18:36 [PATCH 0/9] staging: rtl8723bs: coding style and refactoring cleanups Khushal Chitturi
2026-01-11 18:36 ` [PATCH 1/9] staging: rtl8723bs: fix operator and type cast spacing Khushal Chitturi
2026-01-11 18:36 ` [PATCH 2/9] staging: rtl8723bs: remove empty branches Khushal Chitturi
2026-01-12 8:02 ` Dan Carpenter
2026-01-11 18:36 ` [PATCH 3/9] staging: rtl8723bs: simplify boolean expressions Khushal Chitturi
2026-01-12 8:18 ` Dan Carpenter
2026-01-11 18:36 ` [PATCH 4/9] staging: rtl8723bs: replace msleep with usleep_range in rtw_xmit.c Khushal Chitturi
2026-01-11 18:36 ` [PATCH 5/9] staging: rtl8723bs: split chained assignments Khushal Chitturi
2026-01-12 8:01 ` Dan Carpenter [this message]
2026-01-11 18:36 ` [PATCH 6/9] staging: rtl8723bs: rename struct members to snake_case Khushal Chitturi
2026-01-11 18:36 ` [PATCH 7/9] staging: rtl8723bs: rename local variables " Khushal Chitturi
2026-01-11 18:36 ` [PATCH 8/9] staging: rtl8723bs: replace N_BYTE_ALIGMENT with PTR_ALIGN Khushal Chitturi
2026-01-11 18:36 ` [PATCH 9/9] staging: rtl8723bs: fix line length and alignment issues Khushal Chitturi
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=aWSqS9fRMZXX8qsV@stanley.mountain \
--to=dan.carpenter@linaro.org \
--cc=gregkh@linuxfoundation.org \
--cc=hansg@kernel.org \
--cc=khushalchitturi@gmail.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-staging@lists.linux.dev \
--cc=straube.linux@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox