From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mgamail.intel.com (mgamail.intel.com [192.198.163.11]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 104B3313555 for ; Mon, 12 Jan 2026 19:14:36 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=192.198.163.11 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1768245278; cv=none; b=qBOYBZJLm8xwg7Cmqibl4WVBdjATAyBt+5ELFLKNgvLqbjphqplVJJW40W5zTjsX461vdBecyioEuqLPCXWuP9IKi6SiMFan2PYgWJhjvQVqS/KFxVYDr/Jhb5GVzx3bZBBN/FtSe5d+cgn+yhnkvNELneF7a3dVcluI6V1RTOE= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1768245278; c=relaxed/simple; bh=wYfDdLx/4JSmg6tJY61YxZ4KT957t04ctEuzTLzPXRU=; h=Date:From:To:Cc:Subject:Message-ID:References:MIME-Version: Content-Type:Content-Disposition:In-Reply-To; b=gMdM3/nm8uYVs9/9zdP9uZ1jfEwY0zuKyAsmBB+4+iEJcsM44wifoJ/lT/ynw4jj8/GQ4BKhk872v+EkCjztJ2n4hscINPNEM1rEKRExPOQ7+M/zb1+r6Z3yrVaxoNijNKjKqGLKotRf8bi9J/mDUzS7MjSSH4PHIDiTeEt16iU= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=intel.com; spf=pass smtp.mailfrom=intel.com; dkim=pass (2048-bit key) header.d=intel.com header.i=@intel.com header.b=A6H8xOmN; arc=none smtp.client-ip=192.198.163.11 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=intel.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=intel.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=intel.com header.i=@intel.com header.b="A6H8xOmN" DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=intel.com; i=@intel.com; q=dns/txt; s=Intel; t=1768245277; x=1799781277; h=date:from:to:cc:subject:message-id:references: mime-version:in-reply-to; bh=wYfDdLx/4JSmg6tJY61YxZ4KT957t04ctEuzTLzPXRU=; b=A6H8xOmNJlJ9o37qa7RwF1zM1bXjDkHdd4pSWYE7695BXN0+KRy1R5NV X+tMs3H4z4gl5vgFmOTmqgx85RBd0ZXF/qHgiL4ICV7QcK/Pje44hVYPa h/G+7tdzpsMmkz/Xbie2VWe90lVnIHcFiOpgVzd6S313Io8zFf09aCsgO oJ27QiyfMmuezmpl15OtDBn7NSUB2/HwoI5E79OTmkX3GO1pWhruCkn4D pmigIGpKwf0c0UeNj+a2pLuBLHpy6nZNzC7arVIXVGBEXNTEe5IfHKRmo EYriQjSwingd0xs4RQwBIyubEVqZfAvlUuj4cPOUxDkc1RJ/0Rs5Q6OJH A==; X-CSE-ConnectionGUID: cJdJV27YRs+9AY/19wbDzg== X-CSE-MsgGUID: FEiB+7slRsG/vXRjAn5RPw== X-IronPort-AV: E=McAfee;i="6800,10657,11669"; a="80167992" X-IronPort-AV: E=Sophos;i="6.21,221,1763452800"; d="scan'208";a="80167992" Received: from orviesa002.jf.intel.com ([10.64.159.142]) by fmvoesa105.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 12 Jan 2026 11:14:36 -0800 X-CSE-ConnectionGUID: JNf8IDcOTO+J7fuiKp1NOw== X-CSE-MsgGUID: /zsTxTl/TfaY+JjOeFViDg== X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="6.21,221,1763452800"; d="scan'208";a="234877873" Received: from dhhellew-desk2.ger.corp.intel.com (HELO localhost) ([10.245.245.37]) by orviesa002-auth.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 12 Jan 2026 11:14:34 -0800 Date: Mon, 12 Jan 2026 21:14:31 +0200 From: Andy Shevchenko To: Anubhav Kokane Cc: hansg@kernel.org, mchehab@kernel.org, andy@kernel.org, sakari.ailus@linux.intel.com, gregkh@linuxfoundation.org, linux-media@vger.kernel.org, linux-staging@lists.linux.dev, linux-kernel@vger.kernel.org Subject: Re: [PATCH] staging: media: atomisp: refactor sizeof(struct type) to sizeof(*ptr) Message-ID: References: <20260112190054.9828-1-dev.anubhavk@gmail.com> Precedence: bulk X-Mailing-List: linux-staging@lists.linux.dev List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20260112190054.9828-1-dev.anubhavk@gmail.com> Organization: Intel Finland Oy - BIC 0357606-4 - c/o Alberga Business Park, 6 krs, Bertel Jungin Aukio 5, 02600 Espoo On Mon, Jan 12, 2026 at 07:00:53PM +0000, Anubhav Kokane wrote: > Use the variable name in sizeof() operator instead of the struct type. > This prevents errors if the type of the variable is changed in future. > > This fixes checkpatch checks: > "CHECK: Prefer kzalloc(sizeof(*ptr)...) over > kzalloc(sizeof(struct type)...)" Yeah, but in all cases the whole buffers are less than a page and hence instead of doing that the preferred way is to switch to use kcalloc() in all three places. So you should have something like x = kcalloc(count, sizeof(*...), ...); if (!x) ...handle error... while (count--) { ... } ... err: list_for_each... { ... } kfree(x); -- With Best Regards, Andy Shevchenko