From: Dan Carpenter <dan.carpenter@linaro.org>
To: Ethan Tidmore <ethantidmore06@gmail.com>
Cc: Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
linux-staging@lists.linux.dev, linux-kernel@vger.kernel.org
Subject: Re: [PATCH v4] staging: rtl8723bs: remove unused private debug counters
Date: Sat, 31 Jan 2026 16:02:16 +0300 [thread overview]
Message-ID: <aX39WL7lOb09D_Qk@stanley.mountain> (raw)
In-Reply-To: <20260130204051.4237-1-ethantidmore06@gmail.com>
On Fri, Jan 30, 2026 at 02:40:51PM -0600, Ethan Tidmore wrote:
> -void rtw_hal_check_rxfifo_full(struct adapter *adapter)
> -{
> - struct dvobj_priv *psdpriv = adapter->dvobj;
> - struct debug_priv *pdbgpriv = &psdpriv->drv_dbg;
> - int save_cnt = false;
> -
> - /* switch counter to RX fifo */
> - rtw_write8(adapter, REG_RXERR_RPT+3, rtw_read8(adapter, REG_RXERR_RPT+3)|0xf0);
^^^^^^^^^^
You can't delete this.
> - save_cnt = true;
> - /* todo: other chips */
> -
> - if (save_cnt) {
> - /* rtw_write8(adapter, REG_RXERR_RPT+3, rtw_read8(adapter, REG_RXERR_RPT+3)|0xa0); */
> - pdbgpriv->dbg_rx_fifo_last_overflow = pdbgpriv->dbg_rx_fifo_curr_overflow;
> - pdbgpriv->dbg_rx_fifo_curr_overflow = rtw_read16(adapter, REG_RXERR_RPT);
> - pdbgpriv->dbg_rx_fifo_diff_overflow = pdbgpriv->dbg_rx_fifo_curr_overflow-pdbgpriv->dbg_rx_fifo_last_overflow;
> - }
> -}
> -
> static u32 Array_kfreemap[] = {
> 0xf8, 0xe,
> 0xf6, 0xc,
> diff --git a/drivers/staging/rtl8723bs/hal/rtl8723b_dm.c b/drivers/staging/rtl8723bs/hal/rtl8723b_dm.c
> index 928226679ab4..e4d1b54607c8 100644
> --- a/drivers/staging/rtl8723bs/hal/rtl8723b_dm.c
> +++ b/drivers/staging/rtl8723bs/hal/rtl8723b_dm.c
> @@ -124,7 +124,6 @@ void rtl8723b_InitHalDm(struct adapter *Adapter)
>
> void rtl8723b_HalDmWatchDog(struct adapter *Adapter)
> {
> - bool fw_current_in_ps_mode = false;
> bool bFwPSAwake = true;
> u8 hw_init_completed = false;
> struct hal_com_data *pHalData = GET_HAL_DATA(Adapter);
> @@ -134,16 +133,8 @@ void rtl8723b_HalDmWatchDog(struct adapter *Adapter)
> if (hw_init_completed == false)
> goto skip_dm;
>
> - fw_current_in_ps_mode = adapter_to_pwrctl(Adapter)->fw_current_in_ps_mode;
Which means don't delete this either.
regards,
dan carpenter
> rtw_hal_get_hwreg(Adapter, HW_VAR_FWLPS_RF_ON, (u8 *)(&bFwPSAwake));
>
> - if (
> - (hw_init_completed == true) &&
> - ((!fw_current_in_ps_mode) && bFwPSAwake)
> - ) {
> - rtw_hal_check_rxfifo_full(Adapter);
> - }
> -
> /* ODM */
> if (hw_init_completed == true) {
> u8 bLinked = false;
prev parent reply other threads:[~2026-01-31 13:02 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-01-30 20:40 [PATCH v4] staging: rtl8723bs: remove unused private debug counters Ethan Tidmore
2026-01-31 13:02 ` Dan Carpenter [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=aX39WL7lOb09D_Qk@stanley.mountain \
--to=dan.carpenter@linaro.org \
--cc=ethantidmore06@gmail.com \
--cc=gregkh@linuxfoundation.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-staging@lists.linux.dev \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox