Linux kernel staging patches
 help / color / mirror / Atom feed
From: Dan Carpenter <dan.carpenter@linaro.org>
To: Gustavo Piaz da Silva <gustavopiazdasilva2102@gmail.com>
Cc: gregkh@linuxfoundation.org, ovidiu.panait.oss@gmail.com,
	gshahrouzi@gmail.com, linux-staging@lists.linux.dev,
	linux-kernel@vger.kernel.org
Subject: Re: [PATCH v2] staging: axis-fifo: refactor device tree parsing
Date: Sat, 31 Jan 2026 20:41:48 +0300	[thread overview]
Message-ID: <aX4-3KP0BqHqaiO4@stanley.mountain> (raw)
In-Reply-To: <20260131155630.41587-1-gustavopiazdasilva2102@gmail.com>

The commit message is still not line-wraped.

This patch didn't apply.  The first one did, but this doesn't.

On Sat, Jan 31, 2026 at 12:56:30PM -0300, Gustavo Piaz da Silva wrote:
> Refactor the device tree parsing logic in axis_fifo_probe() to reduce code duplication and improve readability.
> 
> Create a helper function axis_fifo_get_u32() to handle property reading and error checking, replacing repetitive of_property_read_u32() calls.
> 
> Also change has_rx_fifo and has_tx_fifo types from int to u32 in struct axis_fifo to avoid pointer type mismatch warnings, as of_property_read_u32 expects u32 pointers.
> 

I don't understand where this warning is comming from.  The existing
code is calling of_property_read_u32() which also takes a u32 so I
don't see what changed.  I wasn't able to generate a warning on my
end.

Anyway, the u32 change needs to be done as a separate patch.

regards,
dan carpenter


      reply	other threads:[~2026-01-31 17:41 UTC|newest]

Thread overview: 2+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2026-01-31 15:56 [PATCH v2] staging: axis-fifo: refactor device tree parsing Gustavo Piaz da Silva
2026-01-31 17:41 ` Dan Carpenter [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=aX4-3KP0BqHqaiO4@stanley.mountain \
    --to=dan.carpenter@linaro.org \
    --cc=gregkh@linuxfoundation.org \
    --cc=gshahrouzi@gmail.com \
    --cc=gustavopiazdasilva2102@gmail.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-staging@lists.linux.dev \
    --cc=ovidiu.panait.oss@gmail.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox