Re: [PATCH v2] staging: rtl8723bs: replace ternary comparison with min_t()

[William Hansen-Baird <william.hansen.baird@gmail.com>]

On Sat, Jan 31, 2026 at 08:35:55PM +0300, Dan Carpenter wrote:
> On Sat, Jan 31, 2026 at 03:55:25PM +0000, David Laight wrote:
> > > > @@ -1024,7 +1025,7 @@ static unsigned short rtw_parse_assoc_security_ies(struct adapter *padapter,
> > > >  			pstat->flags |= WLAN_STA_WPS;
> > > >  			copy_len = 0;
> > > >  		} else {
> > > > -			copy_len = ((wpa_ie_len+2) > sizeof(pstat->wpa_ie)) ? (sizeof(pstat->wpa_ie)):(wpa_ie_len+2);
> > > > +			copy_len = min_t(int, sizeof(pstat->wpa_ie), wpa_ie_len + 2);  
> > > 
> > > Use umin().  "int" is wrong because we don't want negative values
> > > stored in copy_len.
> > 
> > And the correct way to fix min() bleating is to change the type of the variables.
> > Using min_t() ought to be frowned up and only used as a last resort.
> > 
> > In this case I think all the variables declared with wpa_ie_len can/should be
> > unsigned int.
> > 
> 
> That also works.
> 
Hi Dan and David,

Thanks for your help. After reviewing the code, I do see a few checks 
ensuring wpa_ie_len is never negative.
Therefore umin() is safe in this case, and for v3 I'll update the patch accordingly.

Would you prefer I leave it at that, or is a broader change to 
make wpa_ie_len unsigned worth doing in a separate patch?

Thanks,
William