From: William Hansen-Baird <william.hansen.baird@gmail.com>
To: Greg KH <gregkh@linuxfoundation.org>
Cc: linux-staging@lists.linux.dev, linux-kernel@vger.kernel.org
Subject: Re: [PATCH 1/5] staging: rtl8723bs: core/rtw_mlme_ext.c: refactor security IE parsing in OnAssocReq
Date: Sat, 31 Jan 2026 16:58:25 -0500 [thread overview]
Message-ID: <aX57AZmBhzbKqQoc@william-fedora> (raw)
In-Reply-To: <2026012714-discount-wavy-ba95@gregkh>
On Tue, Jan 27, 2026 at 03:39:44PM +0100, Greg KH wrote:
> On Fri, Jan 16, 2026 at 11:08:47AM -0500, William Hansen-Baird wrote:
> > + parse_status = rtw_parse_assoc_security_ies(padapter, &elems, pstat);
> > + if (parse_status != WLAN_STATUS_SUCCESS)
> > + status = parse_status;
> >
> > if (status != WLAN_STATUS_SUCCESS)
> > goto OnAssocReqFail;
>
> This logic makes no sense. Did you do this by hand or have a tool do it
> for you?
>
I did it by hand. The original code checked the status after parsing
security IEs, only overwriting 'status' on parsing errors.
To preserve the original logic, I only overwrite 'status' if the parsing
of the security IEs was not successful.
Thanks,
William
prev parent reply other threads:[~2026-01-31 21:58 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-01-16 16:08 [PATCH 1/5] staging: rtl8723bs: core/rtw_mlme_ext.c: refactor security IE parsing in OnAssocReq William Hansen-Baird
2026-01-16 16:08 ` [PATCH 2/5] staging: rtl8723bs: core/rtw_mlme_ext.c: remove unnecessary else statement William Hansen-Baird
2026-01-16 16:08 ` [PATCH 3/5] staging: rtl8723bs: core/rtw_mlme_ext.c: remove braces for one-line if-statements William Hansen-Baird
2026-01-16 16:08 ` [PATCH 4/5] staging: rtl8723bs: replace ternary comparison with min_t() William Hansen-Baird
2026-01-27 14:37 ` Greg KH
2026-01-16 16:08 ` [PATCH 5/5] staging: rtl8723bs: core/rtw_mlme_ext.c: initialize copy_len, clearing later control-flow William Hansen-Baird
2026-01-27 14:38 ` Greg KH
2026-01-31 22:10 ` William Hansen-Baird
2026-01-27 14:39 ` [PATCH 1/5] staging: rtl8723bs: core/rtw_mlme_ext.c: refactor security IE parsing in OnAssocReq Greg KH
2026-01-31 21:58 ` William Hansen-Baird [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=aX57AZmBhzbKqQoc@william-fedora \
--to=william.hansen.baird@gmail.com \
--cc=gregkh@linuxfoundation.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-staging@lists.linux.dev \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox