From: Dan Carpenter <dan.carpenter@linaro.org>
To: Michael Huang <tehsiu.huang@gmail.com>
Cc: gregkh@linuxfoundation.org, straube.linux@gmail.com,
hansg@kernel.org, linux-staging@lists.linux.dev,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH] staging: rtl8723bs: fix coding style issues in rtw_mlme.c
Date: Fri, 23 Jan 2026 11:57:05 +0300 [thread overview]
Message-ID: <aXM34ZGQ4Q2dsRxk@stanley.mountain> (raw)
In-Reply-To: <20260123003205.33898-1-tehsiu.huang@gmail.com>
On Thu, Jan 22, 2026 at 04:32:05PM -0800, Michael Huang wrote:
> This patch fixes several checkpatch.pl issues:
> 1. Remove redundant else after break/return.
> 2. Remove unnecessary boolean comparisons (== true/false).
> 3. Fix trailing whitespaces and overly deep indentation.
>
> Signed-off-by: Michael Huang <tehsiu.huang@gmail.com>
Split this up into multiple patches.
> @@ -1560,10 +1559,6 @@ void _rtw_join_timeout_handler(struct timer_list *t)
> do_join_r = rtw_do_join(adapter);
> if (do_join_r != _SUCCESS)
> continue;
> -
> - break;
> - } else {
> - rtw_indicate_disconnect(adapter);
> break;
> }
> }
You accidentally deleted some important stuff here.
regards,
dan carpenter
next prev parent reply other threads:[~2026-01-23 8:57 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-01-23 0:32 [PATCH] staging: rtl8723bs: fix coding style issues in rtw_mlme.c Michael Huang
2026-01-23 8:57 ` Dan Carpenter [this message]
2026-01-23 9:57 ` [PATCH v2 0/2] staging: rtl8723bs: fix coding style and logic " Michael Huang
2026-01-23 9:57 ` [PATCH v2 1/2] staging: rtl8723bs: remove unnecessary boolean comparisons and whitespaces Michael Huang
2026-01-27 14:42 ` Greg KH
2026-01-23 9:57 ` [PATCH v2 2/2] staging: rtl8723bs: remove redundant else after break Michael Huang
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=aXM34ZGQ4Q2dsRxk@stanley.mountain \
--to=dan.carpenter@linaro.org \
--cc=gregkh@linuxfoundation.org \
--cc=hansg@kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-staging@lists.linux.dev \
--cc=straube.linux@gmail.com \
--cc=tehsiu.huang@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox