Re: [PATCH v5 0/7] staging: rtl8723bs: cleanup and refactorcleanup and indentation refactoring

[Dan Carpenter <dan.carpenter@linaro.org>]

On Sat, Jan 24, 2026 at 03:15:50PM -0800, Michael Huang wrote:
> This series refactors the function in rtw_mlme_ext.c to
> improve readability and comply with Linux kernel coding standards.
> 
> Following feedback from Dan Carpenter, this version (v5) deconstructs
> the previous changes into seven atomic patches. This separation ensures
> that logical changes (such as flattening nested loops) are isolated
> from purely stylistic cleanups (such as fixing indentation or NULL
> checks), making the review process more straightforward and less
> error-prone.
> 
> Each patch focuses on a single category of improvement:
> 1. Logic flattening: Use continue statements to reduce indentation.
> 2. Comment positioning: Adjust comments to align with new logic.
> 3. New lines cleanup: Removed unnecessary new lines
> 4. Line length compliance: Resolve 100-column limit warnings.
> 5. Operator spacing: Add missing spaces around logical operators.
> 6. Braces removal: Clean up unnecessary braces in single-line branches.
> 7. NULL check simplification: Use the "!ptr" convention for brevity.
> 
> ---
> Changes in v5:
> - Split the series into 7 atomic patches for easier review.
> - Renamed "guard clauses" to "continue statements" description per feedback.
> - Separated logic changes, comment refactoring, and style cleanups.
> - Fixed indentation issues (replaced spaces with tabs).
> - Simplified NULL pointer checks to use the !ptr convention.

Thanks!

Reviewed-by: Dan Carpenter <dan.carpenter@linaro.org>

regards,
dan carpenter