From: Dan Carpenter <dan.carpenter@linaro.org>
To: Ethan Tidmore <ethantidmore06@gmail.com>
Cc: Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
linux-staging@lists.linux.dev, linux-kernel@vger.kernel.org,
Michael Straube <straube.linux@gmail.com>,
Hans de Goede <hansg@kernel.org>,
Akiyoshi Kurita <weibu@redadmin.org>
Subject: Re: [PATCH v1] staging: rtl8723bs: rename members of struct registry_priv
Date: Tue, 27 Jan 2026 09:26:41 +0300 [thread overview]
Message-ID: <aXhaoRMIlbRVgZui@stanley.mountain> (raw)
In-Reply-To: <20260126141543.2527-1-ethantidmore06@gmail.com>
On Mon, Jan 26, 2026 at 08:15:43AM -0600, Ethan Tidmore wrote:
> @@ -750,7 +751,8 @@ s8 phy_get_tx_pwr_lmt(struct adapter *adapter, u32 reg_pwr_tbl_sel,
>
> void PHY_ConvertTxPowerLimitToPowerIndex(struct adapter *Adapter)
> {
> - struct hal_com_data *pHalData = GET_HAL_DATA(Adapter);
> + struct hal_com_data *pHalData = GET_HAL_DATA(Adapter);
This is an unrelated white-space change. Don't make unrelated changes.
> + struct registry_priv *r = &Adapter->registrypriv;
I feel like you did this to avoid going over the 100 character limit,
but please do that in a separate patch. I use a script to review these
changes and I want it to be a straight s/old/new/ change. Plus, "r"
is a bad name.
regards,
dan carpenter
next prev parent reply other threads:[~2026-01-27 6:26 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-01-26 14:15 [PATCH v1] staging: rtl8723bs: rename members of struct registry_priv Ethan Tidmore
2026-01-26 14:32 ` Greg Kroah-Hartman
2026-01-27 6:26 ` Dan Carpenter [this message]
2026-01-27 7:43 ` Ethan Tidmore
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=aXhaoRMIlbRVgZui@stanley.mountain \
--to=dan.carpenter@linaro.org \
--cc=ethantidmore06@gmail.com \
--cc=gregkh@linuxfoundation.org \
--cc=hansg@kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-staging@lists.linux.dev \
--cc=straube.linux@gmail.com \
--cc=weibu@redadmin.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox