From: Dan Carpenter <dan.carpenter@linaro.org>
To: Ethan Tidmore <ethantidmore06@gmail.com>
Cc: Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
Michael Straube <straube.linux@gmail.com>,
linux-staging@lists.linux.dev, linux-kernel@vger.kernel.org
Subject: Re: [PATCH v2 0/4] staging: rtl8723bs: remove unused diagnostic
Date: Wed, 28 Jan 2026 16:23:26 +0300 [thread overview]
Message-ID: <aXoNztBM_kVOIAHV@stanley.mountain> (raw)
In-Reply-To: <20260128004009.51095-1-ethantidmore06@gmail.com>
On Tue, Jan 27, 2026 at 06:40:04PM -0600, Ethan Tidmore wrote:
> This series performs a driver-wide audit and cleanup of dead diagnostic
> code within the rtl8723bs staging driver.
>
> The vendor-originated code included a variety of diagnostic counters
> housed within 'struct debug_priv'. These counters were updated
> throughout the driver's hot paths—including MLME, receive, power
> control, and SDIO allocation—but were never read, exposed via
> debugfs, or utilized for any internal logic.
>
> This series removes the write-only counters, the skeletal functions
> used to update them, and cleans up the resulting unused pointers
> and logic blocks.
>
> Changes in v2:
> - Expanded the series to include the removal of RX FIFO overflow
> logic in hal_com.c.
>
Please don't send multiple versions of a patch on the same day.
Anyway, kbuild bot complained so at least I don't have to review this
now.
regards,
dan carpenter
prev parent reply other threads:[~2026-01-28 13:23 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-01-28 0:40 [PATCH v2 0/4] staging: rtl8723bs: remove unused diagnostic Ethan Tidmore
2026-01-28 0:40 ` [PATCH v2 1/4] staging: rtl8723bs: remove dead RX info reset logic Ethan Tidmore
2026-01-28 0:40 ` [PATCH v2 2/4] staging: rtl8723bs: remove dead RX FIFO overflow logic Ethan Tidmore
2026-01-28 9:29 ` kernel test robot
2026-01-28 0:40 ` [PATCH v2 3/4] staging: rtl8723bs: remove dead RX sequence logic Ethan Tidmore
2026-01-28 0:40 ` [PATCH v2 4/4] staging: rtl8723bs: remove unused struct debug_priv and all counters Ethan Tidmore
2026-01-28 11:02 ` [PATCH v2 0/4] staging: rtl8723bs: remove unused diagnostic Greg Kroah-Hartman
2026-01-28 13:23 ` Dan Carpenter [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=aXoNztBM_kVOIAHV@stanley.mountain \
--to=dan.carpenter@linaro.org \
--cc=ethantidmore06@gmail.com \
--cc=gregkh@linuxfoundation.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-staging@lists.linux.dev \
--cc=straube.linux@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox