[PATCH] staging: rtl8723bs: fix checkpatch warnings in os_dep/osdep_service.c

[PATCH] staging: rtl8723bs: fix checkpatch warnings in os_dep/osdep_service.c

[Gus Stoermer]

From 64ab45283c7e006c3420242e0f7b00acc1c3fd38 Mon Sep 17 00:00:00 2001
From: xlumen1 <gstoermer1@gmail.com>
Date: Wed, 28 Jan 2026 18:08:46 +0000
Subject: [PATCH] staging: rtl8723bs: fix checkpatch warnings in
os_dep/osdep_service.c

Signed-off-by: xlumen1 <gstoermer1@gmail.com>
---
drivers/staging/rtl8723bs/os_dep/osdep_service.c | 11 ++++++-----
1 file changed, 6 insertions(+), 5 deletions(-)

diff --git a/drivers/staging/rtl8723bs/os_dep/osdep_service.c
b/drivers/staging/rtl8723bs/os_dep/osdep_service.c
index a00f9f0c8..95b1d4e8e 100644
--- a/drivers/staging/rtl8723bs/os_dep/osdep_service.c
+++ b/drivers/staging/rtl8723bs/os_dep/osdep_service.c
@@ -7,9 +7,9 @@
#include <drv_types.h>

/*
-* Translate the OS dependent @param error_code to OS independent
RTW_STATUS_CODE
-* @return: one of RTW_STATUS_CODE
-*/
+ * Translate the OS dependent @param error_code to OS independent
RTW_STATUS_CODE
+ * @return: one of RTW_STATUS_CODE
+ */
inline int RTW_STATUS_CODE(int error_code)
{
       if (error_code >= 0)
@@ -152,7 +152,6 @@ void rtw_buf_update(u8 **buf, u32 *buf_len, u8
*src, u32 src_len)
               kfree(ori);
}

-
/**
 * rtw_cbuf_full - test if cbuf is full
 * @cbuf: pointer of struct rtw_cbuf
@@ -204,6 +203,7 @@ bool rtw_cbuf_push(struct rtw_cbuf *cbuf, void *buf)
void *rtw_cbuf_pop(struct rtw_cbuf *cbuf)
{
       void *buf;
+
       if (rtw_cbuf_empty(cbuf))
               return NULL;

@@ -226,7 +226,8 @@ struct rtw_cbuf *rtw_cbuf_alloc(u32 size)
       cbuf = rtw_malloc(struct_size(cbuf, bufs, size));

       if (cbuf) {
-               cbuf->write = cbuf->read = 0;
+               cbuf->write = 0;
+               cbuf->read = 0;
               cbuf->size = size;
       }

--
2.34.1

Re: [PATCH] staging: rtl8723bs: fix checkpatch warnings in os_dep/osdep_service.c

[Dan Carpenter]

On Wed, Jan 28, 2026 at 06:28:59PM +0000, Gus Stoermer wrote:
> >From 64ab45283c7e006c3420242e0f7b00acc1c3fd38 Mon Sep 17 00:00:00 2001
> From: xlumen1 <gstoermer1@gmail.com>
> Date: Wed, 28 Jan 2026 18:08:46 +0000
> Subject: [PATCH] staging: rtl8723bs: fix checkpatch warnings in
> os_dep/osdep_service.c
> 
> Signed-off-by: xlumen1 <gstoermer1@gmail.com>
> ---

Please use your real name.  No commit message.  The patch is corrupted.
You're doing too many things in one patch.  Fix one type of warning at
a time.

regards,
dan carpenter