From: Dan Carpenter <dan.carpenter@linaro.org>
To: Omer El Idrissi <omer.e.idrissi@gmail.com>
Cc: gregkh@linuxfoundation.org, linux-staging@lists.linux.dev,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH v2] staging: rtl8723bs: replace magic -2 error codes with proper errno
Date: Thu, 29 Jan 2026 10:27:29 +0300 [thread overview]
Message-ID: <aXsL4a5RvlIqTpht@stanley.mountain> (raw)
In-Reply-To: <20260128172143.23472-1-omer.e.idrissi@gmail.com>
On Wed, Jan 28, 2026 at 06:21:43PM +0100, Omer El Idrissi wrote:
> Changes since v1:
> - Removed leftover comment accidentally left in previous version
> - No functional changes
>
> Signed-off-by: Omer El Idrissi <omer.e.idrissi@gmail.com>
No commit message.
https://staticthinking.wordpress.com/2022/07/27/how-to-send-a-v2-patch/
Why is do you change -2 to both -EBUSY and -ENOBUFS? In the original
code, the -1 and -2 return meant something custom and they weren't
kernel error codes:
* Return:
*0 Success
*-1 Hardware resource(TX FIFO) not ready
*-2 Software resource(xmitbuf) not ready
Now the documentation makes no sense.
regards,
dan carpenter
next prev parent reply other threads:[~2026-01-29 7:27 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-01-25 22:12 [PATCH] staging: rtl8723bs: replace magic -2 error codes with proper errno Omer El Idrissi
2026-01-27 14:43 ` Greg KH
2026-01-28 17:21 ` [PATCH v2] " Omer El Idrissi
2026-01-29 7:27 ` Dan Carpenter [this message]
2026-01-29 17:26 ` Omer El Idrissi
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=aXsL4a5RvlIqTpht@stanley.mountain \
--to=dan.carpenter@linaro.org \
--cc=gregkh@linuxfoundation.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-staging@lists.linux.dev \
--cc=omer.e.idrissi@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox