From: Dan Carpenter <dan.carpenter@linaro.org>
To: Minu Jin <s9430939@naver.com>
Cc: gregkh@linuxfoundation.org, bqn9090@gmail.com,
abrahamadekunle50@gmail.com, straube.linux@gmail.com,
bryant.boatright@proton.me, davidzalman.101@gmail.com,
linux-staging@lists.linux.dev, linux-kernel@vger.kernel.org
Subject: Re: [PATCH v3] staging: rtl8723bs: fix potential race in expire_timeout_chk
Date: Fri, 30 Jan 2026 12:07:51 +0300 [thread overview]
Message-ID: <aXx05zTOJeCyQ5zo@stanley.mountain> (raw)
In-Reply-To: <20260129123342.309946-1-s9430939@naver.com>
On Thu, Jan 29, 2026 at 09:33:42PM +0900, Minu Jin wrote:
> The expire_timeout_chk function currently do lock and unlock inside the
> loop before calling rtw_free_stainfo().
>
> This can be risky as the list might be changed
> when the lock is briefly released.
>
> To fix this, move expired sta_info entries into a local free_list while
> holding the lock, and then perform the actual freeing after the lock is
> released.
>
> Signed-off-by: Minu Jin <s9430939@naver.com>
> ---
> Changes in v3:
> Suggested-by Dan Carpenter
> - Use list_for_each_entry_safe() only for the new code.
> - Remove blank line in the declaration block.
> - Keep existing code unchanged
Thanks!
Reviewed-by: Dan Carpenter <dan.carpenter@linaro.org>
regards,
dan carpenter
prev parent reply other threads:[~2026-01-30 9:07 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-01-29 2:32 [PATCH v2] staging: rtl8723bs: Fix potential race in expire_timeout_chk Minu Jin
2026-01-29 7:05 ` Dan Carpenter
2026-01-29 12:33 ` [PATCH v3] staging: rtl8723bs: fix " Minu Jin
2026-01-30 9:07 ` Dan Carpenter [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=aXx05zTOJeCyQ5zo@stanley.mountain \
--to=dan.carpenter@linaro.org \
--cc=abrahamadekunle50@gmail.com \
--cc=bqn9090@gmail.com \
--cc=bryant.boatright@proton.me \
--cc=davidzalman.101@gmail.com \
--cc=gregkh@linuxfoundation.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-staging@lists.linux.dev \
--cc=s9430939@naver.com \
--cc=straube.linux@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox