From: Dan Carpenter <dan.carpenter@linaro.org>
To: Ethan Tidmore <ethantidmore06@gmail.com>
Cc: gregkh@linuxfoundation.org, straube.linux@gmail.com,
linux-staging@lists.linux.dev, linux-kernel@vger.kernel.org
Subject: Re: [PATCH v3] staging: rtl8723bs: remove unused private debug counters
Date: Fri, 30 Jan 2026 11:58:05 +0300 [thread overview]
Message-ID: <aXxyndc-IWY64d8J@stanley.mountain> (raw)
In-Reply-To: <20260129163438.35749-1-ethantidmore06@gmail.com>
On Thu, Jan 29, 2026 at 10:34:38AM -0600, Ethan Tidmore wrote:
> The driver maintains a private `struct debug_priv` embedded within
> `struct dvobj_priv` to track various error counters (e.g., suspend
> errors, alloc failures, RX drops).
>
> These counters are incremented in various files but the data is
> never read or exposed to userspace.
>
> Remove the unused `debug_priv` structure definition, the instance
> in `dvobj_priv`, and all associated increment operations across
> the driver to clean up the code.
>
> This also removes the following helper functions which were used
> solely to update these counters:
> - rtw_reset_rx_info()
> - recv_indicatepkts_pkt_loss_cnt()
> - rtw_hal_check_rxfifo_full()
>
> ---
> v3:
> - Squashed previous series into a single atomic patch to remove
> definitions and usages simultaneously (Feedback from Dan Carpenter).
> - Removed stray blank line in rtw_mlme.c (Feedback from Dan Carpenter).
> - Removed unused variable 'fw_current_in_ps_mode' in rtl8723b_dm.c
> to fix -Wunused-but-set-variable warning (Fixes kbuild bot failure).
>
> Signed-off-by: Ethan Tidmore <ethantidmore06@gmail.com>
> ---
The changelog notes go after.
https://staticthinking.wordpress.com/2022/07/27/how-to-send-a-v2-patch/
regards,
dan carpenter
prev parent reply other threads:[~2026-01-30 8:58 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-01-29 16:34 [PATCH v3] staging: rtl8723bs: remove unused private debug counters Ethan Tidmore
2026-01-30 8:58 ` Dan Carpenter [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=aXxyndc-IWY64d8J@stanley.mountain \
--to=dan.carpenter@linaro.org \
--cc=ethantidmore06@gmail.com \
--cc=gregkh@linuxfoundation.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-staging@lists.linux.dev \
--cc=straube.linux@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox