[PATCH v2] staging: rtl8723bs: split multiple assignment in osdep_service.c

[PATCH v2] staging: rtl8723bs: split multiple assignment in osdep_service.c

[Juyeong Jun]

v2:I fixed my git configuration. There are no code changes.

Avoid multiple assignments in a single statement.
No functional change.
---
 drivers/staging/rtl8723bs/os_dep/osdep_service.c | 3 ++-
 1 file changed, 2 insertions(+), 1 deletion(-)

diff --git a/drivers/staging/rtl8723bs/os_dep/osdep_service.c b/drivers/staging/rtl8723bs/os_dep/osdep_service.c
index a00f9f0c85c5..19b378b49809 100644
--- a/drivers/staging/rtl8723bs/os_dep/osdep_service.c
+++ b/drivers/staging/rtl8723bs/os_dep/osdep_service.c
@@ -226,7 +226,8 @@ struct rtw_cbuf *rtw_cbuf_alloc(u32 size)
 	cbuf = rtw_malloc(struct_size(cbuf, bufs, size));
 
 	if (cbuf) {
-		cbuf->write = cbuf->read = 0;
+		cbuf->write = 0;
+		cbuf->read = 0;
 		cbuf->size = size;
 	}
 
-- 
2.34.1

Re: [PATCH v2] staging: rtl8723bs: split multiple assignment in osdep_service.c

[Dan Carpenter]

On Thu, Feb 12, 2026 at 08:13:16PM +0900, Juyeong Jun wrote:
> v2:I fixed my git configuration. There are no code changes.

The v2 got under the --- cut off line.
> 
> Avoid multiple assignments in a single statement.
> No functional change.
> ---
  ^^^
here.

Also no Signed-off-by line

regards,
dan carpenter

Re: [PATCH v2] staging: rtl8723bs: split multiple assignment in osdep_service.c

[Greg Kroah-Hartman]

On Thu, Feb 12, 2026 at 08:13:16PM +0900, Juyeong Jun wrote:
> v2:I fixed my git configuration. There are no code changes.
> 
> Avoid multiple assignments in a single statement.
> No functional change.
> ---
>  drivers/staging/rtl8723bs/os_dep/osdep_service.c | 3 ++-
>  1 file changed, 2 insertions(+), 1 deletion(-)
> 
> diff --git a/drivers/staging/rtl8723bs/os_dep/osdep_service.c b/drivers/staging/rtl8723bs/os_dep/osdep_service.c
> index a00f9f0c85c5..19b378b49809 100644
> --- a/drivers/staging/rtl8723bs/os_dep/osdep_service.c
> +++ b/drivers/staging/rtl8723bs/os_dep/osdep_service.c
> @@ -226,7 +226,8 @@ struct rtw_cbuf *rtw_cbuf_alloc(u32 size)
>  	cbuf = rtw_malloc(struct_size(cbuf, bufs, size));
>  
>  	if (cbuf) {
> -		cbuf->write = cbuf->read = 0;
> +		cbuf->write = 0;
> +		cbuf->read = 0;
>  		cbuf->size = size;
>  	}
>  
> -- 
> 2.34.1
> 
> 

Hi,

This is the friendly patch-bot of Greg Kroah-Hartman.  You have sent him
a patch that has triggered this response.  He used to manually respond
to these common problems, but in order to save his sanity (he kept
writing the same thing over and over, yet to different people), I was
created.  Hopefully you will not take offence and will fix the problem
in your patch and resubmit it so that it can be accepted into the Linux
kernel tree.

You are receiving this message because of the following common error(s)
as indicated below:

- Your patch does not have a Signed-off-by: line.  Please read the
  kernel file, Documentation/process/submitting-patches.rst and resend
  it after adding that line.  Note, the line needs to be in the body of
  the email, before the patch, not at the bottom of the patch or in the
  email signature.

- This looks like a new version of a previously submitted patch, but you
  did not list below the --- line any changes from the previous version.
  Please read the section entitled "The canonical patch format" in the
  kernel file, Documentation/process/submitting-patches.rst for what
  needs to be done here to properly describe this.

If you wish to discuss this problem further, or you have questions about
how to resolve this issue, please feel free to respond to this email and
Greg will reply once he has dug out from the pending patches received
from other developers.

thanks,

greg k-h's patch email bot