From: Dan Carpenter <dan.carpenter@linaro.org>
To: Ethan Tidmore <ethantidmore06@gmail.com>
Cc: Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
Michael Straube <straube.linux@gmail.com>,
linux-staging@lists.linux.dev, linux-kernel@vger.kernel.org
Subject: Re: [PATCH v5] staging: rtl8723bs: remove unused private debug counters
Date: Mon, 2 Feb 2026 11:35:55 +0300 [thread overview]
Message-ID: <aYBh67k7sfVpmKU8@stanley.mountain> (raw)
In-Reply-To: <20260131212128.25548-1-ethantidmore06@gmail.com>
On Sat, Jan 31, 2026 at 03:21:28PM -0600, Ethan Tidmore wrote:
> The driver maintains a private `struct debug_priv` embedded within
> `struct dvobj_priv` to track various error counters (e.g., suspend
> errors, alloc failures, RX drops).
>
> These counters are incremented in various files but the data is
> never read or exposed to userspace.
>
> Remove the unused `debug_priv` structure definition, the instance
> in `dvobj_priv`, and all associated increment operations across
> the driver to clean up the code.
>
> This also removes the following helper functions which were used
> solely to update these counters:
> - rtw_reset_rx_info()
> - recv_indicatepkts_pkt_loss_cnt()
>
> Signed-off-by: Ethan Tidmore <ethantidmore06@gmail.com>
> ---
LGTM.
Reviewed-by: Dan Carpenter <dan.carpenter@linaro.org>
regards,
dan carpenter
prev parent reply other threads:[~2026-02-02 8:36 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-01-31 21:21 [PATCH v5] staging: rtl8723bs: remove unused private debug counters Ethan Tidmore
2026-02-02 8:35 ` Dan Carpenter [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=aYBh67k7sfVpmKU8@stanley.mountain \
--to=dan.carpenter@linaro.org \
--cc=ethantidmore06@gmail.com \
--cc=gregkh@linuxfoundation.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-staging@lists.linux.dev \
--cc=straube.linux@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox