Re: [PATCH v3 2/2] staging: axis-fifo: refactor device tree parsing

[Dan Carpenter <dan.carpenter@linaro.org>]

On Sat, Jan 31, 2026 at 03:27:32PM -0300, Gustavo Piaz da Silva wrote:
> Refactor the device tree parsing logic in axis_fifo_probe() to reduce
> 
> code duplication and improve readability.
> 
> Create a helper function axis_fifo_get_u32() to handle property reading
> 
> and error checking, replacing repetitive of_property_read_u32() calls.
> 
> This eliminates the goto logic for error handling in the probe path and
> 
> consolidates error logging.
> 

Delete the extra blank lines.

> Signed-off-by: Gustavo Piaz da Silva <gustavopiazdasilva2102@gmail.com>
> ---

No changelog explaining what changed vs v2.

>  drivers/staging/axis-fifo/axis-fifo.c | 76 +++++++++------------------
>  1 file changed, 25 insertions(+), 51 deletions(-)
> 
> diff --git a/drivers/staging/axis-fifo/axis-fifo.c b/drivers/staging/axis-fifo/axis-fifo.c
> index 7bc7bf191250..1e3059ec4fbd 100644
> --- a/drivers/staging/axis-fifo/axis-fifo.c
> +++ b/drivers/staging/axis-fifo/axis-fifo.c
> @@ -482,68 +482,42 @@ static void axis_fifo_debugfs_init(struct axis_fifo *fifo)
>  			    &axis_fifo_debugfs_regs_fops);
>  }
>  
> -static int axis_fifo_parse_dt(struct axis_fifo *fifo)
> +
> +static int axis_fifo_get_u32(struct axis_fifo *fifo, const char *prop, u32 *val)
>  {
> -	int ret;
> -	unsigned int value;
> -	struct device_node *node = fifo->dt_device->of_node;
> +	int ret = of_property_read_u32(fifo->dt_device->of_node, prop, val);
>  
> -	ret = of_property_read_u32(node, "xlnx,axi-str-rxd-tdata-width",
> -				   &value);
>  	if (ret) {
> -		dev_err(fifo->dt_device, "missing xlnx,axi-str-rxd-tdata-width property\n");
> -		goto end;
> -	} else if (value != 32) {
> -		dev_err(fifo->dt_device, "xlnx,axi-str-rxd-tdata-width only supports 32 bits\n");
> -		ret = -EIO;
> -		goto end;
> +		dev_err(fifo->dt_device, "missing %s property\n", prop);
> +		return ret;
>  	}
> +	return 0;
> +}
>  
> -	ret = of_property_read_u32(node, "xlnx,axi-str-txd-tdata-width",
> -				   &value);
> -	if (ret) {
> -		dev_err(fifo->dt_device, "missing xlnx,axi-str-txd-tdata-width property\n");
> -		goto end;
> -	} else if (value != 32) {
> -		dev_err(fifo->dt_device, "xlnx,axi-str-txd-tdata-width only supports 32 bits\n");
> -		ret = -EIO;
> -		goto end;
> -	}
> +static int axis_fifo_parse_dt(struct axis_fifo *fifo)
> +{
> +	u32 width;
>  
> -	ret = of_property_read_u32(node, "xlnx,rx-fifo-depth",
> -				   &fifo->rx_fifo_depth);
> -	if (ret) {
> -		dev_err(fifo->dt_device, "missing xlnx,rx-fifo-depth property\n");
> -		ret = -EIO;
> -		goto end;
> +	if (axis_fifo_get_u32(fifo, "xlnx,axi-str-rxd-tdata-width", &width) || width != 32) {
> +		dev_err(fifo->dt_device, "tdata-width only supports 32 bits\n");

Better to put "rx" in the error message

> +		return -EIO;
>  	}
> -
> -	ret = of_property_read_u32(node, "xlnx,tx-fifo-depth",
> -				   &fifo->tx_fifo_depth);
> -	if (ret) {
> -		dev_err(fifo->dt_device, "missing xlnx,tx-fifo-depth property\n");
> -		ret = -EIO;
> -		goto end;
> +	if (axis_fifo_get_u32(fifo, "xlnx,axi-str-txd-tdata-width", &width) || width != 32) {
> +		dev_err(fifo->dt_device, "tdata-width only supports 32 bits\n");

and "tx" here.

regards,
dan carpenter

> +		return -EIO;
>  	}