public inbox for linux-staging@lists.linux.dev
 help / color / mirror / Atom feed
From: Dan Carpenter <dan.carpenter@linaro.org>
To: "Ö. Efe D." <skylinesytbe@gmail.com>
Cc: "Greg Kroah-Hartman" <gregkh@linuxfoundation.org>,
	"Michael Straube" <straube.linux@gmail.com>,
	linux-staging@lists.linux.dev,
	"Ö. Efe D." <skyline@noreply.codeberg.org>,
	"Öner Efe Dasgüney" <efedasguney@protonmail.com>
Subject: Re: [PATCH] staging: rtl8723bs: fix whitespace issues in hal_com.c
Date: Mon, 2 Feb 2026 12:38:00 +0300	[thread overview]
Message-ID: <aYBweE0vr8iIo0ex@stanley.mountain> (raw)
In-Reply-To: <20260202021845.265051-1-skyline@noreply.codeberg.org>

On Mon, Feb 02, 2026 at 03:18:45AM +0100, Ö. Efe D. wrote:
> Remove spaces before tabs in comments to fix checkpatch warnings:
> "please, no space before tabs"
> 
> Signed-off-by: Öner Efe Dasgüney <efedasguney@protonmail.com>
> ---
>  drivers/staging/rtl8723bs/hal/hal_com.c | 16 ++++++++--------
>  1 file changed, 8 insertions(+), 8 deletions(-)
> 
> diff --git a/drivers/staging/rtl8723bs/hal/hal_com.c b/drivers/staging/rtl8723bs/hal/hal_com.c
> index 70b5b289f9cb..10c34228a595 100644
> --- a/drivers/staging/rtl8723bs/hal/hal_com.c
> +++ b/drivers/staging/rtl8723bs/hal/hal_com.c
> @@ -362,8 +362,8 @@ static void _TwoOutPipeMapping(struct adapter *padapter, bool bWIFICfg)
>  
>  	if (bWIFICfg) { /* WMM */
>  
> -		/* 	BK,	BE,	VI,	VO,	BCN,	CMD, MGT, HIGH, HCCA */
> -		/*   0,		1,	0,	1,	0,	0,	0,	0,		0	}; */
> +		/*	BK,	BE,	VI,	VO,	BCN,	CMD, MGT, HIGH, HCCA */
> +		/*	0,	1,	0,	1,	0,	0,	0,	0,	0	}; */

These things are supposed to be aligned so that the commas on the top
line are the same as on the bottom line.  It's a table.  But it's messed
up both before and after.

regards,
dan carpenter


  parent reply	other threads:[~2026-02-02  9:38 UTC|newest]

Thread overview: 7+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2026-02-02  2:18 [PATCH] staging: rtl8723bs: fix whitespace issues in hal_com.c Ö. Efe D.
2026-02-02  7:08 ` M.samet Duman
2026-02-02  9:34   ` Dan Carpenter
2026-02-02  9:49     ` Greg Kroah-Hartman
2026-02-02 11:39       ` Dan Carpenter
2026-02-02  9:38 ` Dan Carpenter [this message]
2026-02-07 13:18 ` Greg Kroah-Hartman

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=aYBweE0vr8iIo0ex@stanley.mountain \
    --to=dan.carpenter@linaro.org \
    --cc=efedasguney@protonmail.com \
    --cc=gregkh@linuxfoundation.org \
    --cc=linux-staging@lists.linux.dev \
    --cc=skyline@noreply.codeberg.org \
    --cc=skylinesytbe@gmail.com \
    --cc=straube.linux@gmail.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox