* [PATCH] staging: rtl8723bs: make _action_public_str const
@ 2026-02-02 10:08 Giorgi Tchankvetadze
2026-02-02 12:34 ` Dan Carpenter
0 siblings, 1 reply; 2+ messages in thread
From: Giorgi Tchankvetadze @ 2026-02-02 10:08 UTC (permalink / raw)
To: Greg Kroah-Hartman, linux-staging; +Cc: linux-kernel, Giorgi Tchankvetadze
The _action_public_str array is never modified at runtime and serves as a lookup table.
Mark it 'static const char * const' to allow the compiler to put it in the
read-only data section.
This fixes a checkpatch warning:
WARNING: static const char * array should probably be static const char * const
Signed-off-by: Giorgi Tchankvetadze <giorgitchankvetadze1997@gmail.com>
---
drivers/staging/rtl8723bs/core/rtw_ieee80211.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/staging/rtl8723bs/core/rtw_ieee80211.c b/drivers/staging/rtl8723bs/core/rtw_ieee80211.c
index 8fdeeda88a6d..4de0875904eb 100644
--- a/drivers/staging/rtl8723bs/core/rtw_ieee80211.c
+++ b/drivers/staging/rtl8723bs/core/rtw_ieee80211.c
@@ -1139,7 +1139,7 @@ int rtw_action_frame_parse(const u8 *frame, u32 frame_len, u8 *category, u8 *act
return true;
}
-static const char *_action_public_str[] = {
+static const char * const _action_public_str[] = {
"ACT_PUB_BSSCOEXIST",
"ACT_PUB_DSE_ENABLE",
"ACT_PUB_DSE_DEENABLE",
--
2.52.0
^ permalink raw reply related [flat|nested] 2+ messages in thread* Re: [PATCH] staging: rtl8723bs: make _action_public_str const
2026-02-02 10:08 [PATCH] staging: rtl8723bs: make _action_public_str const Giorgi Tchankvetadze
@ 2026-02-02 12:34 ` Dan Carpenter
0 siblings, 0 replies; 2+ messages in thread
From: Dan Carpenter @ 2026-02-02 12:34 UTC (permalink / raw)
To: Giorgi Tchankvetadze; +Cc: Greg Kroah-Hartman, linux-staging, linux-kernel
On Mon, Feb 02, 2026 at 02:08:50PM +0400, Giorgi Tchankvetadze wrote:
> The _action_public_str array is never modified at runtime and serves as a lookup table.
> Mark it 'static const char * const' to allow the compiler to put it in the
> read-only data section.
>
> This fixes a checkpatch warning:
> WARNING: static const char * array should probably be static const char * const
> Signed-off-by: Giorgi Tchankvetadze <giorgitchankvetadze1997@gmail.com>
> ---
Add a blank line before the Signed-off-by line.
regards,
dan carpenter
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2026-02-02 12:34 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2026-02-02 10:08 [PATCH] staging: rtl8723bs: make _action_public_str const Giorgi Tchankvetadze
2026-02-02 12:34 ` Dan Carpenter
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox