From: Andy Shevchenko <andriy.shevchenko@intel.com>
To: Minu Jin <s9430939@naver.com>
Cc: gregkh@linuxfoundation.org, dan.carpenter@linaro.org,
trohan2000@gmail.com, andy@kernel.org,
linux-staging@lists.linux.dev, straube.linux@gmail.com,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH v4 4/4] staging: rtl8723bs: remove unused allocation wrapper functions
Date: Tue, 3 Feb 2026 17:14:58 +0200 [thread overview]
Message-ID: <aYIQ8iJ5R11IxcA7@smile.fi.intel.com> (raw)
In-Reply-To: <20260131193001.303307-5-s9430939@naver.com>
On Sun, Feb 01, 2026 at 04:30:01AM +0900, Minu Jin wrote:
> All memory allocation call sites have been migrated to kernel
> APIs (kmalloc, kzalloc, and skb functions). Therefore, the custom
kmalloc()
kzalloc()
> wrapper layer is no longer necessary.
>
> This patch removes all redundant wrapper functions and macros from
> osdep_service.c and include/osdep_service.h, including unused macros
> like rtw_skb_alloc_f.
rtw_skb_alloc_f()
...
> -void *_rtw_zmalloc(u32 sz)
> -{
> - void *pbuf = kmalloc(sz, in_interrupt() ? GFP_ATOMIC : GFP_KERNEL);
> - if (pbuf)
> - memset(pbuf, 0, sz);
> -
> - return pbuf;
This change should remove the _original_ implementation, so no need to have a
churn to first convert this and then remove it.
> -}
--
With Best Regards,
Andy Shevchenko
prev parent reply other threads:[~2026-02-03 15:15 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-01-31 19:29 [PATCH v4 0/4] remove memory allocation wrappers Minu Jin
2026-01-31 19:29 ` [PATCH v4 1/4] staging: rtl8723bs: replace rtw_malloc() with kmalloc() Minu Jin
2026-02-03 14:52 ` Andy Shevchenko
2026-01-31 19:29 ` [PATCH v4 2/4] staging: rtl8723bs: replace rtw_zmalloc() with kzalloc() Minu Jin
2026-02-03 15:11 ` Andy Shevchenko
2026-01-31 19:30 ` [PATCH v4 3/4] staging: rtl8723bs: replace skb allocation, copy wrappers Minu Jin
2026-02-03 15:13 ` Andy Shevchenko
2026-01-31 19:30 ` [PATCH v4 4/4] staging: rtl8723bs: remove unused allocation wrapper functions Minu Jin
2026-02-03 15:14 ` Andy Shevchenko [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=aYIQ8iJ5R11IxcA7@smile.fi.intel.com \
--to=andriy.shevchenko@intel.com \
--cc=andy@kernel.org \
--cc=dan.carpenter@linaro.org \
--cc=gregkh@linuxfoundation.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-staging@lists.linux.dev \
--cc=s9430939@naver.com \
--cc=straube.linux@gmail.com \
--cc=trohan2000@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox