From: Andy Shevchenko <andriy.shevchenko@intel.com>
To: Minu Jin <s9430939@naver.com>
Cc: gregkh@linuxfoundation.org, andy@kernel.org,
dan.carpenter@linaro.org, trohan2000@gmail.com,
straube.linux@gmail.com, linux-staging@lists.linux.dev,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH v5 3/5] staging: rtl8723bs: replace rtw_zmalloc() with kzalloc()
Date: Wed, 4 Feb 2026 12:27:42 +0200 [thread overview]
Message-ID: <aYMfHiBrODTx1vRL@smile.fi.intel.com> (raw)
In-Reply-To: <20260204064455.1379342-4-s9430939@naver.com>
On Wed, Feb 04, 2026 at 03:44:52PM +0900, Minu Jin wrote:
> Replace the wrapper function rtw_zmalloc() with standard kzalloc().
> Use kzalloc() for rtw_malloc() calls that were followed by manual
> zero initialization.
>
> Additionally, use array_size() and size_add() to prevent potential
> integer overflows during allocation size calculation.
Reviewed-by: Andy Shevchenko <andriy.shevchenko@intel.com>
...
> static int cfg80211_rtw_add_key(struct wiphy *wiphy, struct net_device *ndev,
> struct mlme_priv *pmlmepriv = &padapter->mlmepriv;
>
> param_len = sizeof(struct ieee_param) + params->key_len;
> - param = rtw_malloc(param_len);
> + param = kzalloc(param_len, GFP_KERNEL);
> if (!param)
> return -1;
Also -ENOMEM?
--
With Best Regards,
Andy Shevchenko
next prev parent reply other threads:[~2026-02-04 10:27 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-02-04 6:44 [PATCH v5 0/5] staging: rtl8723bs: replace custom wrappers with kernel APIs Minu Jin
2026-02-04 6:44 ` [PATCH v5 1/5] staging: rtl8723bs: introduce kmemdup() where applicable Minu Jin
2026-02-04 10:16 ` Andy Shevchenko
2026-02-04 6:44 ` [PATCH v5 2/5] staging: rtl8723bs: replace rtw_malloc() with kmalloc() Minu Jin
2026-02-04 10:21 ` Andy Shevchenko
2026-02-04 6:44 ` [PATCH v5 3/5] staging: rtl8723bs: replace rtw_zmalloc() with kzalloc() Minu Jin
2026-02-04 10:27 ` Andy Shevchenko [this message]
2026-02-04 6:44 ` [PATCH v5 4/5] staging: rtl8723bs: use standard skb allocation APIs Minu Jin
2026-02-04 10:28 ` Andy Shevchenko
2026-02-04 6:44 ` [PATCH v5 5/5] staging: rtl8723bs: remove unused allocation wrapper functions Minu Jin
2026-02-04 10:29 ` Andy Shevchenko
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=aYMfHiBrODTx1vRL@smile.fi.intel.com \
--to=andriy.shevchenko@intel.com \
--cc=andy@kernel.org \
--cc=dan.carpenter@linaro.org \
--cc=gregkh@linuxfoundation.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-staging@lists.linux.dev \
--cc=s9430939@naver.com \
--cc=straube.linux@gmail.com \
--cc=trohan2000@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox