From: Dan Carpenter <dan.carpenter@linaro.org>
To: Haroen Tmimi <tmimiharoen@gmail.com>
Cc: gregkh@linuxfoundation.org, linux-staging@lists.linux.dev,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH] Fix checkpatch.pl warnings in rtw_ieee80211.c.
Date: Thu, 5 Feb 2026 08:46:44 +0300 [thread overview]
Message-ID: <aYQuxJ2ruJJjI7Zt@stanley.mountain> (raw)
In-Reply-To: <20260204184133.142511-1-tmimiharoen@gmail.com>
On Wed, Feb 04, 2026 at 07:41:33PM +0100, Haroen Tmimi wrote:
> 1. Fix "Yoda condition" style issues by moving constants to the right
> side of the comparison (e.g., changing "_SUCCESS == val" to
> "val == _SUCCESS").
>
> 2. Change the _action_public_str array to "static const char * const"
> to ensure the array entries are read-only, preventing accidental
> modification of the pointers.
>
These are unrelated things so they should be two patches. But
apparently someone else already did at least part of this...
regards,
dan carpenter
prev parent reply other threads:[~2026-02-05 5:46 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-02-04 18:41 [PATCH] Fix checkpatch.pl warnings in rtw_ieee80211.c Haroen Tmimi
2026-02-05 3:39 ` Ethan Tidmore
2026-02-05 5:46 ` Dan Carpenter [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=aYQuxJ2ruJJjI7Zt@stanley.mountain \
--to=dan.carpenter@linaro.org \
--cc=gregkh@linuxfoundation.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-staging@lists.linux.dev \
--cc=tmimiharoen@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox