From: Dan Carpenter <dan.carpenter@linaro.org>
To: Gustavo Piaz da Silva <gustavopiazdasilva2102@gmail.com>
Cc: gregkh@linuxfoundation.org, ovidiu.panait.oss@gmail.com,
gshahrouzi@gmail.com, linux-staging@lists.linux.dev,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH v7 2/2] staging: axis-fifo: refactor device tree parsing
Date: Fri, 6 Feb 2026 16:48:00 +0300 [thread overview]
Message-ID: <aYXxECAuS9nyWUia@stanley.mountain> (raw)
In-Reply-To: <20260206131148.13643-3-gustavopiazdasilva2102@gmail.com>
On Fri, Feb 06, 2026 at 10:11:48AM -0300, Gustavo Piaz da Silva wrote:
> - ret = of_property_read_u32(node, "xlnx,axi-str-rxd-tdata-width",
> - &value);
> + ret = of_property_read_u32(node, "xlnx,axi-str-rxd-tdata-width", &value);
You moved &value to the previous line which is the right thing. But,
please, don't make these unrelated white space changes in the same patch.
You can do it in a separate patch but they make the diff harder to
review.
regards,
dan carpenter
prev parent reply other threads:[~2026-02-06 13:48 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-02-06 13:11 [PATCH v7 0/2] staging: axis-fifo: clean up probe logic Gustavo Piaz da Silva
2026-02-06 13:11 ` [PATCH v7 1/2] staging: axis-fifo: use u32 for fifo depth flags Gustavo Piaz da Silva
2026-02-06 13:11 ` [PATCH v7 2/2] staging: axis-fifo: refactor device tree parsing Gustavo Piaz da Silva
2026-02-06 13:48 ` Dan Carpenter [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=aYXxECAuS9nyWUia@stanley.mountain \
--to=dan.carpenter@linaro.org \
--cc=gregkh@linuxfoundation.org \
--cc=gshahrouzi@gmail.com \
--cc=gustavopiazdasilva2102@gmail.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-staging@lists.linux.dev \
--cc=ovidiu.panait.oss@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox