From: Andy Shevchenko <andriy.shevchenko@intel.com>
To: "Jose A. Perez de Azpillaga" <azpijr@gmail.com>
Cc: Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
Andy Shevchenko <andy@kernel.org>,
dri-devel@lists.freedesktop.org, linux-fbdev@vger.kernel.org,
linux-kernel@vger.kernel.org, linux-staging@lists.linux.dev
Subject: Re: [PATCH v2] staging: fbtft: fb_ra8875: replace udelays with fsleep
Date: Thu, 26 Feb 2026 09:46:10 +0200 [thread overview]
Message-ID: <aZ_6QvJPZplh6xtd@smile.fi.intel.com> (raw)
In-Reply-To: <20260225234100.152320-1-azpijr@gmail.com>
On Thu, Feb 26, 2026 at 12:40:36AM +0100, Jose A. Perez de Azpillaga wrote:
> The write_reg8_bus8 function uses udelay(100) twice to wait for the
write_reg8_bus8()
> display controller. In non-atomic contexts, fsleep() is the preferred
> API as it automatically selects the most efficient sleeping mechanism
> and avoids busy-waiting.
But how do you know this is the non-atomic context?
> Update both instances to use fsleep(100).
--
With Best Regards,
Andy Shevchenko
next prev parent reply other threads:[~2026-02-26 7:46 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-02-25 20:45 [PATCH] staging: fbtft: fb_ra8875: replace udelays with usleep_range Jose A. Perez de Azpillaga
2026-02-25 21:14 ` Greg KH
2026-02-25 23:40 ` [PATCH v2] staging: fbtft: fb_ra8875: replace udelays with fsleep Jose A. Perez de Azpillaga
2026-02-26 7:46 ` Andy Shevchenko [this message]
2026-02-26 8:31 ` Jose A. Perez de Azpillaga
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=aZ_6QvJPZplh6xtd@smile.fi.intel.com \
--to=andriy.shevchenko@intel.com \
--cc=andy@kernel.org \
--cc=azpijr@gmail.com \
--cc=dri-devel@lists.freedesktop.org \
--cc=gregkh@linuxfoundation.org \
--cc=linux-fbdev@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-staging@lists.linux.dev \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox