Re: [PATCH] staging: rtl8723bs: fix spaces around binary operators

[Nikolay Kulikov <nikolayof23@gmail.com>]

On Wed, Feb 18, 2026 at 12:34:56PM -0600, Ethan Tidmore wrote:
> 
> Logical continuations should be on the previous line:
> 
> while (cnt < in_len) {
> 	if (eid == in_ie[cnt] &&
> 		(!oui || !memcmp(&in_ie[cnt + 2], oui, oui_len))) {
> 
...
> 
> Alignment should match open parenthesis:
> 
> if ((*wpa_ie != WLAN_EID_VENDOR_SPECIFIC) || (*(wpa_ie + 1) != (u8)(wpa_ie_len - 2)) ||
> 	(memcmp(wpa_ie+2, RTW_WPA_OUI_TYPE, WPA_SELECTOR_LEN))) {

Hi, i saw these issues when i was fixing the spaces, but i intentionally
didn't fix the indentation to avoid merging different changes into one
patch. I'm ready to send a sepatate patch with indentation fixes.


> >  
> >  	if (MCS_rate[0] & BIT(7))
> > -		max_rate = (bw_40MHz) ? ((short_GI)?1500:1350):((short_GI)?722:650);
> > +		max_rate = (bw_40MHz) ? ((short_GI) ? 1500:1350) : ((short_GI) ? 722:650);
> 
> You only fixed half of the problem here, you need to space out the other
> ternary operator conditions too:
> 
> max_rate = (bw_40MHz) ? ((short_GI) ? 1500 : 1350) : ((short_GI) ? 722 : 650);

I initially thought that fewer spaces made the nested ternary more
readable, but i completely agree that following the standard style is
the right approach for consistency. Will update in v2.


Thanks,
Nikolay